mbox series

[v5,0/8] dt-bindings: memory-controllers: ti,gpmc: Convert to yaml

Message ID 20211007120830.17221-1-rogerq@kernel.org (mailing list archive)
Headers show
Series dt-bindings: memory-controllers: ti,gpmc: Convert to yaml | expand

Message

Roger Quadros Oct. 7, 2021, 12:08 p.m. UTC
Hi,

This series converts ti,gpmc memory controller and ti,gpmc-nand and
ti,gpmc-onenand MTD controller bindings to yaml.

cheers,
-roger

Changelog:
v5
- separated DT changes so easy to review
- dropped ethernet@gpmc label changes. I was trying to fix the dtbs_check
 warning "'ethernet@gpmc' does not match any of the regexes: '@[0-7],[a-f0-9]+$', 'pinctrl-[0-9]+'"
 but the patch causes a side effect for omap4-duovero-parlor.dts such that the
 GPMC timings specified in the board DTS wer not being used but
 being overridden by omap-gpmc-smsc911x.dtsi instead. This is not what we
 want.
- dropped patch "memory: gpmc-omap: "gpmc,device-width" DT property is optional"
 I will pick this up in another series. Don't want this patch to hold back the .yaml cleanup series.
- arranged compatibles in alphabetical order in ti,gpmc.yaml
- fixed example in ti,gpmc-onenand.yaml
- Rebased on 5.15-rc1
- Added Acks

v4
- reference partition.yaml in ti,gpmc-nand.yaml and ti,gpmc-onenenc.yaml
- use address-cells/size-cells: true instead of absolute size.

v3:
- fix indentation
- split GPMC child timings/settings into ti,gpmc-child.yaml
This allows us to refer to it at 3 places and avoid use of
'additionalProperties: true' at 2 places.
- specify defaults where applicable
- reordered patches
- added patch for making "gpmc,device-width" optional with defaults.
- address all review comments.

v2:
- Fix all errors in dtbs_check and dt_bindings_check
- remove references to gpmc-omap.txt
- Convert ti,gpmc-nand and ti,gpmc-onenand bindings to yaml as well

Roger Quadros (8):
  dt-bindings: mtd: Remove gpmc-nor.txt
  dt-bindings: net: Remove gpmc-eth.txt
  dt-bindings: memory-controllers: Introduce ti,gpmc-child
  dt-bindings: mtd: ti,gpmc-nand: Convert to yaml
  dt-bindings: mtd: ti,gpmc-onenand: Convert to yaml
  dt-bindings: memory-controllers: ti,gpmc: Convert to yaml
  ARM: dts: omap: Fix boolean properties
    gpmc,cycle2cycle-{same|diff}csen
  ARM: dts: omap: fix gpmc,mux-add-data type

 .../bindings/memory-controllers/omap-gpmc.txt | 157 -----------
 .../memory-controllers/ti,gpmc-child.yaml     | 245 ++++++++++++++++++
 .../bindings/memory-controllers/ti,gpmc.yaml  | 172 ++++++++++++
 .../devicetree/bindings/mtd/gpmc-nand.txt     | 147 -----------
 .../devicetree/bindings/mtd/gpmc-nor.txt      |  98 -------
 .../devicetree/bindings/mtd/gpmc-onenand.txt  |  48 ----
 .../devicetree/bindings/mtd/ti,gpmc-nand.yaml | 121 +++++++++
 .../bindings/mtd/ti,gpmc-onenand.yaml         |  81 ++++++
 .../devicetree/bindings/net/gpmc-eth.txt      |  97 -------
 arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi     |   4 +-
 arch/arm/boot/dts/omap-gpmc-smsc9221.dtsi     |   2 +-
 arch/arm/boot/dts/omap-zoom-common.dtsi       |   4 +-
 arch/arm/boot/dts/omap2430-sdp.dts            |   4 +-
 .../arm/boot/dts/omap3-devkit8000-common.dtsi |   4 +-
 .../boot/dts/omap3-overo-tobiduo-common.dtsi  |   2 +-
 arch/arm/boot/dts/omap3-sb-t35.dtsi           |   4 +-
 16 files changed, 631 insertions(+), 559 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
 delete mode 100644 Documentation/devicetree/bindings/mtd/gpmc-nand.txt
 delete mode 100644 Documentation/devicetree/bindings/mtd/gpmc-nor.txt
 delete mode 100644 Documentation/devicetree/bindings/mtd/gpmc-onenand.txt
 create mode 100644 Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml
 create mode 100644 Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/gpmc-eth.txt

Comments

Krzysztof Kozlowski Oct. 7, 2021, 5:37 p.m. UTC | #1
On 07/10/2021 14:08, Roger Quadros wrote:
> Hi,
> 
> This series converts ti,gpmc memory controller and ti,gpmc-nand and
> ti,gpmc-onenand MTD controller bindings to yaml.
> 
> cheers,
> -roger
> 

Hi,

Although you did not mention it here, it looks like you have some
dependencies between the patches. Maybe this shall go simply via Rob's tree?

Best regards,
Krzysztof
Roger Quadros Oct. 8, 2021, 7:10 p.m. UTC | #2
Krzysztof,

On 07/10/2021 20:37, Krzysztof Kozlowski wrote:
> On 07/10/2021 14:08, Roger Quadros wrote:
>> Hi,
>>
>> This series converts ti,gpmc memory controller and ti,gpmc-nand and
>> ti,gpmc-onenand MTD controller bindings to yaml.
>>
>> cheers,
>> -roger
>>
> 
> Hi,
> 
> Although you did not mention it here, it looks like you have some
> dependencies between the patches. Maybe this shall go simply via Rob's tree?
> 

Rob has acked all the DT binding patches.
So it is upto you and Miquèl to decide the best way. MTD tree or Memory controller tree
for the dt-bindings patches.

The ARM: dts changes should go via Tony's OMAP SoC tree.

Or if Tony is OK with it then maybe all patches can go via Tony's tree? :)

cheers,
-roger
Krzysztof Kozlowski Oct. 9, 2021, 2:55 p.m. UTC | #3
On 08/10/2021 21:10, Roger Quadros wrote:
> Krzysztof,
> 
> On 07/10/2021 20:37, Krzysztof Kozlowski wrote:
>> On 07/10/2021 14:08, Roger Quadros wrote:
>>> Hi,
>>>
>>> This series converts ti,gpmc memory controller and ti,gpmc-nand and
>>> ti,gpmc-onenand MTD controller bindings to yaml.
>>>
>>> cheers,
>>> -roger
>>>
>>
>> Hi,
>>
>> Although you did not mention it here, it looks like you have some
>> dependencies between the patches. Maybe this shall go simply via Rob's tree?
>>
> 
> Rob has acked all the DT binding patches.
> So it is upto you and Miquèl to decide the best way. MTD tree or Memory controller tree
> for the dt-bindings patches.
> 
> The ARM: dts changes should go via Tony's OMAP SoC tree.
> 
> Or if Tony is OK with it then maybe all patches can go via Tony's tree? :)
> 


I reviewed the two memory-controller patches, so feel free to take them
via MTD or OMAP SoC.


Best regards,
Krzysztof
Tony Lindgren Oct. 11, 2021, 5:53 a.m. UTC | #4
* Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> [211009 14:56]:
> On 08/10/2021 21:10, Roger Quadros wrote:
> > Krzysztof,
> > 
> > On 07/10/2021 20:37, Krzysztof Kozlowski wrote:
> >> On 07/10/2021 14:08, Roger Quadros wrote:
> >>> Hi,
> >>>
> >>> This series converts ti,gpmc memory controller and ti,gpmc-nand and
> >>> ti,gpmc-onenand MTD controller bindings to yaml.
> >>>
> >>> cheers,
> >>> -roger
> >>>
> >>
> >> Hi,
> >>
> >> Although you did not mention it here, it looks like you have some
> >> dependencies between the patches. Maybe this shall go simply via Rob's tree?
> >>
> > 
> > Rob has acked all the DT binding patches.
> > So it is upto you and Miquèl to decide the best way. MTD tree or Memory controller tree
> > for the dt-bindings patches.
> > 
> > The ARM: dts changes should go via Tony's OMAP SoC tree.
> > 
> > Or if Tony is OK with it then maybe all patches can go via Tony's tree? :)
> > 
> 
> 
> I reviewed the two memory-controller patches, so feel free to take them
> via MTD or OMAP SoC.

Sounds like I should pick up these because of the dts changes.

Thanks,

Tony
Roger Quadros Oct. 11, 2021, 7:03 a.m. UTC | #5
Hi Tony,

On 11/10/2021 08:53, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> [211009 14:56]:
>> On 08/10/2021 21:10, Roger Quadros wrote:
>>> Krzysztof,
>>>
>>> On 07/10/2021 20:37, Krzysztof Kozlowski wrote:
>>>> On 07/10/2021 14:08, Roger Quadros wrote:
>>>>> Hi,
>>>>>
>>>>> This series converts ti,gpmc memory controller and ti,gpmc-nand and
>>>>> ti,gpmc-onenand MTD controller bindings to yaml.
>>>>>
>>>>> cheers,
>>>>> -roger
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> Although you did not mention it here, it looks like you have some
>>>> dependencies between the patches. Maybe this shall go simply via Rob's tree?
>>>>
>>>
>>> Rob has acked all the DT binding patches.
>>> So it is upto you and Miquèl to decide the best way. MTD tree or Memory controller tree
>>> for the dt-bindings patches.
>>>
>>> The ARM: dts changes should go via Tony's OMAP SoC tree.
>>>
>>> Or if Tony is OK with it then maybe all patches can go via Tony's tree? :)
>>>
>>
>>
>> I reviewed the two memory-controller patches, so feel free to take them
>> via MTD or OMAP SoC.
> 
> Sounds like I should pick up these because of the dts changes.

There is no dependency with the dts patches but it would be great if you can pick them all up.
Thanks!

cheers,
-roger
Tony Lindgren Oct. 11, 2021, 10:31 a.m. UTC | #6
* Roger Quadros <rogerq@kernel.org> [211011 07:04]:
> Hi Tony,
> 
> On 11/10/2021 08:53, Tony Lindgren wrote:
> > * Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> [211009 14:56]:
> >> On 08/10/2021 21:10, Roger Quadros wrote:
> >>> Krzysztof,
> >>>
> >>> On 07/10/2021 20:37, Krzysztof Kozlowski wrote:
> >>>> On 07/10/2021 14:08, Roger Quadros wrote:
> >>>>> Hi,
> >>>>>
> >>>>> This series converts ti,gpmc memory controller and ti,gpmc-nand and
> >>>>> ti,gpmc-onenand MTD controller bindings to yaml.
> >>>>>
> >>>>> cheers,
> >>>>> -roger
> >>>>>
> >>>>
> >>>> Hi,
> >>>>
> >>>> Although you did not mention it here, it looks like you have some
> >>>> dependencies between the patches. Maybe this shall go simply via Rob's tree?
> >>>>
> >>>
> >>> Rob has acked all the DT binding patches.
> >>> So it is upto you and Miquèl to decide the best way. MTD tree or Memory controller tree
> >>> for the dt-bindings patches.
> >>>
> >>> The ARM: dts changes should go via Tony's OMAP SoC tree.
> >>>
> >>> Or if Tony is OK with it then maybe all patches can go via Tony's tree? :)
> >>>
> >>
> >>
> >> I reviewed the two memory-controller patches, so feel free to take them
> >> via MTD or OMAP SoC.
> > 
> > Sounds like I should pick up these because of the dts changes.
> 
> There is no dependency with the dts patches but it would be great if you can pick them all up.

OK all pushed out now to omap-for-v5.16/gpmc.

Thanks,

Tony