mbox series

[0/3] dma/ti: enable udma and psil to be built as modules

Message ID 20220926181848.2917639-1-khilman@baylibre.com (mailing list archive)
Headers show
Series dma/ti: enable udma and psil to be built as modules | expand

Message

Kevin Hilman Sept. 26, 2022, 6:18 p.m. UTC
Enable the UDMA driver & glue and PSIL maps to be built & loaded as modules.

The defauilt Kconfig settings are not changed, so default upstream is
still to be built in.  This series just enables the option to build as
modules.

Kevin Hilman (3):
  of/irq: export of_msi_get_domain
  dma/ti: convert k3-udma to module
  dma/ti: convert PSIL to be buildable as module

 drivers/dma/ti/Kconfig          |  7 +++---
 drivers/dma/ti/k3-psil-am62.c   |  4 ++++
 drivers/dma/ti/k3-psil-am64.c   |  4 ++++
 drivers/dma/ti/k3-psil-am654.c  |  4 ++++
 drivers/dma/ti/k3-psil-j7200.c  |  4 ++++
 drivers/dma/ti/k3-psil-j721e.c  |  4 ++++
 drivers/dma/ti/k3-psil-j721s2.c |  4 ++++
 drivers/dma/ti/k3-psil.c        |  2 ++
 drivers/dma/ti/k3-udma-glue.c   |  5 ++++-
 drivers/dma/ti/k3-udma.c        | 40 +++++----------------------------
 drivers/of/irq.c                |  1 +
 11 files changed, 40 insertions(+), 39 deletions(-)

Comments

Péter Ujfalusi Sept. 26, 2022, 7:02 p.m. UTC | #1
Hi Kevin,

On 9/26/22 21:18, Kevin Hilman wrote:
> Enable the UDMA driver & glue and PSIL maps to be built & loaded as modules.
> 
> The defauilt Kconfig settings are not changed, so default upstream is
> still to be built in.  This series just enables the option to build as
> modules.

I can finally drop the half backed stuff I roll on top of -next ;)

Do you plan to convert the ringacc also? It is straight forward, like:
https://github.com/omap-audio/linux-audio/commit/01f9290c1c61e8bbc0fbdd877382672883ba7e73

> Kevin Hilman (3):
>   of/irq: export of_msi_get_domain
>   dma/ti: convert k3-udma to module
>   dma/ti: convert PSIL to be buildable as module
> 
>  drivers/dma/ti/Kconfig          |  7 +++---
>  drivers/dma/ti/k3-psil-am62.c   |  4 ++++
>  drivers/dma/ti/k3-psil-am64.c   |  4 ++++
>  drivers/dma/ti/k3-psil-am654.c  |  4 ++++
>  drivers/dma/ti/k3-psil-j7200.c  |  4 ++++
>  drivers/dma/ti/k3-psil-j721e.c  |  4 ++++
>  drivers/dma/ti/k3-psil-j721s2.c |  4 ++++
>  drivers/dma/ti/k3-psil.c        |  2 ++
>  drivers/dma/ti/k3-udma-glue.c   |  5 ++++-
>  drivers/dma/ti/k3-udma.c        | 40 +++++----------------------------
>  drivers/of/irq.c                |  1 +
>  11 files changed, 40 insertions(+), 39 deletions(-)
>
Kevin Hilman Sept. 26, 2022, 9:21 p.m. UTC | #2
Hi Péter,

Péter Ujfalusi <peter.ujfalusi@gmail.com> writes:

> On 9/26/22 21:18, Kevin Hilman wrote:
>> Enable the UDMA driver & glue and PSIL maps to be built & loaded as modules.
>> 
>> The defauilt Kconfig settings are not changed, so default upstream is
>> still to be built in.  This series just enables the option to build as
>> modules.
>
> I can finally drop the half backed stuff I roll on top of -next ;)
>
> Do you plan to convert the ringacc also? It is straight forward, like:
> https://github.com/omap-audio/linux-audio/commit/01f9290c1c61e8bbc0fbdd877382672883ba7e73

Yes, my colleague Nicolas (cc'd) was planning ringacc shortly, but we
didn't realize you had already don it.  Your version looks fine to me.
Any reason not to submit yours?

Kevin
Péter Ujfalusi Sept. 27, 2022, 5:21 p.m. UTC | #3
On 27/09/2022 00:21, Kevin Hilman wrote:
> Hi Péter,
> 
> Péter Ujfalusi <peter.ujfalusi@gmail.com> writes:
> 
>> On 9/26/22 21:18, Kevin Hilman wrote:
>>> Enable the UDMA driver & glue and PSIL maps to be built & loaded as modules.
>>>
>>> The defauilt Kconfig settings are not changed, so default upstream is
>>> still to be built in.  This series just enables the option to build as
>>> modules.
>>
>> I can finally drop the half backed stuff I roll on top of -next ;)
>>
>> Do you plan to convert the ringacc also? It is straight forward, like:
>> https://github.com/omap-audio/linux-audio/commit/01f9290c1c61e8bbc0fbdd877382672883ba7e73
> 
> Yes, my colleague Nicolas (cc'd) was planning ringacc shortly, but we
> didn't realize you had already don it.  Your version looks fine to me.
> Any reason not to submit yours?

It can only be sent after the UDMA is able to be built as a module.
When I did the module support there were also a tisci dependency which 
for some reason took too long for me to be able to send these.

I can send my version later if it is OK, but if Nicolas have a better 
take on it, I don't mind.
Kevin Hilman Sept. 27, 2022, 11:10 p.m. UTC | #4
Péter Ujfalusi <peter.ujfalusi@gmail.com> writes:

> On 27/09/2022 00:21, Kevin Hilman wrote:
>> Hi Péter,
>> 
>> Péter Ujfalusi <peter.ujfalusi@gmail.com> writes:
>> 
>>> On 9/26/22 21:18, Kevin Hilman wrote:
>>>> Enable the UDMA driver & glue and PSIL maps to be built & loaded as modules.
>>>>
>>>> The defauilt Kconfig settings are not changed, so default upstream is
>>>> still to be built in.  This series just enables the option to build as
>>>> modules.
>>>
>>> I can finally drop the half backed stuff I roll on top of -next ;)
>>>
>>> Do you plan to convert the ringacc also? It is straight forward, like:
>>> https://github.com/omap-audio/linux-audio/commit/01f9290c1c61e8bbc0fbdd877382672883ba7e73
>> 
>> Yes, my colleague Nicolas (cc'd) was planning ringacc shortly, but we
>> didn't realize you had already don it.  Your version looks fine to me.
>> Any reason not to submit yours?
>
> It can only be sent after the UDMA is able to be built as a module.

OK, I sent a v2 of this series, which I think should be ready for merge
now.

> When I did the module support there were also a tisci dependency which 
> for some reason took too long for me to be able to send these.
> I can send my version later if it is OK, but if Nicolas have a better 
> take on it, I don't mind.

We've got a handful of other conversions coming for a fully modular
kernel, so I'm sure Nicolas would be happy if you took care of
ringacc. :)

Kevin
Péter Ujfalusi Sept. 28, 2022, 1:54 p.m. UTC | #5
On 28/09/2022 02:10, Kevin Hilman wrote:
>> When I did the module support there were also a tisci dependency which
>> for some reason took too long for me to be able to send these.
>> I can send my version later if it is OK, but if Nicolas have a better
>> take on it, I don't mind.
> 
> We've got a handful of other conversions coming for a fully modular
> kernel, so I'm sure Nicolas would be happy if you took care of
> ringacc. :)

Sure, I will send it when the UDMA part is merged.