mbox series

[v2,0/4] net: ethernet: ti: am65-cpsw: Fix set channel operation

Message ID 20221121142300.9320-1-rogerq@kernel.org (mailing list archive)
Headers show
Series net: ethernet: ti: am65-cpsw: Fix set channel operation | expand

Message

Roger Quadros Nov. 21, 2022, 2:22 p.m. UTC 
Hi,

This contains a critical bug fix for the recently merged suspend/resume
support that broke set channel operation. (ethtool -L eth0 tx <n>)

Remaining patches are optimizations.

cheers,
-roger

Changelog:
v2:
-Fix build warning
 drivers/net/ethernet/ti/am65-cpsw-nuss.c:562:13: warning: variable 'tmo' set but not used [-Wunused-but-set-variable]

Roger Quadros (4):
  net: ethernet: ti: am65-cpsw: Fix set channel operation
  net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR
  net: ethernet: ti: am65-cpsw: Restore ALE only if any interface was up
  net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore()

 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 167 +++++++++++++----------
 drivers/net/ethernet/ti/cpsw_ale.c       |   7 +-
 2 files changed, 99 insertions(+), 75 deletions(-)

Comments

Maciej Fijalkowski Nov. 21, 2022, 5:11 p.m. UTC | #1 
On Mon, Nov 21, 2022 at 03:22:56PM +0100, Roger Quadros wrote:
> Hi,

Hi,

> 
> This contains a critical bug fix for the recently merged suspend/resume
> support that broke set channel operation. (ethtool -L eth0 tx <n>)
> 
> Remaining patches are optimizations.

So I think you should resend and specify which trees should these patches
be routed to. I'd say first one goes to net with fixes tag and rest should
go to net-next.

Let me take a look at the contents of this series.

> 
> cheers,
> -roger
> 
> Changelog:
> v2:
> -Fix build warning
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c:562:13: warning: variable 'tmo' set but not used [-Wunused-but-set-variable]
> 
> Roger Quadros (4):
>   net: ethernet: ti: am65-cpsw: Fix set channel operation
>   net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR
>   net: ethernet: ti: am65-cpsw: Restore ALE only if any interface was up
>   net: ethernet: ti: cpsw_ale: optimize cpsw_ale_restore()
> 
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 167 +++++++++++++----------
>  drivers/net/ethernet/ti/cpsw_ale.c       |   7 +-
>  2 files changed, 99 insertions(+), 75 deletions(-)
> 
> -- 
> 2.17.1
>