mbox series

[00/10] usb: musb: Convert to platform remove callback returning void

Message ID 20230405141009.3400693-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series usb: musb: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König April 5, 2023, 2:09 p.m. UTC
Hello,

this patch series adapts the platform drivers below drivers/usb/musb
to use the .remove_new() callback. Compared to the traditional .remove()
callback .remove_new() returns no value. This is a good thing because
the driver core doesn't (and cannot) cope for errors during remove. The
only effect of a non-zero return value in .remove() is that the driver
core emits a warning. The device is removed anyhow and an early return
from .remove() usually yields a resource leak.

By changing the remove callback to return void driver authors cannot
reasonably assume any more that there is some kind of cleanup later.

All drivers touched here returned zero unconditionally in their remove
callback, so they could all be converted trivially to .remove_new().

Best regards
Uwe

Uwe Kleine-König (10):
  usb: musb: da8xx: Convert to platform remove callback returning void
  usb: musb: jz4740: Convert to platform remove callback returning void
  usb: musb: mediatek: Convert to platform remove callback returning void
  usb: musb: mpfs: Convert to platform remove callback returning void
  usb: musb: musb_core: Convert to platform remove callback returning void
  usb: musb: musb_dsps: Convert to platform remove callback returning void
  usb: musb: omap2430: Convert to platform remove callback returning void
  usb: musb: sunxi: Convert to platform remove callback returning void
  usb: musb: tusb6010: Convert to platform remove callback returning void
  usb: musb: ux500: Convert to platform remove callback returning void

 drivers/usb/musb/da8xx.c     | 6 ++----
 drivers/usb/musb/jz4740.c    | 6 ++----
 drivers/usb/musb/mediatek.c  | 6 ++----
 drivers/usb/musb/mpfs.c      | 6 ++----
 drivers/usb/musb/musb_core.c | 5 ++---
 drivers/usb/musb/musb_dsps.c | 6 ++----
 drivers/usb/musb/omap2430.c  | 6 ++----
 drivers/usb/musb/sunxi.c     | 6 ++----
 drivers/usb/musb/tusb6010.c  | 6 ++----
 drivers/usb/musb/ux500.c     | 6 ++----
 10 files changed, 20 insertions(+), 39 deletions(-)

base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6