From patchwork Mon Nov 6 17:17:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13447205 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEECDC4332F for ; Mon, 6 Nov 2023 17:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbjKFRSM (ORCPT ); Mon, 6 Nov 2023 12:18:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjKFRSL (ORCPT ); Mon, 6 Nov 2023 12:18:11 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05137125 for ; Mon, 6 Nov 2023 09:18:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r03EV-0005QQ-75; Mon, 06 Nov 2023 18:17:51 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r03ER-0075yD-9N; Mon, 06 Nov 2023 18:17:47 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r03EQ-00DrIi-VZ; Mon, 06 Nov 2023 18:17:46 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Tony Lindgren , linux-omap@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 00/18] mfd: Convert to platform remove callback returning void Date: Mon, 6 Nov 2023 18:17:09 +0100 Message-ID: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3116; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0FF0Hir69E2HKsvJfQNY/ddJ62LkMYTY7VB8GGwosMM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSR+UEVz6EdKPvoEWe/b9VJEfQp/9GrduLgHED EGfX/1hsAWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUkflAAKCRCPgPtYfRL+ TrkgCACt6jktG815FM78opuMSJzVh8L8EMrXJg2QcTB4PFmiFdLTrdybne7rIjMRxTpAjmsba0v VL8Ob6Kz8AmNLdjbx3qjHYArjUhG2hGyldjimtJxv5vEEpdcpJbJnl2Tj3vdtAWxfk4DE0K3xcl TTIh0MSMGJsPKQiE/fuKjG8fzS3mk8bORQEu+5KMYAVZLQdUsoZcmUULLWFdnOvaqFxrGackoTM 51EtiqsmxEKubEHJa0r+WpKi3bNHl/nRXTPU4MNCLO2JCXXY3cRSJ24qriAGi/+BvbLWiNrdVRN adO9ADuSwQuYtHKSkBXthB6PplIwkbPbXVaxwNvTbbhwprJY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-omap@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hello, this series converts all platform drivers below drivers/mfd to use .remove_new(). Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields resource leaks and/or use-after-free bugs. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. All drivers converted here already returned zero unconditionally in .remove(), so they are converted here trivially. Best regards Uwe Uwe Kleine-König (18): mfd: ab8500-sysctrl: Convert to platform remove callback returning void mfd: cros_ec_dev: Convert to platform remove callback returning void mfd: exynos-lpass: Convert to platform remove callback returning void mfd: fsl-imx25-tsadc: Convert to platform remove callback returning void mfd: hi655x-pmic: Convert to platform remove callback returning void mfd: intel-lpss-acpi: Convert to platform remove callback returning void mfd: kempld-core: Convert to platform remove callback returning void mfd: mcp-sa11x0: Convert to platform remove callback returning void mfd: mxs-lradc: Convert to platform remove callback returning void mfd: omap-usb-host: Convert to platform remove callback returning void mfd: omap-usb-tll: Convert to platform remove callback returning void mfd: pcf50633-adc: Convert to platform remove callback returning void mfd: qcom-pm8xxx: Convert to platform remove callback returning void mfd: sm501: Convert to platform remove callback returning void mfd: stm32-timers: Convert to platform remove callback returning void mfd: ti_am335x_tscadc: Convert to platform remove callback returning void mfd: tps65911-comparator: Convert to platform remove callback returning void mfd: twl4030-audio: Convert to platform remove callback returning void drivers/mfd/ab8500-sysctrl.c | 6 ++---- drivers/mfd/cros_ec_dev.c | 5 ++--- drivers/mfd/exynos-lpass.c | 6 ++---- drivers/mfd/fsl-imx25-tsadc.c | 6 ++---- drivers/mfd/hi655x-pmic.c | 5 ++--- drivers/mfd/intel-lpss-acpi.c | 6 ++---- drivers/mfd/kempld-core.c | 6 ++---- drivers/mfd/mcp-sa11x0.c | 6 ++---- drivers/mfd/mxs-lradc.c | 6 ++---- drivers/mfd/omap-usb-host.c | 5 ++--- drivers/mfd/omap-usb-tll.c | 5 ++--- drivers/mfd/pcf50633-adc.c | 6 ++---- drivers/mfd/qcom-pm8xxx.c | 6 ++---- drivers/mfd/sm501.c | 6 ++---- drivers/mfd/stm32-timers.c | 6 ++---- drivers/mfd/ti_am335x_tscadc.c | 6 ++---- drivers/mfd/tps65911-comparator.c | 6 ++---- drivers/mfd/twl4030-audio.c | 6 ++---- 18 files changed, 36 insertions(+), 68 deletions(-) base-commit: 3ff7a5781ceee3befb9224d29cef6e6a4766c5fe