mbox series

[v2,0/4] ARM: dts: omap: omap4-epson-embt2ws: misc gpio definitions

Message ID 20241010122957.85164-1-andreas@kemnade.info (mailing list archive)
Headers show
Series ARM: dts: omap: omap4-epson-embt2ws: misc gpio definitions | expand

Message

Andreas Kemnade Oct. 10, 2024, 12:29 p.m. UTC
Bring the system into a more defined state and do not rely
on things being initialized by bootloader.

Changes in V2:
- better comment strange GPIOs
- proper names for regulator nodes

Andreas Kemnade (4):
  ARM: dts: omap: omap4-epson-embt2ws: define GPIO regulators
  ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
  ARM: dts: omap: omap4-epson-embt2ws: add unknown gpio outputs
  ARM: dts: omap: omap4-epson-embt2ws: add GPIO expander

 .../boot/dts/ti/omap/omap4-epson-embt2ws.dts  | 183 +++++++++++++++++-
 1 file changed, 179 insertions(+), 4 deletions(-)

Comments

Rob Herring Oct. 10, 2024, 2:30 p.m. UTC | #1
On Thu, 10 Oct 2024 14:29:53 +0200, Andreas Kemnade wrote:
> Bring the system into a more defined state and do not rely
> on things being initialized by bootloader.
> 
> Changes in V2:
> - better comment strange GPIOs
> - proper names for regulator nodes
> 
> Andreas Kemnade (4):
>   ARM: dts: omap: omap4-epson-embt2ws: define GPIO regulators
>   ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
>   ARM: dts: omap: omap4-epson-embt2ws: add unknown gpio outputs
>   ARM: dts: omap: omap4-epson-embt2ws: add GPIO expander
> 
>  .../boot/dts/ti/omap/omap4-epson-embt2ws.dts  | 183 +++++++++++++++++-
>  1 file changed, 179 insertions(+), 4 deletions(-)
> 
> --
> 2.39.5
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y ti/omap/omap4-epson-embt2ws.dtb' for 20241010122957.85164-1-andreas@kemnade.info:

arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 74, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[115]], 'interrupts-extended': [[1, 0, 74, 4], [116, 260]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
	from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[118, 119]], 'interrupts-extended': [[1, 0, 73, 4], [116, 220]], 'bluetooth-gnss': {'compatible': ['ti,wl1283-st'], 'enable-gpios': [[120, 25, 0]], 'clocks': [[121, 1]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
	from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
Andreas Kemnade Oct. 17, 2024, 9:49 a.m. UTC | #2
Am Thu, 10 Oct 2024 09:30:09 -0500
schrieb "Rob Herring (Arm)" <robh@kernel.org>:

> On Thu, 10 Oct 2024 14:29:53 +0200, Andreas Kemnade wrote:
> > Bring the system into a more defined state and do not rely
> > on things being initialized by bootloader.
> > 
> > Changes in V2:
> > - better comment strange GPIOs
> > - proper names for regulator nodes
> > 
> > Andreas Kemnade (4):
> >   ARM: dts: omap: omap4-epson-embt2ws: define GPIO regulators
> >   ARM: dts: omap: omap4-epson-embt2ws: wire up regulators
> >   ARM: dts: omap: omap4-epson-embt2ws: add unknown gpio outputs
> >   ARM: dts: omap: omap4-epson-embt2ws: add GPIO expander
> > 
> >  .../boot/dts/ti/omap/omap4-epson-embt2ws.dts  | 183
> > +++++++++++++++++- 1 file changed, 179 insertions(+), 4 deletions(-)
> > 
> > --
> > 2.39.5
> > 
> > 
> >   
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in
> this series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the
> warnings are fixed by another series. Ultimately, it is up to the
> platform maintainer whether these warnings are acceptable or not. No
> need to reply unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y
> ti/omap/omap4-epson-embt2ws.dtb' for
> 20241010122957.85164-1-andreas@kemnade.info:
> 
> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dtb: serial@0:
> {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts':
> [[0, 74, 4]], 'clock-frequency': 48000000, 'pinctrl-names':
> ['default'], 'pinctrl-0': [[115]], 'interrupts-extended': [[1, 0, 74,
> 4], [116, 260]], '$nodename': ['serial@0']} is valid under each of
> {'required': ['interrupts-extended']}, {'required': ['interrupts']}
> from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dtb: serial@0:
> {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts':
> [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names':
> ['default'], 'pinctrl-0': [[118, 119]], 'interrupts-extended': [[1,
> 0, 73, 4], [116, 220]], 'bluetooth-gnss': {'compatible':
> ['ti,wl1283-st'], 'enable-gpios': [[120, 25, 0]], 'clocks': [[121,
> 1]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is
> valid under each of {'required': ['interrupts-extended']},
> {'required': ['interrupts']} from schema $id:
> http://devicetree.org/schemas/serial/8250_omap.yaml#
>
To make sure I am getting this right: According to wdiff, the
difference is:

 'pinctrl-0': [-[[116, 117]],-] {+[[118, 119]],+}
'interrupts-extended': [[1, 0, 73, 4], [-[114,-] {+[116,+} 220]]

So my understanding is that phandle numbers are reordered and one
of the reordered numbers pops up in a warning message and cannot
easily be filtered away. Are there any tools or procedures in general to
filter out phandle reenumeration noise? Also when reordering things
expecting no functional change and diffing dtbs that would be helpful.

Regards,
Andreas