mbox series

[v5,0/5] Add TI TPS65214 & TPS65215 PMIC MFD Driver Support

Message ID 20250206173725.386720-1-s-ramamoorthy@ti.com (mailing list archive)
Headers show
Series Add TI TPS65214 & TPS65215 PMIC MFD Driver Support | expand

Message

Shree Ramamoorthy Feb. 6, 2025, 5:37 p.m. UTC 
TPS65214 and TPS65215 are Power Management Integrated Circuits (PMICs) that
have significant register map overlap with TPS65219 and each other. The 
series introduces the 2 new PMICs and restructures the existing driver to 
support multiple devices.

- TPS65214, TPS65215, and TPS65219 each have 3 Buck regulators
- TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
- TPS65214's LDO1 maps to TPS65219's LDO3.
- A key difference between TPS65215 & TPS65214 are the LDO current and
  voltage output ranges and the configurable options available.
- TPS65215 has 2 LDOs, whereas TPS65219 has 4 LDOs.
- TPS65215's LDO2 maps to TPS65219's LDO3.
- TPS65215 has 1 GPO, whereas TPS65219 has 2 GPOs.

TPS65214 TRM: https://www.ti.com/lit/pdf/slvud30
TPS65215 TRM: https://www.ti.com/lit/pdf/slvucw5/

AM62L + TPS65214 Test Logs:
https://gist.github.com/ramamoorthyhs/0793f7813332d94423ca1baee02f62c9
AM62L + TPS65215 Test Logs:
https://gist.github.com/ramamoorthyhs/7560eca6110fafc77b51894fa2c0fd22

---
Change Log:
v4 -> v5:
- TPS65214 dt-binding patch: Remove duplicated "then:", combine "if:" 
  statements with enum.
v3 -> v4:
- Update commit header to be "mfd: tps65219" since the driver name has not 
  been changed from TPS65219.
- Added dt-bindings patches to mfd series.
- Combined TPS65214 & TPS65215 dt-binding and mfd patches into 1 series, 
  since the series' share a dependency & these patches add more device support
- Elimate the need for TPS65214 gpio patches by registering TPS65214 as 
  "tps65215-gpio" from the MFD driver, since both have the same GPIO module
- "Remove regmap_read" patch: Drop chip_id variable
- move enum pmic_id struct from "remove regmap_read" patch to "Add support 
  for TPS65215" patch.
v2 -> v3:
- Remove duplicated of_device_id table entries
- Re-order mfd patches to clean up diff displayed
v1 -> v2:
- have any PMIC lists be in alpha-numeric order: TPS65215, then TPS65219
- Add driver prefix to chip_data struct
---
Shree Ramamoorthy (5):
  regulator: dt-bindings: Add TI TPS65215 PMIC bindings
  regulator: dt-bindings: Add TI TPS65214 PMIC bindings
  mfd: tps65219: Remove regmap_read check
  mfd: tps65219: Add support for TI TPS65215 PMIC
  mfd: tps65219: Add support for TI TPS65214 PMIC

 .../bindings/regulator/ti,tps65219.yaml       |  27 +-
 drivers/mfd/tps65219.c                        | 279 +++++++++++++++++-
 include/linux/mfd/tps65219.h                  | 136 ++++++++-
 3 files changed, 417 insertions(+), 25 deletions(-)

Comments

Lee Jones Feb. 11, 2025, 3:02 p.m. UTC | #1 
On Thu, 06 Feb 2025 11:37:20 -0600, Shree Ramamoorthy wrote:
> TPS65214 and TPS65215 are Power Management Integrated Circuits (PMICs) that
> have significant register map overlap with TPS65219 and each other. The
> series introduces the 2 new PMICs and restructures the existing driver to
> support multiple devices.
> 
> - TPS65214, TPS65215, and TPS65219 each have 3 Buck regulators
> - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
> - TPS65214's LDO1 maps to TPS65219's LDO3.
> - A key difference between TPS65215 & TPS65214 are the LDO current and
>   voltage output ranges and the configurable options available.
> - TPS65215 has 2 LDOs, whereas TPS65219 has 4 LDOs.
> - TPS65215's LDO2 maps to TPS65219's LDO3.
> - TPS65215 has 1 GPO, whereas TPS65219 has 2 GPOs.
> 
> [...]

Applied, thanks!

[1/5] regulator: dt-bindings: Add TI TPS65215 PMIC bindings
      commit: 85e7aef57a9e057545017d55b02073e3c4756b2c
[2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings
      commit: 34beb3c87cbb8747f521db5cf1b2a608833f3967
[3/5] mfd: tps65219: Remove regmap_read check
      commit: 5342c8a9e04fc05f485a3886605b803a5180bd64
[4/5] mfd: tps65219: Add support for TI TPS65215 PMIC
      commit: ebcbd21550853b16f307d7da8c846b862e138a98
[5/5] mfd: tps65219: Add support for TI TPS65214 PMIC
      commit: c9878d8d9ac2ecfadfa4fa3543730026c66ad843

--
Lee Jones [李琼斯]
Shree Ramamoorthy March 5, 2025, 9:09 p.m. UTC | #2 
Hi Lee,


On 2/11/25 9:02 AM, Lee Jones wrote:
> On Thu, 06 Feb 2025 11:37:20 -0600, Shree Ramamoorthy wrote:
>> TPS65214 and TPS65215 are Power Management Integrated Circuits (PMICs) that
>> have significant register map overlap with TPS65219 and each other. The
>> series introduces the 2 new PMICs and restructures the existing driver to
>> support multiple devices.
>>
>> - TPS65214, TPS65215, and TPS65219 each have 3 Buck regulators
>> - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
>> - TPS65214's LDO1 maps to TPS65219's LDO3.
>> - A key difference between TPS65215 & TPS65214 are the LDO current and
>>    voltage output ranges and the configurable options available.
>> - TPS65215 has 2 LDOs, whereas TPS65219 has 4 LDOs.
>> - TPS65215's LDO2 maps to TPS65219's LDO3.
>> - TPS65215 has 1 GPO, whereas TPS65219 has 2 GPOs.
>>
>> [...]
> Applied, thanks!
>
> [1/5] regulator: dt-bindings: Add TI TPS65215 PMIC bindings
>        commit: 85e7aef57a9e057545017d55b02073e3c4756b2c
> [2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings
>        commit: 34beb3c87cbb8747f521db5cf1b2a608833f3967
> [3/5] mfd: tps65219: Remove regmap_read check
>        commit: 5342c8a9e04fc05f485a3886605b803a5180bd64
> [4/5] mfd: tps65219: Add support for TI TPS65215 PMIC
>        commit: ebcbd21550853b16f307d7da8c846b862e138a98
> [5/5] mfd: tps65219: Add support for TI TPS65214 PMIC
>        commit: c9878d8d9ac2ecfadfa4fa3543730026c66ad843
>
> --
> Lee Jones [李琼斯]

Would you be able to remove this series from your branch & replace it with this v6 [0],
so Mark Brown will be able to apply the dependent regulator series [1]? Thank you!

[0] https://lore.kernel.org/all/20250305210351.249811-1-s-ramamoorthy@ti.com/

[1] https://lore.kernel.org/all/131466cc-dc54-4251-82f7-5ec9e9c20f26@sirena.org.uk/
Krzysztof Kozlowski March 6, 2025, 7:26 a.m. UTC | #3 
On 05/03/2025 22:09, Shree Ramamoorthy wrote:
> Hi Lee,
> 
> 
> On 2/11/25 9:02 AM, Lee Jones wrote:
>> On Thu, 06 Feb 2025 11:37:20 -0600, Shree Ramamoorthy wrote:
>>> TPS65214 and TPS65215 are Power Management Integrated Circuits (PMICs) that
>>> have significant register map overlap with TPS65219 and each other. The
>>> series introduces the 2 new PMICs and restructures the existing driver to
>>> support multiple devices.
>>>
>>> - TPS65214, TPS65215, and TPS65219 each have 3 Buck regulators
>>> - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
>>> - TPS65214's LDO1 maps to TPS65219's LDO3.
>>> - A key difference between TPS65215 & TPS65214 are the LDO current and
>>>    voltage output ranges and the configurable options available.
>>> - TPS65215 has 2 LDOs, whereas TPS65219 has 4 LDOs.
>>> - TPS65215's LDO2 maps to TPS65219's LDO3.
>>> - TPS65215 has 1 GPO, whereas TPS65219 has 2 GPOs.
>>>
>>> [...]
>> Applied, thanks!
>>
>> [1/5] regulator: dt-bindings: Add TI TPS65215 PMIC bindings
>>        commit: 85e7aef57a9e057545017d55b02073e3c4756b2c
>> [2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings
>>        commit: 34beb3c87cbb8747f521db5cf1b2a608833f3967
>> [3/5] mfd: tps65219: Remove regmap_read check
>>        commit: 5342c8a9e04fc05f485a3886605b803a5180bd64
>> [4/5] mfd: tps65219: Add support for TI TPS65215 PMIC
>>        commit: ebcbd21550853b16f307d7da8c846b862e138a98
>> [5/5] mfd: tps65219: Add support for TI TPS65214 PMIC
>>        commit: c9878d8d9ac2ecfadfa4fa3543730026c66ad843
>>
>> --
>> Lee Jones [李琼斯]
> 
> Would you be able to remove this series from your branch & replace it with this v6 [0],
> so Mark Brown will be able to apply the dependent regulator series [1]? Thank you!

You replied 3 weeks later. If something was applied not as it should,
you ought to reply IMMEDIATELY, not 3 weeks after.

The trees are mostly immutable after publishing.

Best regards,
Krzysztof
Shree Ramamoorthy March 6, 2025, 10:56 p.m. UTC | #4 
Hi,

On 3/6/2025 1:26 AM, Krzysztof Kozlowski wrote:
> On 05/03/2025 22:09, Shree Ramamoorthy wrote:
>> Hi Lee,
>>
>>
>> On 2/11/25 9:02 AM, Lee Jones wrote:
>>> On Thu, 06 Feb 2025 11:37:20 -0600, Shree Ramamoorthy wrote:
>>>> TPS65214 and TPS65215 are Power Management Integrated Circuits (PMICs) that
>>>> have significant register map overlap with TPS65219 and each other. The
>>>> series introduces the 2 new PMICs and restructures the existing driver to
>>>> support multiple devices.
>>>>
>>>> - TPS65214, TPS65215, and TPS65219 each have 3 Buck regulators
>>>> - TPS65214 has 2 LDOS and 1 GPO, whereas TPS65219 has 4 LDOs and 2 GPOs.
>>>> - TPS65214's LDO1 maps to TPS65219's LDO3.
>>>> - A key difference between TPS65215 & TPS65214 are the LDO current and
>>>>    voltage output ranges and the configurable options available.
>>>> - TPS65215 has 2 LDOs, whereas TPS65219 has 4 LDOs.
>>>> - TPS65215's LDO2 maps to TPS65219's LDO3.
>>>> - TPS65215 has 1 GPO, whereas TPS65219 has 2 GPOs.
>>>>
>>>> [...]
>>> Applied, thanks!
>>>
>>> [1/5] regulator: dt-bindings: Add TI TPS65215 PMIC bindings
>>>        commit: 85e7aef57a9e057545017d55b02073e3c4756b2c
>>> [2/5] regulator: dt-bindings: Add TI TPS65214 PMIC bindings
>>>        commit: 34beb3c87cbb8747f521db5cf1b2a608833f3967
>>> [3/5] mfd: tps65219: Remove regmap_read check
>>>        commit: 5342c8a9e04fc05f485a3886605b803a5180bd64
>>> [4/5] mfd: tps65219: Add support for TI TPS65215 PMIC
>>>        commit: ebcbd21550853b16f307d7da8c846b862e138a98
>>> [5/5] mfd: tps65219: Add support for TI TPS65214 PMIC
>>>        commit: c9878d8d9ac2ecfadfa4fa3543730026c66ad843
>>>
>>> --
>>> Lee Jones [李琼斯]
>> Would you be able to remove this series from your branch & replace it with this v6 [0],
>> so Mark Brown will be able to apply the dependent regulator series [1]? Thank you!
> You replied 3 weeks later. If something was applied not as it should,
> you ought to reply IMMEDIATELY, not 3 weeks after.
>
> The trees are mostly immutable after publishing.
>
> Best regards,
> Krzysztof

Completely understand, sorry for re-sending the first 5 patches that were already applied!
I'll wait for the next merge window, so there won't be dependencies between the MFD and regulator tree then.
Kory Maincent March 26, 2025, 4:42 p.m. UTC | #5 
On Thu, 6 Mar 2025 16:56:56 -0600
Shree Ramamoorthy <s-ramamoorthy@ti.com> wrote:

> Hi,
> 
> On 3/6/2025 1:26 AM, Krzysztof Kozlowski wrote:
> > On 05/03/2025 22:09, Shree Ramamoorthy wrote:  
> >> Hi Lee,
> >>
> >>
> >> On 2/11/25 9:02 AM, Lee Jones wrote:  
>  [...]  
>  [...]  
>  [...]  
> >> Would you be able to remove this series from your branch & replace it with
> >> this v6 [0], so Mark Brown will be able to apply the dependent regulator
> >> series [1]? Thank you!  
> > You replied 3 weeks later. If something was applied not as it should,
> > you ought to reply IMMEDIATELY, not 3 weeks after.
> >
> > The trees are mostly immutable after publishing.
> >
> > Best regards,
> > Krzysztof  
> 
> Completely understand, sorry for re-sending the first 5 patches that were
> already applied! I'll wait for the next merge window, so there won't be
> dependencies between the MFD and regulator tree then.

Hello Shree,

I think what you should have asked here was a to use an immutable tag to let
Mark uses this tag to merge the regulator part of the series on top of it.
We use immutable tag when work need to be merged thought several Linux
merge tree.

It seems Lee does not remove the MFD support so now that we are in the merge
window, you just need to wait two weeks and repost the regulator part.

Regards,