| Message ID | 20250311-mvneta-xdp-meta-v1-0-36cf1c99790e@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: xdp: Add missing metadata support for some xdp drvs | expand |
On Tue, Mar 11, 2025 at 01:18:32PM +0100, Lorenzo Bianconi wrote: > Introduce missing metadata support for some xdp drivers setting metadata > size building the skb from xdp_buff. > Please note most of the drivers are just compile tested. > > --- > Lorenzo Bianconi (7): > net: mvneta: Add metadata support for xdp mode > net: mvpp2: Add metadata support for xdp mode > net: netsec: Add metadata support for xdp mode > net: octeontx2: Add metadata support for xdp mode > net: ethernet: mediatek: Add metadata support for xdp mode > net: mana: Add metadata support for xdp mode > net: ti: cpsw: Add metadata support for xdp mode > > drivers/net/ethernet/marvell/mvneta.c | 5 ++++- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 ++++++-- > drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 13 +++++++++---- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 7 +++++-- > drivers/net/ethernet/microsoft/mana/mana_bpf.c | 2 +- > drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++++ > drivers/net/ethernet/socionext/netsec.c | 7 +++++-- > drivers/net/ethernet/ti/cpsw.c | 6 +++++- > drivers/net/ethernet/ti/cpsw_new.c | 6 +++++- > 9 files changed, 44 insertions(+), 14 deletions(-) > --- > base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe > change-id: 20250310-mvneta-xdp-meta-3e0da8ef4498 > > Best regards, > -- > Lorenzo Bianconi <lorenzo@kernel.org> > > As far as I checked, all modified drivers use the Page Pool and set the XDP headroom. So, a necessary space for metadata seems to be assured for all of the drivers. In summary, the series looks OK. Thanks, Michal For the series: Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
On 3/11/25 1:18 PM, Lorenzo Bianconi wrote: > Introduce missing metadata support for some xdp drivers setting metadata > size building the skb from xdp_buff. > Please note most of the drivers are just compile tested. I'm sorry, but you should at very least report explicitly on per patch basis which ones have been compile tested. Even better, please additionally document in each patch why/how the current headroom is large enough. Thanks, Paolo
> On 3/11/25 1:18 PM, Lorenzo Bianconi wrote: > > Introduce missing metadata support for some xdp drivers setting metadata > > size building the skb from xdp_buff. > > Please note most of the drivers are just compile tested. > > I'm sorry, but you should at very least report explicitly on per patch > basis which ones have been compile tested. > > Even better, please additionally document in each patch why/how the > current headroom is large enough. ack, I will do in v2. Regards, Lorenzo > > Thanks, > > Paolo >
Introduce missing metadata support for some xdp drivers setting metadata size building the skb from xdp_buff. Please note most of the drivers are just compile tested. --- Lorenzo Bianconi (7): net: mvneta: Add metadata support for xdp mode net: mvpp2: Add metadata support for xdp mode net: netsec: Add metadata support for xdp mode net: octeontx2: Add metadata support for xdp mode net: ethernet: mediatek: Add metadata support for xdp mode net: mana: Add metadata support for xdp mode net: ti: cpsw: Add metadata support for xdp mode drivers/net/ethernet/marvell/mvneta.c | 5 ++++- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 ++++++-- drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 13 +++++++++---- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 7 +++++-- drivers/net/ethernet/microsoft/mana/mana_bpf.c | 2 +- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++++ drivers/net/ethernet/socionext/netsec.c | 7 +++++-- drivers/net/ethernet/ti/cpsw.c | 6 +++++- drivers/net/ethernet/ti/cpsw_new.c | 6 +++++- 9 files changed, 44 insertions(+), 14 deletions(-) --- base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe change-id: 20250310-mvneta-xdp-meta-3e0da8ef4498 Best regards,