Message ID | 20250319092951.37667-1-jirislaby@kernel.org (mailing list archive) |
---|---|
Headers | show |
Series | irqdomain: Cleanups and Documentation | expand |
On Wed, Mar 19, 2025 at 11:30 AM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote: > > Hi, > > tl;dr if patches are agreed upon, I ask subsys maintainers to take the > respective ones via their trees (as they are split per subsys), so that > the IRQ tree can take only the rest. That would minimize churn/conflicts > during merges. > > === > > While I was reading through the irqdomain code and headers, I found some > naming and documentation hard to follow or incomplete. Especially the > naming of _add/_create/_instantiate functions. > > I tried to come up with a better state with this patchset: > * only irq _domain_ (not host), > * only irq_domain_create*() functions, all taking fwnode uniformly, > > Finally, all the irqdomain stuff is now plugged (and generated) into > Documentation. So that everyone can walk through it at > https://www.kernel.org/doc/ (once applied, of course). I am all to support the idea, but in some cases I would think of a bit more work to be done to get rid of the of_fwnode_handle(np) in favour of dev_fwnode(dev). Note, this is based on a brief look, I haven't any example at hand right now.
On 19. 03. 25, 11:21, Andy Shevchenko wrote: > I am all to support the idea, but in some cases I would think of a bit > more work to be done to get rid of the of_fwnode_handle(np) in favour > of dev_fwnode(dev). Note, this is based on a brief look, I haven't any > example at hand right now. Aah, that's the helper I was looking for! I was about to use dev->fwnode directly (see the commit log for the Switch to irq_domain_create_*()), but that is not guaranteed to be always properly set. Will use this instead in v3. thanks,
On Wed, 19 Mar 2025 10:28:53 +0100, Jiri Slaby (SUSE) wrote: > tl;dr if patches are agreed upon, I ask subsys maintainers to take the > respective ones via their trees (as they are split per subsys), so that > the IRQ tree can take only the rest. That would minimize churn/conflicts > during merges. > > === > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [35/57] irqdomain: sound: Switch to irq_domain_create_linear() commit: 83eddf0116b09186f909bc643f2093f266f204ea All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Wed, 19 Mar 2025 10:28:53 +0100, Jiri Slaby (SUSE) wrote: > tl;dr if patches are agreed upon, I ask subsys maintainers to take the > respective ones via their trees (as they are split per subsys), so that > the IRQ tree can take only the rest. That would minimize churn/conflicts > during merges. > > === > > [...] Applied, thanks! [48/57] irqdomain: soc: Switch to irq_find_mapping() commit: a70a3a6322131632cc6cf71e9d2fa6409a029fd7 Best regards,