| Message ID | 069ce12d5609c4e968f2a468e6c58a57f59f3ffb.1510520397.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Nov 12, 2017 at 09:59:55PM +0100, H. Nikolaus Schaller wrote: > add bindings documentation for Wi2Wi W2SG00x4 GPS module Add ... module. > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > .../devicetree/bindings/misc/wi2wi,w2sg0004.txt | 24 ++++++++++++++++++++++ The path doesn't have to match the kernel. Use bindings/gps/... > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt > > diff --git a/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt > new file mode 100644 > index 000000000000..ccec9361a1a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt > @@ -0,0 +1,24 @@ > +Wi2Wi GPS module connected through UART > + > +Should be a subnode of the SoC UART it is connected to (serdev). Could be connected to any kind of UART and serdev is a Linuxism. With those fixed, Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, > Am 15.11.2017 um 21:08 schrieb Rob Herring <robh@kernel.org>: > > On Sun, Nov 12, 2017 at 09:59:55PM +0100, H. Nikolaus Schaller wrote: >> add bindings documentation for Wi2Wi W2SG00x4 GPS module > > Add ... module. Ok. > >> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> .../devicetree/bindings/misc/wi2wi,w2sg0004.txt | 24 ++++++++++++++++++++++ > > The path doesn't have to match the kernel. Use bindings/gps/... Ok. > >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> >> diff --git a/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> new file mode 100644 >> index 000000000000..ccec9361a1a4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> @@ -0,0 +1,24 @@ >> +Wi2Wi GPS module connected through UART >> + >> +Should be a subnode of the SoC UART it is connected to (serdev). > > Could be connected to any kind of UART and serdev is a Linuxism. > > With those fixed, > > Acked-by: Rob Herring <robh@kernel.org> Fine and thanks, Nikolaus Schaller PS: there is already a [PATCH v3] (no changes for 1/5 and 2/5) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt new file mode 100644 index 000000000000..ccec9361a1a4 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt @@ -0,0 +1,24 @@ +Wi2Wi GPS module connected through UART + +Should be a subnode of the SoC UART it is connected to (serdev). + +Required properties: +- compatible: should be one of (depending on precise model) + "wi2wi,w2sg0004" + "wi2wi,w2sg0084" +- enable-gpio: the GPIO that controls the module's power toggle + input. A positive impulse of sufficent length toggles the + power state. + +Optional properties: +- lna-supply: an (optional) LNA regulator that is enabled together with the GPS receiver + +Example: + +&uart2 { + w2sg0004: gps { + compatible = "wi2wi,w2sg0004"; + lna-supply = <&vsim>; /* LNA regulator */ + enable-gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>; /* GPIO_145: trigger for turning on/off w2sg0004 */ + }; +};
add bindings documentation for Wi2Wi W2SG00x4 GPS module Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- .../devicetree/bindings/misc/wi2wi,w2sg0004.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt