From patchwork Mon Feb 23 18:55:35 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 8482 X-Patchwork-Delegate: me@felipebalbi.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n1NJ06Ch028475 for ; Mon, 23 Feb 2009 19:00:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755255AbZBWTAN (ORCPT ); Mon, 23 Feb 2009 14:00:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755177AbZBWTAN (ORCPT ); Mon, 23 Feb 2009 14:00:13 -0500 Received: from ns1.siteground211.com ([209.62.36.12]:43154 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755230AbZBWTAM (ORCPT ); Mon, 23 Feb 2009 14:00:12 -0500 Received: from [91.154.126.168] (port=23095 helo=localhost.localdomain) by serv01.siteground211.com with esmtpa (Exim 4.69) (envelope-from ) id 1Lbfyd-0001at-Eb; Mon, 23 Feb 2009 12:56:27 -0600 From: Felipe Balbi To: linux-omap@vger.kernel.org Cc: Steve Sakoman , Anand Gadiyar , Felipe Balbi Subject: [rft/rfc/patch-v2.6.29-rc5+ 23/23] usb: host: ehci: add few comments and todo Date: Mon, 23 Feb 2009 20:55:35 +0200 Message-Id: <1235415335-17408-24-git-send-email-me@felipebalbi.com> X-Mailer: git-send-email 1.6.1.3 In-Reply-To: <1235415335-17408-23-git-send-email-me@felipebalbi.com> References: <1235415335-17408-1-git-send-email-me@felipebalbi.com> <1235415335-17408-2-git-send-email-me@felipebalbi.com> <1235415335-17408-3-git-send-email-me@felipebalbi.com> <1235415335-17408-4-git-send-email-me@felipebalbi.com> <1235415335-17408-5-git-send-email-me@felipebalbi.com> <1235415335-17408-6-git-send-email-me@felipebalbi.com> <1235415335-17408-7-git-send-email-me@felipebalbi.com> <1235415335-17408-8-git-send-email-me@felipebalbi.com> <1235415335-17408-9-git-send-email-me@felipebalbi.com> <1235415335-17408-10-git-send-email-me@felipebalbi.com> <1235415335-17408-11-git-send-email-me@felipebalbi.com> <1235415335-17408-12-git-send-email-me@felipebalbi.com> <1235415335-17408-13-git-send-email-me@felipebalbi.com> <1235415335-17408-14-git-send-email-me@felipebalbi.com> <1235415335-17408-15-git-send-email-me@felipebalbi.com> <1235415335-17408-16-git-send-email-me@felipebalbi.com> <1235415335-17408-17-git-send-email-me@felipebalbi.com> <1235415335-17408-18-git-send-email-me@felipebalbi.com> <1235415335-17408-19-git-send-email-me@felipebalbi.com> <1235415335-17408-20-git-send-email-me@felipebalbi.com> <1235415335-17408-21-git-send-email-me@felipebalbi.com> <1235415335-17408-22-git-send-email-me@felipebalbi.com> <1235415335-17408-23-git-send-email-me@felipebalbi.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - serv01.siteground211.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - felipebalbi.com Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Still a few stuff to be done with this driver, so add TODO for us to keep track of what has to be done still. Signed-off-by: Felipe Balbi --- drivers/usb/host/ehci-omap.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index ebfed95..ad2a353 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -26,6 +26,14 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * + * TODO (last updated Feb 23rd, 2009): + * - add kernel-doc + * - enable AUTOIDLE + * - move DPLL5 programming to clock fw + * - add suspend/resume + * - move workarounds to board-files + * - differentiate between ES2.x and ES3.x + * - make it enumerate devices */ #include @@ -145,6 +153,15 @@ struct ehci_hcd_omap { struct clk *usbtll_fck; struct clk *usbtll_ick; + /* FIXME the following two workarounds are + * board specific not silicon-specific so these + * should be moved to board-file instead. + * + * Maybe someone from TI will know better which + * board is affected and needs the workarounds + * to be applied + */ + /* gpio for resetting phy */ int reset_gpio_port1; int reset_gpio_port2;