From patchwork Wed Mar 18 01:23:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 12725 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2I1PAa4029102 for ; Wed, 18 Mar 2009 01:25:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756270AbZCRBY2 (ORCPT ); Tue, 17 Mar 2009 21:24:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756573AbZCRBY2 (ORCPT ); Tue, 17 Mar 2009 21:24:28 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:63018 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756270AbZCRBY1 (ORCPT ); Tue, 17 Mar 2009 21:24:27 -0400 Received: by mail-fx0-f158.google.com with SMTP id 2so304246fxm.37 for ; Tue, 17 Mar 2009 18:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=lY9WOCJ6WOhgyPeI9M6JG9WvIttv1LfjnTYaJUQ7cEQ=; b=UvCEd9FC98l/nbQuYOTQPKAiHHVK7R19j2pXS6vwIVdHbJtE1ZtH3IfLZDdxym6xw0 yZL/Yc+u6rPSn5lggeWypH5UuZqNWn+bLRFJ/x8mSvkJQlFoWjR899Q8qQSNy1qlxvxm syQ6IlofKvgBXyHT38joJ0d3ZqFvsN3Y4z9oo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=PppGaZIp6n52VTv6M1xx4wDvvGMVNgWMk1sVt2o2C3f70D30h2xZVWwdC52hI3Fdpb gvdC0EluOzYPiK7VC3qJdnQrYdaRKCQY/CNpAqDF9ehcl/A8bXeROR0MlDHLDGTEIlE3 q3K6wgYlkNGwmPh+s0E/L0xgvNxgKOXb3KkGg= Received: by 10.204.62.133 with SMTP id x5mr214120bkh.60.1237339464968; Tue, 17 Mar 2009 18:24:24 -0700 (PDT) Received: from localhost (a91-153-251-222.elisa-laajakaista.fi [91.153.251.222]) by mx.google.com with ESMTPS id e17sm11180057fke.8.2009.03.17.18.24.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 17 Mar 2009 18:24:24 -0700 (PDT) From: Felipe Contreras To: linux-omap@vger.kernel.org Cc: Hari Kanigeri , Hiroshi DOYU , Ameya Palande , Fernando Guzman Lugo , Felipe Contreras Subject: [PATCH A 10/15] tidspbridge: remove udelay and use time_after instead Date: Wed, 18 Mar 2009 03:23:06 +0200 Message-Id: <1237339391-20543-11-git-send-email-felipe.contreras@gmail.com> X-Mailer: git-send-email 1.6.2.1.287.g9a8be In-Reply-To: <1237339391-20543-10-git-send-email-felipe.contreras@gmail.com> References: <1237339391-20543-1-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-2-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-3-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-4-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-5-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-6-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-7-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-8-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-9-git-send-email-felipe.contreras@gmail.com> <1237339391-20543-10-git-send-email-felipe.contreras@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Felipe Contreras As suggested by Juha Yrjola. Signed-off-by: Felipe Contreras --- drivers/dsp/bridge/wmd/tiomap_sm.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dsp/bridge/wmd/tiomap_sm.c b/drivers/dsp/bridge/wmd/tiomap_sm.c index 658064f..735f8e9 100644 --- a/drivers/dsp/bridge/wmd/tiomap_sm.c +++ b/drivers/dsp/bridge/wmd/tiomap_sm.c @@ -105,7 +105,7 @@ DSP_STATUS CHNLSM_InterruptDSP(struct WMD_DEV_CONTEXT *pDevContext) u32 opplevel = 0; #endif struct CFG_HOSTRES resources; - u16 cnt = 10; + unsigned long timeout; u32 temp; /* We are waiting indefinitely here. This needs to be fixed in the * second phase */ @@ -143,12 +143,12 @@ DSP_STATUS CHNLSM_InterruptDSP(struct WMD_DEV_CONTEXT *pDevContext) pDevContext->dwBrdState = BRD_RUNNING; } + timeout = jiffies + msecs_to_jiffies(10); while (fifo_full((void __iomem *) resources.dwMboxBase, 0)) { - if (--cnt == 0) { + if (time_after(jiffies, timeout)) { DBG_Trace(DBG_LEVEL7, "Timed out waiting for DSP mailbox \n"); return WMD_E_TIMEOUT; } - mdelay(1); } DBG_Trace(DBG_LEVEL3, "writing %x to Mailbox\n", pDevContext->wIntrVal2Dsp);