From patchwork Wed Jun 17 13:35:21 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Bityutskiy X-Patchwork-Id: 30870 X-Patchwork-Delegate: paul@pwsan.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5HDaKhR003322 for ; Wed, 17 Jun 2009 13:36:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933541AbZFQNfg (ORCPT ); Wed, 17 Jun 2009 09:35:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933538AbZFQNfg (ORCPT ); Wed, 17 Jun 2009 09:35:36 -0400 Received: from smtp.nokia.com ([192.100.122.230]:60556 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933524AbZFQNff (ORCPT ); Wed, 17 Jun 2009 09:35:35 -0400 Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n5HDZRGb005534; Wed, 17 Jun 2009 16:35:28 +0300 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 17 Jun 2009 16:35:23 +0300 Received: from mgw-sa01.ext.nokia.com ([147.243.1.47]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 17 Jun 2009 16:35:22 +0300 Received: from localhost.localdomain (esdhcp042232.research.nokia.com [172.21.42.232]) by mgw-sa01.ext.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n5HDZKjo031625; Wed, 17 Jun 2009 16:35:20 +0300 From: Artem Bityutskiy To: Paul Walmsley Cc: linux-omap@vger.kernel.org, Tony Lindgren , Samu Onkalo Subject: [PATCH] SDRC: Remove SDRC_POWER register configuration from SDRC init. Date: Wed, 17 Jun 2009 16:35:21 +0300 Message-Id: <1245245721-7052-1-git-send-email-Artem.Bityutskiy@nokia.com> X-Mailer: git-send-email 1.6.0.6 X-OriginalArrivalTime: 17 Jun 2009 13:35:22.0795 (UTC) FILETIME=[76E597B0:01C9EF50] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Samu Onkalo Bootloader must configure proper settings for SDRC before starting kernel from SDRAM. Furthermore, removed lines violated omap3430 and omap2420 SDRC errata (see errata 1.150) Signed-off-by: Samu Onkalo --- arch/arm/mach-omap2/sdrc.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-omap2/sdrc.c b/arch/arm/mach-omap2/sdrc.c index 2045441..0874687 100644 --- a/arch/arm/mach-omap2/sdrc.c +++ b/arch/arm/mach-omap2/sdrc.c @@ -86,8 +86,8 @@ void __init omap2_set_globals_sdrc(struct omap_globals *omap2_globals) * @sp: pointer to a null-terminated list of struct omap_sdrc_params * * Turn on smart idle modes for SDRAM scheduler and controller. - * Program a known-good configuration for the SDRC to deal with buggy - * bootloaders. + * Bootloaders should make proper configuration for SDRC since kernel + * is running from SDRAM. */ void __init omap2_sdrc_init(struct omap_sdrc_params *sp) { @@ -104,10 +104,4 @@ void __init omap2_sdrc_init(struct omap_sdrc_params *sp) sdrc_write_reg(l, SDRC_SYSCONFIG); sdrc_init_params = sp; - - /* XXX Enable SRFRONIDLEREQ here also? */ - l = (1 << SDRC_POWER_EXTCLKDIS_SHIFT) | - (1 << SDRC_POWER_PWDENA_SHIFT) | - (1 << SDRC_POWER_PAGEPOLICY_SHIFT); - sdrc_write_reg(l, SDRC_POWER); }