From patchwork Wed Aug 12 18:12:35 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Chan X-Patchwork-Id: 40932 X-Patchwork-Delegate: khilman@deeprootsystems.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7CI8eeI020378 for ; Wed, 12 Aug 2009 18:12:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbZHLSMm (ORCPT ); Wed, 12 Aug 2009 14:12:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752016AbZHLSMm (ORCPT ); Wed, 12 Aug 2009 14:12:42 -0400 Received: from smtp-out.google.com ([216.239.45.13]:9183 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbZHLSMm (ORCPT ); Wed, 12 Aug 2009 14:12:42 -0400 Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) by smtp-out.google.com with ESMTP id n7CICcMX022857; Wed, 12 Aug 2009 11:12:40 -0700 Received: from localhost (cheetara.mtv.corp.google.com [172.18.103.81]) by wpaz9.hot.corp.google.com with ESMTP id n7CICZj8003611; Wed, 12 Aug 2009 11:12:35 -0700 Received: by localhost (Postfix, from userid 18922) id 7B4E6504D2D; Wed, 12 Aug 2009 11:12:35 -0700 (PDT) From: Mike Chan To: linux-omap@vger.kernel.org Cc: khilman@deeprootsystems.com, paul@pwsan.com, Mike Chan Subject: [PATCH] omap: pm: Fix error condition in _pwrdm_deps_lookup when pwrdm not found. Date: Wed, 12 Aug 2009 11:12:35 -0700 Message-Id: <1250100755-29723-1-git-send-email-mike@android.com> X-Mailer: git-send-email 1.5.4.5 X-System-Of-Record: true Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Check pwrdm_name instead of the address of a null struct when at the end of pwrdm_dep array. Reported-by: Paul Walmsley Signed-off-by: Mike Chan Acked-by: Paul Walmsley --- arch/arm/mach-omap2/powerdomain.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c index 0334609..02c1ef6 100644 --- a/arch/arm/mach-omap2/powerdomain.c +++ b/arch/arm/mach-omap2/powerdomain.c @@ -103,7 +103,7 @@ static struct powerdomain *_pwrdm_deps_lookup(struct powerdomain *pwrdm, } - if (!pd) + if (!pd->pwrdm_name) return ERR_PTR(-ENOENT); return pd->pwrdm;