diff mbox

[7/8] DSPBRIDGE: Check return value

Message ID 1251375541-1866-8-git-send-email-andy.shevchenko@gmail.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Andy Shevchenko Aug. 27, 2009, 12:19 p.m. UTC 
From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>

PROC_GetProcessorId() potentially could return different to DSP_SOK status. We
need to check it.

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
---
 drivers/dsp/bridge/rmgr/drv.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

Comments

Guzman Lugo, Fernando Aug. 31, 2009, 8:21 p.m. UTC | #1 
Acked-by: Fernando Guzman Lugo <x0095840@ti.com>


>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>owner@vger.kernel.org] On Behalf Of Andy Shevchenko
>Sent: Thursday, August 27, 2009 7:19 AM
>To: linux-omap@vger.kernel.org
>Cc: Andy Shevchenko
>Subject: [PATCH 7/8] DSPBRIDGE: Check return value
>
>From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
>
>PROC_GetProcessorId() potentially could return different to DSP_SOK status.
>We
>need to check it.
>
>Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
>---
> drivers/dsp/bridge/rmgr/drv.c |    8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c
>index 44d7f2d..d21071c 100644
>--- a/drivers/dsp/bridge/rmgr/drv.c
>+++ b/drivers/dsp/bridge/rmgr/drv.c
>@@ -990,8 +990,12 @@ static DSP_STATUS PrintProcessInformation(void)
> 		spin_lock(&pCtxtList->proc_list_lock);
> 		list_for_each_entry(proc_obj_ptr, &pCtxtList->processor_list,
> 				proc_object) {
>-			PROC_GetProcessorId(proc_obj_ptr, &procID);
>-			if (procID == DSP_UNIT) {
>+			DSP_STATUS status2 = PROC_GetProcessorId(proc_obj_ptr,
>+								 &procID);
>+			if (DSP_FAILED(status2)) {
>+				GT_0trace(curTrace, GT_7CLASS, "\n***ERROR:"
>+					  "Unable to get Processor Id***\n");
>+			} else if (procID == DSP_UNIT) {
> 				GT_0trace(curTrace, GT_4CLASS,
> 					"\nProcess connected to"
> 					" DSP Processor\n");
>--
>1.5.6.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dsp/bridge/rmgr/drv.c b/drivers/dsp/bridge/rmgr/drv.c
index 44d7f2d..d21071c 100644
--- a/drivers/dsp/bridge/rmgr/drv.c
+++ b/drivers/dsp/bridge/rmgr/drv.c
@@ -990,8 +990,12 @@  static DSP_STATUS PrintProcessInformation(void)
 		spin_lock(&pCtxtList->proc_list_lock);
 		list_for_each_entry(proc_obj_ptr, &pCtxtList->processor_list,
 				proc_object) {
-			PROC_GetProcessorId(proc_obj_ptr, &procID);
-			if (procID == DSP_UNIT) {
+			DSP_STATUS status2 = PROC_GetProcessorId(proc_obj_ptr,
+								 &procID);
+			if (DSP_FAILED(status2)) {
+				GT_0trace(curTrace, GT_7CLASS, "\n***ERROR:"
+					  "Unable to get Processor Id***\n");
+			} else if (procID == DSP_UNIT) {
 				GT_0trace(curTrace, GT_4CLASS,
 					"\nProcess connected to"
 					" DSP Processor\n");