From patchwork Wed Sep 23 16:03:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 49567 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8NG4Eph024374 for ; Wed, 23 Sep 2009 16:04:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753395AbZIWQEJ (ORCPT ); Wed, 23 Sep 2009 12:04:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753388AbZIWQEJ (ORCPT ); Wed, 23 Sep 2009 12:04:09 -0400 Received: from smtp.nokia.com ([192.100.105.134]:40771 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753385AbZIWQEH (ORCPT ); Wed, 23 Sep 2009 12:04:07 -0400 Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx09.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n8NG2YD0002719; Wed, 23 Sep 2009 11:03:17 -0500 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 23 Sep 2009 19:03:21 +0300 Received: from mgw-da01.ext.nokia.com ([147.243.128.24]) by esebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 23 Sep 2009 19:03:20 +0300 Received: from dilbert.research.nokia.com (esdhcp034223.research.nokia.com [172.21.34.223]) by mgw-da01.ext.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n8NG3CV9025003 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 23 Sep 2009 19:03:13 +0300 Received: from andy by dilbert.research.nokia.com with local (Exim 4.69) (envelope-from ) id 1MqUJQ-0005wm-Im; Wed, 23 Sep 2009 19:03:24 +0300 From: Andy Shevchenko To: linux-omap@vger.kernel.org Cc: x0095840@ti.com, omar.ramirez@ti.com, hiroshi.doyu@Nokia.com, Andy Shevchenko Subject: [PATCHv2 5/5] DSPBRIDGE: OSAL: Remove printS() Date: Wed, 23 Sep 2009 19:03:23 +0300 Message-Id: <1253721804-22816-6-git-send-email-andy.shevchenko@gmail.com> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1253721804-22816-5-git-send-email-andy.shevchenko@gmail.com> References: <1253721804-22816-1-git-send-email-andy.shevchenko@gmail.com> <1253721804-22816-2-git-send-email-andy.shevchenko@gmail.com> <1253721804-22816-3-git-send-email-andy.shevchenko@gmail.com> <1253721804-22816-4-git-send-email-andy.shevchenko@gmail.com> <1253721804-22816-5-git-send-email-andy.shevchenko@gmail.com> X-OriginalArrivalTime: 23 Sep 2009 16:03:21.0071 (UTC) FILETIME=[5F3E7FF0:01CA3C67] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Andy Shevchenko Remove printS() debuggin method. It's mostly useless and at least dangerous because of absence of boundary check. Signed-off-by: Andy Shevchenko --- drivers/dsp/bridge/services/regsup.c | 23 ----------------------- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/drivers/dsp/bridge/services/regsup.c b/drivers/dsp/bridge/services/regsup.c index 71651a8..bd45b56 100644 --- a/drivers/dsp/bridge/services/regsup.c +++ b/drivers/dsp/bridge/services/regsup.c @@ -60,26 +60,6 @@ static struct LST_LIST regKey, *pRegKey = ®Key; #if GT_TRACE extern struct GT_Mask REG_debugMask; /* GT trace var. */ -/* - * ======== printS ======== - * Purpose: - * Displays printable characters in pBuf, if any. - */ -static inline void printS(void *pBuf) -{ - int pos = 0; - if (*(REG_debugMask).flags & (GT_2CLASS)) { - while (*(u8 *)((pBuf)+pos) >= ' ' && - *(u8 *)((pBuf)+pos) <= '~') { - GT_1trace(REG_debugMask, GT_2CLASS, "%c", - *(u8 *)((pBuf) + pos++)); - } - - GT_0trace(REG_debugMask, GT_2CLASS, "\n"); - } -} -#else -#define printS(pBuf) #endif /* @@ -140,7 +120,6 @@ DSP_STATUS regsupGetValue(char *valName, void *pBuf, u32 *dataSize) if (DSP_SUCCEEDED(retVal)) { GT_2trace(REG_debugMask, GT_2CLASS, "G %s DATA %x ", valName, *(u32 *)pBuf); - printS((u8 *)pBuf); } else { GT_1trace(REG_debugMask, GT_3CLASS, "G %s FAILED\n", valName); } @@ -160,7 +139,6 @@ DSP_STATUS regsupSetValue(char *valName, void *pBuf, u32 dataSize) GT_2trace(REG_debugMask, GT_2CLASS, "S %s DATA %x ", valName, *(u32 *)pBuf); - printS((u8 *)pBuf); /* Need to search through the entries looking for the right one. */ while (rv) { @@ -245,7 +223,6 @@ DSP_STATUS regsupEnumValue(IN u32 dwIndex, IN CONST char *pstrKey, GT_3trace(REG_debugMask, GT_2CLASS, "E Key %s, Value %s, Data %x ", pstrKey, pstrValue, *(u32 *)pstrData); - printS((u8 *)pstrData); /* Set our status to good and exit. */ retVal = DSP_SOK;