From patchwork Thu Feb 18 21:37:56 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: omar ramirez X-Patchwork-Id: 80444 X-Patchwork-Delegate: omar.ramirez@ti.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o1ILPZtf004704 for ; Thu, 18 Feb 2010 21:25:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758251Ab0BRVZe (ORCPT ); Thu, 18 Feb 2010 16:25:34 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:46724 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757891Ab0BRVZb (ORCPT ); Thu, 18 Feb 2010 16:25:31 -0500 Received: from dlep33.itg.ti.com ([157.170.170.112]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id o1ILPNcG027340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Feb 2010 15:25:24 -0600 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep33.itg.ti.com (8.13.7/8.13.7) with ESMTP id o1ILPNXP011404; Thu, 18 Feb 2010 15:25:23 -0600 (CST) Received: from Matrix (matrix.am.dhcp.ti.com [128.247.75.166]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id o1ILPMZ19998; Thu, 18 Feb 2010 15:25:22 -0600 (CST) Received: by Matrix (Postfix, from userid 1003) id 4E21E41060D; Thu, 18 Feb 2010 15:38:04 -0600 (CST) From: Omar Ramirez Luna To: linux-omap Cc: Ameya Palande , Hiroshi Doyu , Felipe Contreras , Nishanth Menon , Omar Ramirez Luna Subject: [PATCH 05/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in services Date: Thu, 18 Feb 2010 15:37:56 -0600 Message-Id: <1266529083-2358-6-git-send-email-omar.ramirez@ti.com> X-Mailer: git-send-email 1.5.4.3 In-Reply-To: <1266529083-2358-5-git-send-email-omar.ramirez@ti.com> References: <1266529083-2358-1-git-send-email-omar.ramirez@ti.com> <1266529083-2358-2-git-send-email-omar.ramirez@ti.com> <1266529083-2358-3-git-send-email-omar.ramirez@ti.com> <1266529083-2358-4-git-send-email-omar.ramirez@ti.com> <1266529083-2358-5-git-send-email-omar.ramirez@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 18 Feb 2010 21:25:37 +0000 (UTC) diff --git a/drivers/dsp/bridge/services/cfg.c b/drivers/dsp/bridge/services/cfg.c index d26f8b9..295ff11 100644 --- a/drivers/dsp/bridge/services/cfg.c +++ b/drivers/dsp/bridge/services/cfg.c @@ -205,8 +205,7 @@ DSP_STATUS CFG_GetHostResources(struct CFG_DEVNODE *hDevNode, } #ifdef CONFIG_BRIDGE_DEBUG if (DSP_FAILED(status)) - GT_0trace(CFG_debugMask, GT_6CLASS, - "CFG_GetHostResources Failed \n"); + dev_dbg(bridge, "%s Failed, status 0x%x\n", __func__, status); #endif return status; } diff --git a/drivers/dsp/bridge/services/clk.c b/drivers/dsp/bridge/services/clk.c index f8c417a..04d49bd 100644 --- a/drivers/dsp/bridge/services/clk.c +++ b/drivers/dsp/bridge/services/clk.c @@ -275,9 +275,8 @@ DSP_STATUS CLK_GetRate(IN enum SERVICES_ClkId clk_id, u32 *speedKhz) if (pClk) { clkSpeedHz = clk_get_rate(pClk); *speedKhz = clkSpeedHz / 1000; - GT_2trace(CLK_debugMask, GT_6CLASS, - "CLK_GetRate: clkSpeedHz = %d , " - "speedinKhz=%d\n", clkSpeedHz, *speedKhz); + dev_dbg(bridge, "%s: clkSpeedHz = %d, speedinKhz = %d\n", + __func__, clkSpeedHz, *speedKhz); } else { pr_err("%s: failed to get %s, dev Id = %d\n", __func__, SERVICES_Clks[clk_id].clk_name, diff --git a/drivers/dsp/bridge/services/regsup.c b/drivers/dsp/bridge/services/regsup.c index 0c77fb2..04f6b3a 100644 --- a/drivers/dsp/bridge/services/regsup.c +++ b/drivers/dsp/bridge/services/regsup.c @@ -105,12 +105,7 @@ DSP_STATUS regsupGetValue(char *valName, void *pBuf, u32 *dataSize) (struct list_head *) rv); } - if (DSP_SUCCEEDED(retVal)) { - GT_2trace(REG_debugMask, GT_2CLASS, "G %s DATA %x ", valName, - *(u32 *)pBuf); - } else { - GT_1trace(REG_debugMask, GT_3CLASS, "G %s FAILED\n", valName); - } + dev_dbg(bridge, "REG: get %s, status = 0x%x\n", valName, retVal); return retVal; } @@ -125,9 +120,6 @@ DSP_STATUS regsupSetValue(char *valName, void *pBuf, u32 dataSize) DSP_STATUS retVal = DSP_EFAIL; struct RegValue *rv = (struct RegValue *) LST_First(pRegKey); - GT_2trace(REG_debugMask, GT_2CLASS, "S %s DATA %x ", valName, - *(u32 *)pBuf); - /* Need to search through the entries looking for the right one. */ while (rv) { /* See if the name matches. */ @@ -171,6 +163,8 @@ DSP_STATUS regsupSetValue(char *valName, void *pBuf, u32 dataSize) } } + dev_dbg(bridge, "REG: set %s, status = 0x%x", valName, retVal); + return retVal; } @@ -203,9 +197,6 @@ DSP_STATUS regsupEnumValue(IN u32 dwIndex, IN CONST char *pstrKey, *pdwValueSize = strlen(&(rv->name[dwKeyLen])); strncpy(pstrValue, &(rv->name[dwKeyLen]), *pdwValueSize + 1); - GT_3trace(REG_debugMask, GT_2CLASS, - "E Key %s, Value %s, Data %x ", - pstrKey, pstrValue, *(u32 *)pstrData); /* Set our status to good and exit. */ retVal = DSP_SOK; break; @@ -217,6 +208,9 @@ DSP_STATUS regsupEnumValue(IN u32 dwIndex, IN CONST char *pstrKey, if (count && DSP_FAILED(retVal)) retVal = REG_E_NOMOREITEMS; + dev_dbg(bridge, "REG: enum Key %s, Value %s, status = 0x%x", + pstrKey, pstrValue, retVal); + return retVal; } @@ -248,6 +242,9 @@ DSP_STATUS regsupDeleteValue(IN CONST char *pstrValue) rv = (struct RegValue *)LST_Next(pRegKey, (struct list_head *)rv); } + + dev_dbg(bridge, "REG: del %s, status = 0x%x", pstrValue, retVal); + return retVal; }