From patchwork Tue Mar 9 16:16:45 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aguirre Rodriguez, Sergio Alberto" X-Patchwork-Id: 84335 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o29GG63P031443 for ; Tue, 9 Mar 2010 16:16:06 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198Ab0CIQQC (ORCPT ); Tue, 9 Mar 2010 11:16:02 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:59102 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754522Ab0CIQP7 (ORCPT ); Tue, 9 Mar 2010 11:15:59 -0500 Received: from dlep35.itg.ti.com ([157.170.170.118]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id o29GFpjX007412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Mar 2010 10:15:51 -0600 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep35.itg.ti.com (8.13.7/8.13.7) with ESMTP id o29GFm1I010838; Tue, 9 Mar 2010 10:15:48 -0600 (CST) Received: from localhost (dtx0091359-ubuntu-1.am.dhcp.ti.com [128.247.79.73]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id o29GFmZ01498; Tue, 9 Mar 2010 10:15:48 -0600 (CST) From: Sergio Aguirre To: linux-omap@vger.kernel.org Cc: Kevin Hilman , Vikram Pandita , Paul Walmsley , Tony Lindgren , Felipe Balbi , Sergio Aguirre Subject: [RFC part1/2 merge v3][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr Date: Tue, 9 Mar 2010 10:16:45 -0600 Message-Id: <1268151414-17071-2-git-send-email-saaguirre@ti.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1268151414-17071-1-git-send-email-saaguirre@ti.com> References: <1268151414-17071-1-git-send-email-saaguirre@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 09 Mar 2010 16:16:06 +0000 (UTC) diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index da77930..6010d3d 100644 --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c @@ -664,6 +664,12 @@ void __init omap_serial_early_init(void) struct device *dev = &pdev->dev; struct plat_serial8250_port *p = dev->platform_data; + /* Don't map zero-based physical address */ + if (p->mapbase == 0) { + printk(KERN_WARNING "omap serial: No physical address" + " for uart#%d, so skipping early_init...\n", i); + continue; + } /* * Module 4KB + L4 interconnect 4KB * Static mapping, never released @@ -727,6 +733,14 @@ void __init omap_serial_init_port(int port) pdev = &uart->pdev; dev = &pdev->dev; + /* Don't proceed if there's no clocks available */ + if (unlikely(!uart->ick || !uart->fck)) { + printk(KERN_ERR "Can't init uart%d, no clocks available\n", + port); + WARN_ON(1); + return; + } + omap_uart_enable_clocks(uart); omap_uart_reset(uart);