From patchwork Wed Apr 7 16:04:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 91079 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o37G5j1r005751 for ; Wed, 7 Apr 2010 16:05:46 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932896Ab0DGQFn (ORCPT ); Wed, 7 Apr 2010 12:05:43 -0400 Received: from smtp.nokia.com ([192.100.122.230]:58491 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932857Ab0DGQFV (ORCPT ); Wed, 7 Apr 2010 12:05:21 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o37G58eo004996 for ; Wed, 7 Apr 2010 19:05:18 +0300 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Apr 2010 19:05:02 +0300 Received: from mgw-da02.ext.nokia.com ([147.243.128.26]) by esebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Apr 2010 19:05:01 +0300 Received: from localhost.localdomain (esdhcp04088.research.nokia.com [172.21.40.88]) by mgw-da02.ext.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o37G4YN1015130; Wed, 7 Apr 2010 19:04:57 +0300 From: felipe.balbi@nokia.com To: Linux OMAP Mailing List Cc: Felipe Balbi Subject: [RFC PATCH 17/37] cbus: retu: don't assing ret inside the if () Date: Wed, 7 Apr 2010 19:04:08 +0300 Message-Id: <1270656268-7034-18-git-send-email-felipe.balbi@nokia.com> X-Mailer: git-send-email 1.7.0.rc0.33.g7c3932 In-Reply-To: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com> References: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com> X-OriginalArrivalTime: 07 Apr 2010 16:05:01.0843 (UTC) FILETIME=[14461630:01CAD66C] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 07 Apr 2010 16:05:46 +0000 (UTC) diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c index ae2e691..8382694 100644 --- a/drivers/cbus/retu.c +++ b/drivers/cbus/retu.c @@ -354,7 +354,8 @@ static int __devinit retu_probe(struct device *dev) return -ENODEV; } - if ((ret = gpio_request(retu_irq_pin, "RETU irq")) < 0) { + ret = gpio_request(retu_irq_pin, "RETU irq"); + if (ret < 0) { printk(KERN_ERR PFX "Unable to reserve IRQ GPIO\n"); return ret; } @@ -453,13 +454,16 @@ static int __init retu_init(void) init_completion(&device_release); - if ((ret = driver_register(&retu_driver)) < 0) + ret = driver_register(&retu_driver); + if (ret < 0) return ret; - if ((ret = platform_device_register(&retu_device)) < 0) { + ret = platform_device_register(&retu_device); + if (ret < 0) { driver_unregister(&retu_driver); return ret; } + return 0; }