From patchwork Wed Apr 7 16:04:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 91071 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o37G5ZaC005656 for ; Wed, 7 Apr 2010 16:05:35 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932888Ab0DGQFe (ORCPT ); Wed, 7 Apr 2010 12:05:34 -0400 Received: from smtp.nokia.com ([192.100.122.230]:58495 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932862Ab0DGQFW (ORCPT ); Wed, 7 Apr 2010 12:05:22 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o37G58eq004996 for ; Wed, 7 Apr 2010 19:05:19 +0300 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Apr 2010 19:05:09 +0300 Received: from mgw-da02.ext.nokia.com ([147.243.128.26]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Apr 2010 19:05:09 +0300 Received: from localhost.localdomain (esdhcp04088.research.nokia.com [172.21.40.88]) by mgw-da02.ext.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o37G4YN7015130; Wed, 7 Apr 2010 19:05:05 +0300 From: felipe.balbi@nokia.com To: Linux OMAP Mailing List Cc: Felipe Balbi Subject: [RFC PATCH 23/37] cbus: tahvo: convert printk into dev_* Date: Wed, 7 Apr 2010 19:04:14 +0300 Message-Id: <1270656268-7034-24-git-send-email-felipe.balbi@nokia.com> X-Mailer: git-send-email 1.7.0.rc0.33.g7c3932 In-Reply-To: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com> References: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com> X-OriginalArrivalTime: 07 Apr 2010 16:05:09.0436 (UTC) FILETIME=[18CCAFC0:01CAD66C] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 07 Apr 2010 16:05:35 +0000 (UTC) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index fc25a89..9bc3f56 100644 --- a/drivers/cbus/tahvo.c +++ b/drivers/cbus/tahvo.c @@ -322,11 +322,11 @@ static int __devinit tahvo_probe(struct device *dev) tahvo_is_betty = 1; tahvo_7bit_backlight = 1; } else { - printk(KERN_ERR "Tahvo/Betty chip not found"); + dev_err(dev, "Tahvo/Betty chip not found"); return -ENODEV; } - printk(KERN_INFO "%s v%d.%d found\n", tahvo_is_betty ? "Betty" : "Tahvo", + dev_err(dev, "%s v%d.%d found\n", tahvo_is_betty ? "Betty" : "Tahvo", (rev >> 4) & 0x0f, rev & 0x0f); /* REVISIT: Pass these from board-*.c files in platform_data */ @@ -336,13 +336,13 @@ static int __devinit tahvo_probe(struct device *dev) machine_is_nokia_n810_wimax()) { tahvo_irq_pin = 111; } else { - printk(KERN_ERR "cbus: Unsupported board for tahvo\n"); + dev_err(dev, "cbus: Unsupported board for tahvo\n"); return -ENODEV; } ret = gpio_request(tahvo_irq_pin, "TAHVO irq"); if (ret) { - printk(KERN_ERR PFX "Unable to reserve IRQ GPIO\n"); + dev_err(dev, "Unable to reserve IRQ GPIO\n"); return ret; } @@ -358,14 +358,14 @@ static int __devinit tahvo_probe(struct device *dev) ret = request_irq(gpio_to_irq(tahvo_irq_pin), tahvo_irq_handler, 0, "tahvo", 0); if (ret < 0) { - printk(KERN_ERR PFX "Unable to register IRQ handler\n"); + dev_err(dev, "Unable to register IRQ handler\n"); gpio_free(tahvo_irq_pin); return ret; } #ifdef CONFIG_CBUS_TAHVO_USER /* Initialize user-space interface */ if (tahvo_user_init() < 0) { - printk(KERN_ERR "Unable to initialize driver\n"); + dev_err(dev, "Unable to initialize driver\n"); free_irq(gpio_to_irq(tahvo_irq_pin), 0); gpio_free(tahvo_irq_pin); return ret; @@ -421,8 +421,6 @@ static int __init tahvo_init(void) machine_is_nokia_n810() || machine_is_nokia_n810_wimax())) return -ENODEV; - printk(KERN_INFO "Tahvo/Betty driver initialising\n"); - init_completion(&device_release); ret = driver_register(&tahvo_driver);