From patchwork Thu Apr 22 08:07:34 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 94045 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o3M896Bk020713 for ; Thu, 22 Apr 2010 08:09:06 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609Ab0DVIJF (ORCPT ); Thu, 22 Apr 2010 04:09:05 -0400 Received: from smtp.nokia.com ([192.100.105.134]:23725 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430Ab0DVIJC (ORCPT ); Thu, 22 Apr 2010 04:09:02 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx09.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o3M88thQ007747; Thu, 22 Apr 2010 03:08:58 -0500 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Apr 2010 11:08:50 +0300 Received: from mgw-sa01.ext.nokia.com ([147.243.1.47]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Apr 2010 11:08:50 +0300 Received: from manganga.research.nokia.com (esdhcp04199.research.nokia.com [172.21.41.99]) by mgw-sa01.ext.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o3M88loT017780; Thu, 22 Apr 2010 11:08:50 +0300 From: Eduardo Valentin To: Core-Review Cc: "\\\"Hogander Jouni (Nokia-D/Tampere)\\\"" , "\\\"Koskinen Aaro (Nokia-D/Helsinki)\\\"" , Amit Kucheria , linux-omap@vger.kernel.org, Samuel Ortiz Subject: [PATCHv3 02/11] mfd: Add comments for the twl4030-power register and bit layout Date: Thu, 22 Apr 2010 11:07:34 +0300 Message-Id: <1271923663-23668-3-git-send-email-eduardo.valentin@nokia.com> X-Mailer: git-send-email 1.7.0.4.361.g8b5fe.dirty In-Reply-To: <1271923663-23668-1-git-send-email-eduardo.valentin@nokia.com> References: <1271923663-23668-1-git-send-email-eduardo.valentin@nokia.com> X-OriginalArrivalTime: 22 Apr 2010 08:08:50.0636 (UTC) FILETIME=[0AB420C0:01CAE1F3] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 22 Apr 2010 08:09:07 +0000 (UTC) diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 8f82e22..2bec947 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -72,14 +72,22 @@ static u8 twl4030_start_script_address = 0x2b; #define R_KEY_1 0xC0 #define R_KEY_2 0x0C -/* resource configuration registers */ - +/* resource configuration registers + _DEV_GRP at address 'n+0' + _TYPE at address 'n+1' + _REMAP at address 'n+2' + _DEDICATED at address 'n+3' +*/ #define DEV_GRP_OFFSET 0 #define TYPE_OFFSET 1 /* Bit positions in the registers */ + +/* _DEV_GRP */ #define DEV_GRP_SHIFT 5 #define DEV_GRP_MASK (7 << DEV_GRP_SHIFT) + +/* _TYPE */ #define TYPE_SHIFT 0 #define TYPE_MASK (7 << TYPE_SHIFT) #define TYPE2_SHIFT 3