diff mbox

[2.6.38] omap: McBSP: Fix potential memory leak in omap_mcbsp_remove

Message ID 1288776263-6600-1-git-send-email-jhnikula@gmail.com (mailing list archive)
State Accepted
Commit a7bf995770073159b211609b83aeb5b7ff9856c7
Delegated to: Tony Lindgren
Headers show

Commit Message

Jarkko Nikula Nov. 3, 2010, 9:24 a.m. UTC
None
diff mbox

Patch

diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index eac4b97..f79090c 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -1836,17 +1836,11 @@  static int __devexit omap_mcbsp_remove(struct platform_device *pdev)
 
 		omap34xx_device_exit(mcbsp);
 
-		clk_disable(mcbsp->fclk);
-		clk_disable(mcbsp->iclk);
 		clk_put(mcbsp->fclk);
 		clk_put(mcbsp->iclk);
 
 		iounmap(mcbsp->io_base);
-
-		mcbsp->fclk = NULL;
-		mcbsp->iclk = NULL;
-		mcbsp->free = 0;
-		mcbsp->dev = NULL;
+		kfree(mcbsp);
 	}
 
 	return 0;