From patchwork Wed Nov 3 09:24:23 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 298622 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oA39OS6W017396 for ; Wed, 3 Nov 2010 09:24:28 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685Ab0KCJY1 (ORCPT ); Wed, 3 Nov 2010 05:24:27 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:33861 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523Ab0KCJY1 (ORCPT ); Wed, 3 Nov 2010 05:24:27 -0400 Received: by eye27 with SMTP id 27so127138eye.19 for ; Wed, 03 Nov 2010 02:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=xcCllIrQvJllBTStntRYexL+kNE1+mGYys9rQ4BDjhw=; b=h6ZrVXsn45m+jBnoZzFOG4B/+tctvPFtyCf3YuN7n5MDAZCNBd5typty9Dl/GsehHV IpttZd+/vlawStttUFEsV8aQ9yHPP+wJ66filtgkHbxGerQ1GGZbu71ZeGDmDO6PRlWQ 7Q1GB2L/e1B8+5gzv7PMak8uX+JT19hjf3dlY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=RVo1T2dWbbL9HSBl58Rdmpm6pP0YfXX/fDkY3nhcTIM0YRORcwBEw0EBgN18ScWfCf sRDwtpwqSp9lG2DGVlTKoQy2QttvkGxnUTj4DKbqv608Qd3GhBphF9kpezhYCl1binzD UbTWkhfoHVgjIOfh86MBYkJbeifZeWtlsZIzw= Received: by 10.213.113.147 with SMTP id a19mr4414285ebq.24.1288776265948; Wed, 03 Nov 2010 02:24:25 -0700 (PDT) Received: from localhost (host-94-101-4-66.igua.fi [94.101.4.66]) by mx.google.com with ESMTPS id x54sm6355209eeh.11.2010.11.03.02.24.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 03 Nov 2010 02:24:24 -0700 (PDT) From: Jarkko Nikula To: linux-omap@vger.kernel.org Cc: Tony Lindgren , Jarkko Nikula Subject: [PATCH 2.6.38] omap: McBSP: Fix potential memory leak in omap_mcbsp_remove Date: Wed, 3 Nov 2010 11:24:23 +0200 Message-Id: <1288776263-6600-1-git-send-email-jhnikula@gmail.com> X-Mailer: git-send-email 1.7.2.3 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 03 Nov 2010 09:24:28 +0000 (UTC) diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index eac4b97..f79090c 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -1836,17 +1836,11 @@ static int __devexit omap_mcbsp_remove(struct platform_device *pdev) omap34xx_device_exit(mcbsp); - clk_disable(mcbsp->fclk); - clk_disable(mcbsp->iclk); clk_put(mcbsp->fclk); clk_put(mcbsp->iclk); iounmap(mcbsp->io_base); - - mcbsp->fclk = NULL; - mcbsp->iclk = NULL; - mcbsp->free = 0; - mcbsp->dev = NULL; + kfree(mcbsp); } return 0;