From patchwork Wed Nov 17 17:52:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Pihet X-Patchwork-Id: 333681 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oAHHr4wr028735 for ; Wed, 17 Nov 2010 17:53:04 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935177Ab0KQRw5 (ORCPT ); Wed, 17 Nov 2010 12:52:57 -0500 Received: from mail-gy0-f174.google.com ([209.85.160.174]:38114 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935165Ab0KQRw5 (ORCPT ); Wed, 17 Nov 2010 12:52:57 -0500 Received: by gyh4 with SMTP id 4so1270284gyh.19 for ; Wed, 17 Nov 2010 09:52:56 -0800 (PST) Received: by 10.216.13.207 with SMTP id b57mr8404972web.32.1290016375726; Wed, 17 Nov 2010 09:52:55 -0800 (PST) Received: from localhost.localdomain (134.230-245-81.adsl-dyn.isp.belgacom.be [81.245.230.134]) by mx.google.com with ESMTPS id l14sm1288729weq.35.2010.11.17.09.52.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 17 Nov 2010 09:52:54 -0800 (PST) From: Jean Pihet To: linux-omap@vger.kernel.org Cc: Jean Pihet , Jean Pihet Subject: [PATCH] OMAP3: add comments for erratas i540 and i478 workarounds Date: Wed, 17 Nov 2010 18:52:11 +0100 Message-Id: <1290016331-9007-1-git-send-email-j-pihet@ti.com> X-Mailer: git-send-email 1.7.2.3 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 17 Nov 2010 17:53:04 +0000 (UTC) diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c index 32eeabe..85bf8ca 100644 --- a/arch/arm/mach-omap2/irq.c +++ b/arch/arm/mach-omap2/irq.c @@ -284,7 +284,10 @@ void omap3_intc_suspend(void) void omap3_intc_prepare_idle(void) { - /* Disable autoidle as it can stall interrupt controller */ + /* + * Disable autoidle as it can stall interrupt controller, + * cf. errata ID i540 for 3430 (all revisions up to 3.1.x) + */ intc_bank_write_reg(0, &irq_banks[0], INTC_SYSCONFIG); } diff --git a/arch/arm/mach-omap2/powerdomains34xx.h b/arch/arm/mach-omap2/powerdomains34xx.h index fa90486..ce5c15b 100644 --- a/arch/arm/mach-omap2/powerdomains34xx.h +++ b/arch/arm/mach-omap2/powerdomains34xx.h @@ -80,6 +80,10 @@ static struct powerdomain mpu_3xxx_pwrdm = { * 3430s upto ES3.0 and 3630ES1.0. Hence this feature * needs to be disabled on these chips. * Refer: 3430 errata ID i459 and 3630 errata ID i579 + * + * Note: setting the SAR flag could help for errata ID i478 + * which applies to 3430 <= ES3.1, but since the SAR feature + * is broken, do not use it. */ static struct powerdomain core_3xxx_pre_es3_1_pwrdm = { .name = "core_pwrdm", @@ -108,6 +112,10 @@ static struct powerdomain core_3xxx_es3_1_pwrdm = { CHIP_GE_OMAP3630ES1_1), .pwrsts = PWRSTS_OFF_RET_ON, .pwrsts_logic_ret = PWRSTS_OFF_RET, + /* + * Setting the SAR flag for errata ID i478 which applies + * to 3430 <= ES3.1 + */ .flags = PWRDM_HAS_HDWR_SAR, /* for USBTLL only */ .banks = 2, .pwrsts_mem_ret = {