diff mbox

arm: omap3: cm-t3517: fix section mismatch warning

Message ID 1303850474-25106-1-git-send-email-grinberg@compulab.co.il (mailing list archive)
State Accepted
Commit 6424a850aecb030acac9e939d8dc6fb6e55b19ad
Headers show

Commit Message

Igor Grinberg April 26, 2011, 8:41 p.m. UTC
WARNING: arch/arm/mach-omap2/built-in.o(.text+0x11014): Section mismatch
in reference from the function cm_t3517_init_usbh() to the (unknown
reference) .init.data:(unknown)
The function cm_t3517_init_usbh() references
the (unknown reference) __initdata (unknown).
This is often because cm_t3517_init_usbh lacks a __initdata
annotation or the annotation of (unknown) is wrong.

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
---
 arch/arm/mach-omap2/board-cm-t3517.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Igor Grinberg May 3, 2011, 3:30 p.m. UTC | #1
ping!


Just to make sure you haven't missed this one liner ;)


On 04/26/11 23:41, Igor Grinberg wrote:

> WARNING: arch/arm/mach-omap2/built-in.o(.text+0x11014): Section mismatch
> in reference from the function cm_t3517_init_usbh() to the (unknown
> reference) .init.data:(unknown)
> The function cm_t3517_init_usbh() references
> the (unknown reference) __initdata (unknown).
> This is often because cm_t3517_init_usbh lacks a __initdata
> annotation or the annotation of (unknown) is wrong.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
>  arch/arm/mach-omap2/board-cm-t3517.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-cm-t3517.c b/arch/arm/mach-omap2/board-cm-t3517.c
> index a27e3ee..802cb60 100644
> --- a/arch/arm/mach-omap2/board-cm-t3517.c
> +++ b/arch/arm/mach-omap2/board-cm-t3517.c
> @@ -178,7 +178,7 @@ static struct usbhs_omap_board_data cm_t3517_ehci_pdata __initdata = {
>  	.reset_gpio_port[2]  = -EINVAL,
>  };
>  
> -static int cm_t3517_init_usbh(void)
> +static int __init cm_t3517_init_usbh(void)
>  {
>  	int err;
>
Igor Grinberg May 11, 2011, 7:37 a.m. UTC | #2
ping x2


Can this one get into .39?


On 05/03/11 18:30, Igor Grinberg wrote:

> ping!
>
> Just to make sure you haven't missed this one liner ;)
>
>
> On 04/26/11 23:41, Igor Grinberg wrote:
>> WARNING: arch/arm/mach-omap2/built-in.o(.text+0x11014): Section mismatch
>> in reference from the function cm_t3517_init_usbh() to the (unknown
>> reference) .init.data:(unknown)
>> The function cm_t3517_init_usbh() references
>> the (unknown reference) __initdata (unknown).
>> This is often because cm_t3517_init_usbh lacks a __initdata
>> annotation or the annotation of (unknown) is wrong.
>>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> ---
>>  arch/arm/mach-omap2/board-cm-t3517.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-cm-t3517.c b/arch/arm/mach-omap2/board-cm-t3517.c
>> index a27e3ee..802cb60 100644
>> --- a/arch/arm/mach-omap2/board-cm-t3517.c
>> +++ b/arch/arm/mach-omap2/board-cm-t3517.c
>> @@ -178,7 +178,7 @@ static struct usbhs_omap_board_data cm_t3517_ehci_pdata __initdata = {
>>  	.reset_gpio_port[2]  = -EINVAL,
>>  };
>>  
>> -static int cm_t3517_init_usbh(void)
>> +static int __init cm_t3517_init_usbh(void)
>>  {
>>  	int err;
>>
Igor Grinberg May 16, 2011, 1:36 p.m. UTC | #3
ping x3


It has been 3 weeks already...


On 05/11/11 10:37, Igor Grinberg wrote:

> ping x2
>
>
> Can this one get into .39?
>
>
> On 05/03/11 18:30, Igor Grinberg wrote:
>
>> ping!
>>
>> Just to make sure you haven't missed this one liner ;)
>>
>>
>> On 04/26/11 23:41, Igor Grinberg wrote:
>>> WARNING: arch/arm/mach-omap2/built-in.o(.text+0x11014): Section mismatch
>>> in reference from the function cm_t3517_init_usbh() to the (unknown
>>> reference) .init.data:(unknown)
>>> The function cm_t3517_init_usbh() references
>>> the (unknown reference) __initdata (unknown).
>>> This is often because cm_t3517_init_usbh lacks a __initdata
>>> annotation or the annotation of (unknown) is wrong.
>>>
>>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>>> ---
>>>  arch/arm/mach-omap2/board-cm-t3517.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-cm-t3517.c b/arch/arm/mach-omap2/board-cm-t3517.c
>>> index a27e3ee..802cb60 100644
>>> --- a/arch/arm/mach-omap2/board-cm-t3517.c
>>> +++ b/arch/arm/mach-omap2/board-cm-t3517.c
>>> @@ -178,7 +178,7 @@ static struct usbhs_omap_board_data cm_t3517_ehci_pdata __initdata = {
>>>  	.reset_gpio_port[2]  = -EINVAL,
>>>  };
>>>  
>>> -static int cm_t3517_init_usbh(void)
>>> +static int __init cm_t3517_init_usbh(void)
>>>  {
>>>  	int err;
>>>
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/board-cm-t3517.c b/arch/arm/mach-omap2/board-cm-t3517.c
index a27e3ee..802cb60 100644
--- a/arch/arm/mach-omap2/board-cm-t3517.c
+++ b/arch/arm/mach-omap2/board-cm-t3517.c
@@ -178,7 +178,7 @@  static struct usbhs_omap_board_data cm_t3517_ehci_pdata __initdata = {
 	.reset_gpio_port[2]  = -EINVAL,
 };
 
-static int cm_t3517_init_usbh(void)
+static int __init cm_t3517_init_usbh(void)
 {
 	int err;