| Message ID | 1304687833-4578-3-git-send-email-leslyam@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Lesly, On Fri, May 06, 2011 at 06:47:08PM +0530, Lesly A M wrote: > Correcting the if condition check for printing the warning, > if wakeup script is not updated before updating the sleep script. > > Since the flag 'order' is set to '1' while updating the wakeup script for P1P2, > the condition checking for printing the warning should be if(!order) > (ie: print the warning if wakeup script is not updated before updating the sleep script) > This one is already applied to my for-next. Cheers, Samuel.
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 97f54ce..12ab2a6 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -448,7 +448,7 @@ static int __init load_twl4030_script(struct twl4030_script *tscript, goto out; } if (tscript->flags & TWL4030_SLEEP_SCRIPT) { - if (order) + if (!order) pr_warning("TWL4030: Bad order of scripts (sleep "\ "script before wakeup) Leads to boot"\ "failure on some boards\n");
Correcting the if condition check for printing the warning, if wakeup script is not updated before updating the sleep script. Since the flag 'order' is set to '1' while updating the wakeup script for P1P2, the condition checking for printing the warning should be if(!order) (ie: print the warning if wakeup script is not updated before updating the sleep script) Signed-off-by: Lesly A M <leslyam@ti.com> Cc: Nishanth Menon <nm@ti.com> Cc: David Derrick <dderrick@ti.com> Cc: Samuel Ortiz <sameo@linux.intel.com> --- drivers/mfd/twl4030-power.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)