From patchwork Fri May 6 13:17:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lesly A M X-Patchwork-Id: 762162 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p46DHGsf018107 for ; Fri, 6 May 2011 13:17:18 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755769Ab1EFNRQ (ORCPT ); Fri, 6 May 2011 09:17:16 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:54024 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754893Ab1EFNRO (ORCPT ); Fri, 6 May 2011 09:17:14 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id p46DHBmj021771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 May 2011 08:17:13 -0500 Received: from dbde70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id p46DH78T020575; Fri, 6 May 2011 18:47:07 +0530 (IST) Received: from dbdp31.itg.ti.com (172.24.170.98) by DBDE70.ent.ti.com (172.24.170.148) with Microsoft SMTP Server id 8.3.106.1; Fri, 6 May 2011 18:47:06 +0530 Received: from ucmsshproxy.india.ext.ti.com (dbdp20.itg.ti.com [172.24.170.38]) by dbdp31.itg.ti.com (8.13.8/8.13.8) with SMTP id p46DH6aW002984; Fri, 6 May 2011 18:47:06 +0530 (IST) Received: from localhost (unknown [10.24.244.61]) by ucmsshproxy.india.ext.ti.com (Postfix) with ESMTP id BEA1B158002; Fri, 6 May 2011 18:47:06 +0530 (IST) From: Lesly A M To: CC: Lesly A M , Nishanth Menon , David Derrick , Samuel Ortiz Subject: [PATCH v10 2/7] MFD: TWL4030: Correct the warning print during script loading Date: Fri, 6 May 2011 18:47:08 +0530 Message-ID: <1304687833-4578-3-git-send-email-leslyam@ti.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1304687833-4578-1-git-send-email-leslyam@ti.com> References: <1304687833-4578-1-git-send-email-leslyam@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 06 May 2011 13:17:18 +0000 (UTC) Correcting the if condition check for printing the warning, if wakeup script is not updated before updating the sleep script. Since the flag 'order' is set to '1' while updating the wakeup script for P1P2, the condition checking for printing the warning should be if(!order) (ie: print the warning if wakeup script is not updated before updating the sleep script) Signed-off-by: Lesly A M Cc: Nishanth Menon Cc: David Derrick Cc: Samuel Ortiz --- drivers/mfd/twl4030-power.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 97f54ce..12ab2a6 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -448,7 +448,7 @@ static int __init load_twl4030_script(struct twl4030_script *tscript, goto out; } if (tscript->flags & TWL4030_SLEEP_SCRIPT) { - if (order) + if (!order) pr_warning("TWL4030: Bad order of scripts (sleep "\ "script before wakeup) Leads to boot"\ "failure on some boards\n");