diff mbox

[PM-WIP_CPUFREQ,3/6,v2] OMAP2+: cpufreq: minor comment cleanup

Message ID 1305704266-17623-4-git-send-email-nm@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nishanth Menon May 18, 2011, 7:37 a.m. UTC
this should probably get squashed in..

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/mach-omap2/omap2plus-cpufreq.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Comments

Todd Poynor May 18, 2011, 8:08 p.m. UTC | #1
On Wed, May 18, 2011 at 02:37:43AM -0500, Nishanth Menon wrote:
> this should probably get squashed in..
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/mach-omap2/omap2plus-cpufreq.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index 6e3666a..45f1e9e 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -84,8 +84,10 @@ static int omap_target(struct cpufreq_policy *policy,
>  	if (is_smp() && (num_online_cpus() < NR_CPUS))
>  		return ret;
>  
> -	/* Ensure desired rate is within allowed range.  Some govenors
> -	 * (ondemand) will just pass target_freq=0 to get the minimum. */
> +	/*
> +	 * Ensure desired rate is within allowed range.  Some govenors
> +	 * (ondemand) will just pass target_freq=0 to get the minimum.

So long as the comment is being touched up, could fixup the typo for
"governor" (and also copied to a new block of code in another patch
in the series).

> +	 */
>  	if (target_freq < policy->min)
>  		target_freq = policy->min;
>  	if (target_freq > policy->max)
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nishanth Menon May 18, 2011, 8:34 p.m. UTC | #2
On Wed, May 18, 2011 at 15:08, Todd Poynor <toddpoynor@google.com> wrote:
> On Wed, May 18, 2011 at 02:37:43AM -0500, Nishanth Menon wrote:
>> this should probably get squashed in..
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>  arch/arm/mach-omap2/omap2plus-cpufreq.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
>> index 6e3666a..45f1e9e 100644
>> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
>> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
>> @@ -84,8 +84,10 @@ static int omap_target(struct cpufreq_policy *policy,
>>       if (is_smp() && (num_online_cpus() < NR_CPUS))
>>               return ret;
>>
>> -     /* Ensure desired rate is within allowed range.  Some govenors
>> -      * (ondemand) will just pass target_freq=0 to get the minimum. */
>> +     /*
>> +      * Ensure desired rate is within allowed range.  Some govenors
>> +      * (ondemand) will just pass target_freq=0 to get the minimum.
>
> So long as the comment is being touched up, could fixup the typo for
> "governor" (and also copied to a new block of code in another patch
> in the series).

Will do. thanks for catching it :).

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
index 6e3666a..45f1e9e 100644
--- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
+++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
@@ -84,8 +84,10 @@  static int omap_target(struct cpufreq_policy *policy,
 	if (is_smp() && (num_online_cpus() < NR_CPUS))
 		return ret;
 
-	/* Ensure desired rate is within allowed range.  Some govenors
-	 * (ondemand) will just pass target_freq=0 to get the minimum. */
+	/*
+	 * Ensure desired rate is within allowed range.  Some govenors
+	 * (ondemand) will just pass target_freq=0 to get the minimum.
+	 */
 	if (target_freq < policy->min)
 		target_freq = policy->min;
 	if (target_freq > policy->max)