From patchwork Mon May 23 23:12:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 810372 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4NNCMsB022819 for ; Mon, 23 May 2011 23:12:22 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754919Ab1EWXMV (ORCPT ); Mon, 23 May 2011 19:12:21 -0400 Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:57656 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461Ab1EWXMU (ORCPT ); Mon, 23 May 2011 19:12:20 -0400 Received: from mail-gx0-f181.google.com ([209.85.161.181]) (using TLSv1) by na3sys009aob107.postini.com ([74.125.148.12]) with SMTP ID DSNKTdrp031sjfItmswNaMpzGs7xjzmEVxci@postini.com; Mon, 23 May 2011 16:12:20 PDT Received: by mail-gx0-f181.google.com with SMTP id 9so2720309gxk.12 for ; Mon, 23 May 2011 16:12:19 -0700 (PDT) Received: by 10.151.24.10 with SMTP id b10mr3308303ybj.93.1306192339263; Mon, 23 May 2011 16:12:19 -0700 (PDT) Received: from localhost (dragon.ti.com [192.94.94.33]) by mx.google.com with ESMTPS id s7sm5142217anl.29.2011.05.23.16.12.17 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 May 2011 16:12:17 -0700 (PDT) From: Nishanth Menon To: linux-pm Cc: linux-omap , "Rafael J. Wysocki" , Nishanth Menon Subject: [PATCH] PM: OPP: introduce function to free cpufreq table Date: Mon, 23 May 2011 18:12:15 -0500 Message-Id: <1306192335-19883-1-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.7.1 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 23 May 2011 23:12:22 +0000 (UTC) cpufreq table allocated by opp_init_cpufreq_table is better freed by OPP layer itself. This allows future modifications to the table handling to be transparent to the users. Signed-off-by: Nishanth Menon --- Example discussion: http://marc.info/?t=130570440600005&r=1&w=2 Documentation/power/opp.txt | 2 ++ drivers/base/power/opp.c | 20 ++++++++++++++++++++ include/linux/opp.h | 8 ++++++++ 3 files changed, 30 insertions(+), 0 deletions(-) diff --git a/Documentation/power/opp.txt b/Documentation/power/opp.txt index 5ae70a1..3035d00 100644 --- a/Documentation/power/opp.txt +++ b/Documentation/power/opp.txt @@ -321,6 +321,8 @@ opp_init_cpufreq_table - cpufreq framework typically is initialized with addition to CONFIG_PM as power management feature is required to dynamically scale voltage and frequency in a system. +opp_free_cpufreq_table - Free up the table allocated by opp_init_cpufreq_table + 7. Data Structures ================== Typically an SoC contains multiple voltage domains which are variable. Each diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 56a6899..bf0c2ee 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -625,4 +625,24 @@ int opp_init_cpufreq_table(struct device *dev, return 0; } + +/** + * opp_free_cpufreq_table() - free the cpufreq table + * @dev: device for which we do this operation + * @table: table to free + * + * Free up the table allocated by opp_init_cpufreq_table + */ +void opp_free_cpufreq_table(struct device *dev, + struct cpufreq_frequency_table **table) +{ + if (!table) + return; + + /* Pretend as if I am an updater */ + mutex_lock(&dev_opp_list_lock); + kfree(*table); + *table = NULL; + mutex_unlock(&dev_opp_list_lock); +} #endif /* CONFIG_CPU_FREQ */ diff --git a/include/linux/opp.h b/include/linux/opp.h index 5449945..7020e97 100644 --- a/include/linux/opp.h +++ b/include/linux/opp.h @@ -94,12 +94,20 @@ static inline int opp_disable(struct device *dev, unsigned long freq) #if defined(CONFIG_CPU_FREQ) && defined(CONFIG_PM_OPP) int opp_init_cpufreq_table(struct device *dev, struct cpufreq_frequency_table **table); +void opp_free_cpufreq_table(struct device *dev, + struct cpufreq_frequency_table **table); #else static inline int opp_init_cpufreq_table(struct device *dev, struct cpufreq_frequency_table **table) { return -EINVAL; } + +static inline +void opp_free_cpufreq_table(struct device *dev, + struct cpufreq_frequency_table **table) +{ +} #endif /* CONFIG_CPU_FREQ */ #endif /* __LINUX_OPP_H__ */