| Message ID | 1314811510-15595-2-git-send-email-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, a comment: On Wed, 31 Aug 2011, Keerthy wrote: > div_ts_ck feeds only the temperature sensor functional clock > and also has a clksel associated (for divider selection). Mapping this > as the functional clock for the temperature sensor in clkdev table, > so a clk_set_rate() in the driver would have the effect of changing the > temperature sensor clock rate indirectly. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > Reviewed-by: Rajendra Nayak <rnayak@ti.com> > Cc: tony@atomide.com > Cc: rnayak@ti.com > --- > arch/arm/mach-omap2/clock44xx_data.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c > index 2af0e3f..4a788f4 100644 > --- a/arch/arm/mach-omap2/clock44xx_data.c > +++ b/arch/arm/mach-omap2/clock44xx_data.c > @@ -3187,7 +3187,7 @@ static struct omap_clk omap44xx_clks[] = { > CLK(NULL, "bandgap_fclk", &bandgap_fclk, CK_443X), > CLK(NULL, "bandgap_ts_fclk", &bandgap_ts_fclk, CK_446X), > CLK(NULL, "des3des_fck", &des3des_fck, CK_443X), > - CLK(NULL, "div_ts_ck", &div_ts_ck, CK_446X), > + CLK("omap_temp_sensor.0", "fck", &div_ts_ck, CK_446X), It shouldn't be necessary to add the device name/ID here. We're trying to get rid of these. The omap_device code should take care of adding the appropriate alias. > CLK(NULL, "dmic_sync_mux_ck", &dmic_sync_mux_ck, CK_443X), > CLK(NULL, "dmic_fck", &dmic_fck, CK_443X), > CLK(NULL, "dsp_fck", &dsp_fck, CK_443X), > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Paul, On Thursday 01 September 2011 05:30 AM, Paul Walmsley wrote: > Hi, > > a comment: > > On Wed, 31 Aug 2011, Keerthy wrote: > >> div_ts_ck feeds only the temperature sensor functional clock >> and also has a clksel associated (for divider selection). Mapping this >> as the functional clock for the temperature sensor in clkdev table, >> so a clk_set_rate() in the driver would have the effect of changing the >> temperature sensor clock rate indirectly. >> >> Signed-off-by: Keerthy<j-keerthy@ti.com> >> Reviewed-by: Rajendra Nayak<rnayak@ti.com> >> Cc: tony@atomide.com >> Cc: rnayak@ti.com >> --- >> arch/arm/mach-omap2/clock44xx_data.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c >> index 2af0e3f..4a788f4 100644 >> --- a/arch/arm/mach-omap2/clock44xx_data.c >> +++ b/arch/arm/mach-omap2/clock44xx_data.c >> @@ -3187,7 +3187,7 @@ static struct omap_clk omap44xx_clks[] = { >> CLK(NULL, "bandgap_fclk", &bandgap_fclk, CK_443X), >> CLK(NULL, "bandgap_ts_fclk", &bandgap_ts_fclk, CK_446X), >> CLK(NULL, "des3des_fck", &des3des_fck, CK_443X), >> - CLK(NULL, "div_ts_ck", &div_ts_ck, CK_446X), >> + CLK("omap_temp_sensor.0", "fck", &div_ts_ck, CK_446X), > > It shouldn't be necessary to add the device name/ID here. We're trying > to get rid of these. The omap_device code should take care of adding the > appropriate alias. The problem seems to be that we have 2 clock nodes modeled, bandgap_ts_fclk with enable/disable ops, (which also happens to be the main_clk for the bandgap hwmod) and div_ts_ck (as parent of bandgap_ts_fclk) with clksel for divider selection. Like you said, the clkdev entries are added by omap_device code for bandgap_ts_fclk, however doing a clk_set_rate on it from the driver has no effect as the clksel information is missing and is modeled in the parent (div_ts_ck) node. From looking at it, it makes sense to merge these 2 nodes and fix the autogen scripts which currently generate 2 separate nodes. what do you think? regards, Rajendra > > >> CLK(NULL, "dmic_sync_mux_ck", &dmic_sync_mux_ck, CK_443X), >> CLK(NULL, "dmic_fck", &dmic_fck, CK_443X), >> CLK(NULL, "dsp_fck", &dsp_fck, CK_443X), >> -- >> 1.7.0.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 2af0e3f..4a788f4 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -3187,7 +3187,7 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "bandgap_fclk", &bandgap_fclk, CK_443X), CLK(NULL, "bandgap_ts_fclk", &bandgap_ts_fclk, CK_446X), CLK(NULL, "des3des_fck", &des3des_fck, CK_443X), - CLK(NULL, "div_ts_ck", &div_ts_ck, CK_446X), + CLK("omap_temp_sensor.0", "fck", &div_ts_ck, CK_446X), CLK(NULL, "dmic_sync_mux_ck", &dmic_sync_mux_ck, CK_443X), CLK(NULL, "dmic_fck", &dmic_fck, CK_443X), CLK(NULL, "dsp_fck", &dsp_fck, CK_443X),