diff mbox

[v2,1/3] arm: omap: hwmod: add new memory resource for usb phy control

Message ID 1342002598-30633-1-git-send-email-x0132156@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Damodar Santhapuri July 11, 2012, 10:29 a.m. UTC
From: Ajay Kumar Gupta <ajay.gupta@ti.com>

Added usb_ctrl0 and usb_ctrl1 base address as new memory resources
which will be used at am335x musb driver glue layer to turn on or
off builin PHY untill we have a separate system control module
driver.

Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Singed-off-by: Damodar Santhapuri <x0132156@ti.com>
---
Changes from v0:
Reordered the layout based on Kishon's comment on not using
platform_get_resources_by_name.

 arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

Comments

Sergei Shtylyov July 11, 2012, 12:44 p.m. UTC | #1
Hello.

On 11-07-2012 14:29, Damodar Santhapuri wrote:

> From: Ajay Kumar Gupta <ajay.gupta@ti.com>

> Added usb_ctrl0 and usb_ctrl1 base address as new memory resources
> which will be used at am335x musb driver glue layer to turn on or
> off builin PHY untill we have a separate system control module
> driver.

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> Singed-off-by: Damodar Santhapuri <x0132156@ti.com>
> ---
> Changes from v0:
> Reordered the layout based on Kishon's comment on not using
> platform_get_resources_by_name.

>   arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   12 ++++++++++++
>   1 files changed, 12 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index df888fe..ec9e9df 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> @@ -3269,11 +3269,23 @@ static struct omap_hwmod_addr_space am33xx_usbss_addr_space[] = {
>   		.flags		= ADDR_TYPE_RT
>   	},
>   	{
> +		.name		= "usb_ctrl0",
> +		.pa_start	= 0x44E10620,
> +		.pa_end		= 0x44E10624,

   Not 0x44E10623?

> +		.flags		= ADDR_TYPE_RT
> +	},
> +	{
>   		.name		= "musb1",
>   		.pa_start	= 0x47401800,
>   		.pa_end		= 0x47401800 + SZ_2K - 1,
>   		.flags		= ADDR_TYPE_RT
>   	},
> +	{
> +		.name		= "usb_ctrl1",
> +		.pa_start	= 0x44E10628,
> +		.pa_end		= 0x44E1062c,

    Not 0x44E1062B?

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Santhapuri, Damodar July 12, 2012, 8:52 a.m. UTC | #2
Hi,
> 
> Hello.
> 
> On 11-07-2012 14:29, Damodar Santhapuri wrote:
> 
> > From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> 
> > Added usb_ctrl0 and usb_ctrl1 base address as new memory resources
> > which will be used at am335x musb driver glue layer to turn on or
> > off builin PHY untill we have a separate system control module
> > driver.
> 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > Singed-off-by: Damodar Santhapuri <x0132156@ti.com>
> > ---
> > Changes from v0:
> > Reordered the layout based on Kishon's comment on not using
> > platform_get_resources_by_name.
> 
> >   arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   12 ++++++++++++
> >   1 files changed, 12 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-
> omap2/omap_hwmod_33xx_data.c
> > index df888fe..ec9e9df 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > @@ -3269,11 +3269,23 @@ static struct omap_hwmod_addr_space
> am33xx_usbss_addr_space[] = {
> >   		.flags		= ADDR_TYPE_RT
> >   	},
> >   	{
> > +		.name		= "usb_ctrl0",
> > +		.pa_start	= 0x44E10620,
> > +		.pa_end		= 0x44E10624,
> 
>    Not 0x44E10623?
> 
> > +		.flags		= ADDR_TYPE_RT
> > +	},
> > +	{
> >   		.name		= "musb1",
> >   		.pa_start	= 0x47401800,
> >   		.pa_end		= 0x47401800 + SZ_2K - 1,
> >   		.flags		= ADDR_TYPE_RT
> >   	},
> > +	{
> > +		.name		= "usb_ctrl1",
> > +		.pa_start	= 0x44E10628,
> > +		.pa_end		= 0x44E1062c,
> 
>     Not 0x44E1062B?

I will fix this and send you updated patch.

Damodar .
> 
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index df888fe..ec9e9df 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -3269,11 +3269,23 @@  static struct omap_hwmod_addr_space am33xx_usbss_addr_space[] = {
 		.flags		= ADDR_TYPE_RT
 	},
 	{
+		.name		= "usb_ctrl0",
+		.pa_start	= 0x44E10620,
+		.pa_end		= 0x44E10624,
+		.flags		= ADDR_TYPE_RT
+	},
+	{
 		.name		= "musb1",
 		.pa_start	= 0x47401800,
 		.pa_end		= 0x47401800 + SZ_2K - 1,
 		.flags		= ADDR_TYPE_RT
 	},
+	{
+		.name		= "usb_ctrl1",
+		.pa_start	= 0x44E10628,
+		.pa_end		= 0x44E1062c,
+		.flags		= ADDR_TYPE_RT
+	},
 	{ }
 };