diff mbox

usb otg: TWL4030_USB depends on USB_MUSB_OMAP2PLUS in Kconfig

Message ID 1345754324-12068-1-git-send-email-pmeerw@pmeerw.net (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Meerwald-Stadler Aug. 23, 2012, 8:38 p.m. UTC
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/usb/otg/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Felipe Balbi Aug. 24, 2012, 7:27 a.m. UTC | #1
On Thu, Aug 23, 2012 at 10:38:44PM +0200, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>

I need a commit log explaining why we need to add this extra depend ;-)

> ---
>  drivers/usb/otg/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
> index 13fd1ddf..fefca18 100644
> --- a/drivers/usb/otg/Kconfig
> +++ b/drivers/usb/otg/Kconfig
> @@ -58,7 +58,7 @@ config USB_ULPI_VIEWPORT
>  
>  config TWL4030_USB
>  	tristate "TWL4030 USB Transceiver Driver"
> -	depends on TWL4030_CORE && REGULATOR_TWL4030
> +	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
>  	select USB_OTG_UTILS
>  	help
>  	  Enable this to support the USB OTG transceiver on TWL4030
> -- 
> 1.7.9.5
>
Kishon Vijay Abraham I Aug. 24, 2012, 10:18 a.m. UTC | #2
Hi,

On Fri, Aug 24, 2012 at 12:57 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Thu, Aug 23, 2012 at 10:38:44PM +0200, Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>
> I need a commit log explaining why we need to add this extra depend ;-)
>
>> ---
>>  drivers/usb/otg/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
>> index 13fd1ddf..fefca18 100644
>> --- a/drivers/usb/otg/Kconfig
>> +++ b/drivers/usb/otg/Kconfig
>> @@ -58,7 +58,7 @@ config USB_ULPI_VIEWPORT
>>
>>  config TWL4030_USB
>>       tristate "TWL4030 USB Transceiver Driver"
>> -     depends on TWL4030_CORE && REGULATOR_TWL4030
>> +     depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS

Can you add this for twl6030 also?

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
index 13fd1ddf..fefca18 100644
--- a/drivers/usb/otg/Kconfig
+++ b/drivers/usb/otg/Kconfig
@@ -58,7 +58,7 @@  config USB_ULPI_VIEWPORT
 
 config TWL4030_USB
 	tristate "TWL4030 USB Transceiver Driver"
-	depends on TWL4030_CORE && REGULATOR_TWL4030
+	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
 	select USB_OTG_UTILS
 	help
 	  Enable this to support the USB OTG transceiver on TWL4030