diff mbox

[v8,08/13] arm/dts: am33xx: Add dt data for usbss

Message ID 1346323825-24385-9-git-send-email-ravibabu@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

B, Ravi Aug. 30, 2012, 10:50 a.m. UTC
From: Ajay Kumar Gupta <ajay.gupta@ti.com>

Added device tree data for usbss on am33xx. There are two musb controllers
on am33xx platform so have port0_mode and port1_mode additional data.

Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Signed-off-by: Ravi Babu <ravibabu@ti.com>
Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
Signed-off-by: Ravi Babu <ravibabu@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

Comments

Sergei Shtylyov Aug. 30, 2012, 11:39 a.m. UTC | #1
Hello.

On 30-08-2012 14:50, Ravi Babu wrote:

> From: Ajay Kumar Gupta <ajay.gupta@ti.com>

> Added device tree data for usbss on am33xx. There are two musb controllers
> on am33xx platform so have port0_mode and port1_mode additional data.

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
>   1 files changed, 11 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 59509c4..778b95e 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -154,5 +154,16 @@
>   			#size-cells = <0>;
>   			ti,hwmods = "i2c3";
>   		};
> +
> +		usb_otg_hs: usb_otg_hs {
> +			compatible = "ti,musb-am33xx";
> +			ti,hwmods = "usb_otg_hs";
> +			multipoint = <1>;
> +			num_eps = <16>;
> +			ram_bits = <12>;
> +			port0_mode = <3>;
> +			port1_mode = <3>;

    Hyphen is preferred traditionally to underscore in the device tree files...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Felipe Balbi Aug. 31, 2012, 9:54 a.m. UTC | #2
Hi,

On Thu, Aug 30, 2012 at 03:39:40PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 30-08-2012 14:50, Ravi Babu wrote:
> 
> >From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> 
> >Added device tree data for usbss on am33xx. There are two musb controllers
> >on am33xx platform so have port0_mode and port1_mode additional data.
> 
> >Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> >Signed-off-by: Ravi Babu <ravibabu@ti.com>
> >Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
> >Signed-off-by: Ravi Babu <ravibabu@ti.com>
> >---
> >  arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
> >  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> >diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> >index 59509c4..778b95e 100644
> >--- a/arch/arm/boot/dts/am33xx.dtsi
> >+++ b/arch/arm/boot/dts/am33xx.dtsi
> >@@ -154,5 +154,16 @@
> >  			#size-cells = <0>;
> >  			ti,hwmods = "i2c3";
> >  		};
> >+
> >+		usb_otg_hs: usb_otg_hs {
> >+			compatible = "ti,musb-am33xx";
> >+			ti,hwmods = "usb_otg_hs";
> >+			multipoint = <1>;
> >+			num_eps = <16>;
> >+			ram_bits = <12>;
> >+			port0_mode = <3>;
> >+			port1_mode = <3>;
> 
>    Hyphen is preferred traditionally to underscore in the device tree files...

Are we having a v2 of this patch ??
B, Ravi Aug. 31, 2012, 10:01 a.m. UTC | #3
> On Thu, Aug 30, 2012 at 03:39:40PM +0400, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 30-08-2012 14:50, Ravi Babu wrote:
> > 
> > >From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > 
> > >Added device tree data for usbss on am33xx. There are two musb 
> > >controllers on am33xx platform so have port0_mode and 
> port1_mode additional data.
> > 
> > >Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > >Signed-off-by: Ravi Babu <ravibabu@ti.com>
> > >Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
> > >Signed-off-by: Ravi Babu <ravibabu@ti.com>
> > >---
> > >  arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
> > >  1 files changed, 11 insertions(+), 0 deletions(-)
> > 
> > >diff --git a/arch/arm/boot/dts/am33xx.dtsi 
> > >b/arch/arm/boot/dts/am33xx.dtsi index 59509c4..778b95e 100644
> > >--- a/arch/arm/boot/dts/am33xx.dtsi
> > >+++ b/arch/arm/boot/dts/am33xx.dtsi
> > >@@ -154,5 +154,16 @@
> > >  			#size-cells = <0>;
> > >  			ti,hwmods = "i2c3";
> > >  		};
> > >+
> > >+		usb_otg_hs: usb_otg_hs {
> > >+			compatible = "ti,musb-am33xx";
> > >+			ti,hwmods = "usb_otg_hs";
> > >+			multipoint = <1>;
> > >+			num_eps = <16>;
> > >+			ram_bits = <12>;
> > >+			port0_mode = <3>;
> > >+			port1_mode = <3>;
> > 
> >    Hyphen is preferred traditionally to underscore in the 
> device tree files...
> 
> Are we having a v2 of this patch ??

Felipe, I will send it shortly.

Regards
Ravi B
> 
> --
> balbi
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kishon Vijay Abraham I Aug. 31, 2012, 10:11 a.m. UTC | #4
Hi,

On Thu, Aug 30, 2012 at 4:20 PM, Ravi Babu <ravibabu@ti.com> wrote:
> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
>
> Added device tree data for usbss on am33xx. There are two musb controllers
> on am33xx platform so have port0_mode and port1_mode additional data.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
> Signed-off-by: Ravi Babu <ravibabu@ti.com>

One Signed-off-by: Ravi Babu would suffice :-)

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
B, Ravi Aug. 31, 2012, 10:16 a.m. UTC | #5
> On Thu, Aug 30, 2012 at 4:20 PM, Ravi Babu <ravibabu@ti.com> wrote:
> > From: Ajay Kumar Gupta <ajay.gupta@ti.com>
> >
> > Added device tree data for usbss on am33xx. There are two musb 
> > controllers on am33xx platform so have port0_mode and 
> port1_mode additional data.
> >
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > Signed-off-by: Ravi Babu <ravibabu@ti.com>
> > Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
> > Signed-off-by: Ravi Babu <ravibabu@ti.com>
> 
> One Signed-off-by: Ravi Babu would suffice :-)

Yes, by mistake, signoff got added two times. I will check and remove it from all patches if any.

> 
> Thanks
> Kishon
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 59509c4..778b95e 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -154,5 +154,16 @@ 
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
+
+		usb_otg_hs: usb_otg_hs {
+			compatible = "ti,musb-am33xx";
+			ti,hwmods = "usb_otg_hs";
+			multipoint = <1>;
+			num_eps = <16>;
+			ram_bits = <12>;
+			port0_mode = <3>;
+			port1_mode = <3>;
+			power = <250>;
+		};
 	};
 };