diff mbox

[2/2] arm/dts: AM33XX: Add device tree OPP table

Message ID 1346405840-31058-3-git-send-email-anilkumar@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

AnilKumar, Chimata Aug. 31, 2012, 9:37 a.m. UTC
Add DT OPP table for AM33XX family of devices. This data is
decoded by OF with of_init_opp_table() helper function.

Also adds cpu0 supply name to the corresponding dts files.
cpu0-supply name is used by cpufreq-cpu0 driver to get the
regulator pointer for voltage modifications.

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 arch/arm/boot/dts/am335x-bone.dts |    6 ++++++
 arch/arm/boot/dts/am335x-evm.dts  |    6 ++++++
 arch/arm/boot/dts/am33xx.dtsi     |   15 +++++++++++++++
 3 files changed, 27 insertions(+)

Comments

Benoit Cousson Sept. 12, 2012, 5:21 p.m. UTC | #1
+ Paul

Hi Anil,

On 08/31/2012 11:37 AM, AnilKumar Ch wrote:
> Add DT OPP table for AM33XX family of devices. This data is
> decoded by OF with of_init_opp_table() helper function.
> 
> Also adds cpu0 supply name to the corresponding dts files.
> cpu0-supply name is used by cpufreq-cpu0 driver to get the
> regulator pointer for voltage modifications.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>

I've just applied your patch in my for_3.7/dts_part2 branch.

I changed the subject to use "ARM: dts: " prefix seems it seems to be
the convention nowadays.

I can apply as the well the clock patch if Paul acks it, but it can go
through Paul as well since there is no strong dependency between them AFAIK.

Thanks,
Benoit


> ---
>  arch/arm/boot/dts/am335x-bone.dts |    6 ++++++
>  arch/arm/boot/dts/am335x-evm.dts  |    6 ++++++
>  arch/arm/boot/dts/am33xx.dtsi     |   15 +++++++++++++++
>  3 files changed, 27 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
> index ce486fc..2767b5f 100644
> --- a/arch/arm/boot/dts/am335x-bone.dts
> +++ b/arch/arm/boot/dts/am335x-bone.dts
> @@ -13,6 +13,12 @@
>  	model = "TI AM335x BeagleBone";
>  	compatible = "ti,am335x-bone", "ti,am33xx";
>  
> +	cpus {
> +		cpu@0 {
> +			cpu0-supply = <&dcdc2_reg>;
> +		};
> +	};
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0x80000000 0x10000000>; /* 256 MB */
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index baa3276..54d972c 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -13,6 +13,12 @@
>  	model = "TI AM335x EVM";
>  	compatible = "ti,am335x-evm", "ti,am33xx";
>  
> +	cpus {
> +		cpu@0 {
> +			cpu0-supply = <&vdd1_reg>;
> +		};
> +	};
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0x80000000 0x10000000>; /* 256 MB */
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index ab744d6..2043b53 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -25,6 +25,21 @@
>  	cpus {
>  		cpu@0 {
>  			compatible = "arm,cortex-a8";
> +
> +			/*
> +			 * To consider voltage drop between PMIC and SoC,
> +			 * tolerance value is reduced to 2% from 4% and
> +			 * voltage value is increased as a precaution.
> +			 */
> +			operating-points = <
> +				/* kHz    uV */
> +				720000  1285000
> +				600000  1225000
> +				500000  1125000
> +				275000  1125000
> +			>;
> +			voltage-tolerance = <2>; /* 2 percentage */
> +			clock-latency = <300000>; /* From omap-cpufreq driver */
>  		};
>  	};
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
AnilKumar, Chimata Sept. 13, 2012, 6:23 a.m. UTC | #2
On Wed, Sep 12, 2012 at 22:51:55, Cousson, Benoit wrote:
> + Paul
> 
> Hi Anil,
> 
> On 08/31/2012 11:37 AM, AnilKumar Ch wrote:
> > Add DT OPP table for AM33XX family of devices. This data is
> > decoded by OF with of_init_opp_table() helper function.
> > 
> > Also adds cpu0 supply name to the corresponding dts files.
> > cpu0-supply name is used by cpufreq-cpu0 driver to get the
> > regulator pointer for voltage modifications.
> > 
> > Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> 
> I've just applied your patch in my for_3.7/dts_part2 branch.

Thanks Benoit,

> 
> I changed the subject to use "ARM: dts: " prefix seems it seems to be
> the convention nowadays.

I will take care from next time onwards.

> 
> I can apply as the well the clock patch if Paul acks it, but it can go
> through Paul as well since there is no strong dependency between them AFAIK.

Paul,

Can you ACK "clock data entry" patch?

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index ce486fc..2767b5f 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -13,6 +13,12 @@ 
 	model = "TI AM335x BeagleBone";
 	compatible = "ti,am335x-bone", "ti,am33xx";
 
+	cpus {
+		cpu@0 {
+			cpu0-supply = <&dcdc2_reg>;
+		};
+	};
+
 	memory {
 		device_type = "memory";
 		reg = <0x80000000 0x10000000>; /* 256 MB */
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index baa3276..54d972c 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -13,6 +13,12 @@ 
 	model = "TI AM335x EVM";
 	compatible = "ti,am335x-evm", "ti,am33xx";
 
+	cpus {
+		cpu@0 {
+			cpu0-supply = <&vdd1_reg>;
+		};
+	};
+
 	memory {
 		device_type = "memory";
 		reg = <0x80000000 0x10000000>; /* 256 MB */
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index ab744d6..2043b53 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -25,6 +25,21 @@ 
 	cpus {
 		cpu@0 {
 			compatible = "arm,cortex-a8";
+
+			/*
+			 * To consider voltage drop between PMIC and SoC,
+			 * tolerance value is reduced to 2% from 4% and
+			 * voltage value is increased as a precaution.
+			 */
+			operating-points = <
+				/* kHz    uV */
+				720000  1285000
+				600000  1225000
+				500000  1125000
+				275000  1125000
+			>;
+			voltage-tolerance = <2>; /* 2 percentage */
+			clock-latency = <300000>; /* From omap-cpufreq driver */
 		};
 	};