From patchwork Tue Sep 25 09:32:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 1503251 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6FB94DF28C for ; Tue, 25 Sep 2012 09:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754407Ab2IYJdE (ORCPT ); Tue, 25 Sep 2012 05:33:04 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52376 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754396Ab2IYJdD (ORCPT ); Tue, 25 Sep 2012 05:33:03 -0400 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q8P9WwLn004024; Tue, 25 Sep 2012 04:32:58 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8P9Ww4P005947; Tue, 25 Sep 2012 04:32:58 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by dfle72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.1.323.3; Tue, 25 Sep 2012 04:32:57 -0500 Received: from localhost.localdomain (h64-6.vpn.ti.com [172.24.64.6]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8P9WrIc017624; Tue, 25 Sep 2012 04:32:56 -0500 From: Tero Kristo To: , , CC: Subject: [PATCHv5 02/10] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Date: Tue, 25 Sep 2012 12:32:37 +0300 Message-ID: <1348565565-14744-3-git-send-email-t-kristo@ti.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1348565565-14744-1-git-send-email-t-kristo@ti.com> References: <1348565565-14744-1-git-send-email-t-kristo@ti.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org These are updated based on powerdomain usecounts. Also added support for voltdm->sleep and voltdm->wakeup calls that will be invoked once voltagedomain enters sleep or wakes up based on usecount numbers. These will be used for controlling voltage scaling functionality. Signed-off-by: Tero Kristo Cc: Paul Walmsley Cc: Kevin Hilman --- arch/arm/mach-omap2/powerdomain.c | 17 +++++++++- arch/arm/mach-omap2/voltage.c | 62 +++++++++++++++++++++++++++++++++++++ arch/arm/mach-omap2/voltage.h | 13 ++++++++ 3 files changed, 91 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c index ba49029..ca54aec 100644 --- a/arch/arm/mach-omap2/powerdomain.c +++ b/arch/arm/mach-omap2/powerdomain.c @@ -1475,10 +1477,16 @@ int pwrdm_state_switch(struct powerdomain *pwrdm) */ void pwrdm_clkdm_enable(struct powerdomain *pwrdm) { + unsigned long flags; + if (!pwrdm) return; - atomic_inc(&pwrdm->usecount); + if (atomic_inc_return(&pwrdm->usecount) == 1) { + spin_lock_irqsave(&pwrdm->lock, flags); + voltdm_pwrdm_enable(pwrdm->voltdm.ptr); + spin_unlock_irqrestore(&pwrdm->lock, flags); + } } /** @@ -1492,12 +1500,19 @@ void pwrdm_clkdm_enable(struct powerdomain *pwrdm) void pwrdm_clkdm_disable(struct powerdomain *pwrdm) { int val; + unsigned long flags; if (!pwrdm) return; val = atomic_dec_return(&pwrdm->usecount); + if (!val) { + spin_lock_irqsave(&pwrdm->lock, flags); + voltdm_pwrdm_disable(pwrdm->voltdm.ptr); + spin_unlock_irqrestore(&pwrdm->lock, flags); + } + WARN_ON(val < 0); } diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c index 4dc60e8..9eb1a4b 100644 --- a/arch/arm/mach-omap2/voltage.c +++ b/arch/arm/mach-omap2/voltage.c @@ -340,6 +340,67 @@ int voltdm_add_pwrdm(struct voltagedomain *voltdm, struct powerdomain *pwrdm) } /** + * voltdm_pwrdm_enable - increase usecount for a voltagedomain + * @voltdm: struct voltagedomain * to increase count for + * + * Increases usecount for a given voltagedomain. If the usecount reaches + * 1, the domain is awakened from idle and the function will call the + * voltagedomain->wakeup callback for this domain. + */ +void voltdm_pwrdm_enable(struct voltagedomain *voltdm) +{ + unsigned long flags; + + if (!voltdm) + return; + + if (atomic_inc_return(&voltdm->usecount) == 1 && voltdm->wakeup) { + spin_lock_irqsave(&voltdm->lock, flags); + voltdm->wakeup(voltdm); + spin_unlock_irqrestore(&voltdm->lock, flags); + } +} + +/** + * voltdm_pwrdm_disable - decrease usecount for a voltagedomain + * @voltdm: struct voltagedomain * to decrease count for + * + * Decreases the usecount for a given voltagedomain. If the usecount + * reaches zero, the domain can idle and the function will call the + * voltagedomain->sleep callback, and calculate the overall target + * state for the voltagedomain. + */ +void voltdm_pwrdm_disable(struct voltagedomain *voltdm) +{ + u8 target_state = PWRDM_POWER_OFF; + int state; + struct powerdomain *pwrdm; + int val; + unsigned long flags; + + if (!voltdm) + return; + + val = atomic_dec_return(&voltdm->usecount); + + WARN_ON(val < 0); + + if (val == 0) { + spin_lock_irqsave(&voltdm->lock, flags); + /* Determine target state for voltdm */ + list_for_each_entry(pwrdm, &voltdm->pwrdm_list, voltdm_node) { + state = pwrdm_read_next_pwrst(pwrdm); + if (state > target_state) + target_state = state; + } + voltdm->target_state = target_state; + if (voltdm->sleep) + voltdm->sleep(voltdm); + spin_unlock_irqrestore(&voltdm->lock, flags); + } +} + +/** * voltdm_for_each_pwrdm - call function for each pwrdm in a voltdm * @voltdm: struct voltagedomain * to iterate over * @fn: callback function * @@ -402,6 +463,7 @@ static int _voltdm_register(struct voltagedomain *voltdm) INIT_LIST_HEAD(&voltdm->pwrdm_list); list_add(&voltdm->node, &voltdm_list); + spin_lock_init(&voltdm->lock); pr_debug("voltagedomain: registered %s\n", voltdm->name); return 0; diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h index 0ac2caf..7f4f99d 100644 --- a/arch/arm/mach-omap2/voltage.h +++ b/arch/arm/mach-omap2/voltage.h @@ -15,6 +15,7 @@ #define __ARCH_ARM_MACH_OMAP2_VOLTAGE_H #include +#include #include @@ -56,10 +57,14 @@ struct omap_vfsm_instance { * @pwrdm_list: list_head linking all powerdomains in this voltagedomain * @vc: pointer to VC channel associated with this voltagedomain * @vp: pointer to VP associated with this voltagedomain + * @usecount: number of users for this voltagedomain + * @target_state: calculated target state for the children of this domain * @read: read a VC/VP register * @write: write a VC/VP register * @read: read-modify-write a VC/VP register * @sys_clk: system clock name/frequency, used for various timing calculations + * @sleep: function to call once the domain enters idle + * @wakeup: function to call once the domain wakes up from idle * @scale: function used to scale the voltage of the voltagedomain * @nominal_volt: current nominal voltage for this voltage domain * @volt_data: voltage table having the distinct voltages supported @@ -75,6 +80,9 @@ struct voltagedomain { struct omap_vp_instance *vp; struct omap_voltdm_pmic *pmic; + atomic_t usecount; + u8 target_state; + /* VC/VP register access functions: SoC specific */ u32 (*read) (u8 offset); void (*write) (u32 val, u8 offset); @@ -85,11 +93,14 @@ struct voltagedomain { u32 rate; } sys_clk; + void (*sleep) (struct voltagedomain *voltdm); + void (*wakeup) (struct voltagedomain *voltdm); int (*scale) (struct voltagedomain *voltdm, unsigned long target_volt); u32 nominal_volt; struct omap_volt_data *volt_data; + spinlock_t lock; }; /** @@ -145,6 +156,8 @@ extern void omap44xx_voltagedomains_init(void); struct voltagedomain *voltdm_lookup(const char *name); void voltdm_init(struct voltagedomain **voltdm_list); int voltdm_add_pwrdm(struct voltagedomain *voltdm, struct powerdomain *pwrdm); +void voltdm_pwrdm_enable(struct voltagedomain *voltdm); +void voltdm_pwrdm_disable(struct voltagedomain *voltdm); int voltdm_for_each(int (*fn)(struct voltagedomain *voltdm, void *user), void *user); int voltdm_for_each_pwrdm(struct voltagedomain *voltdm,