diff mbox

[PATCHv7,17/21] ARM: OMAP4: TWL: enable high speed mode for PMIC communication

Message ID 1348590833-12335-18-git-send-email-t-kristo@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tero Kristo Sept. 25, 2012, 4:33 p.m. UTC
With the new parameters, I2C can now be put to high speed mode for
better performance.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 arch/arm/mach-omap2/omap_twl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Peter Ujfalusi Sept. 26, 2012, 11:39 a.m. UTC | #1
Hi Tero,

On 09/25/2012 07:33 PM, Tero Kristo wrote:
> With the new parameters, I2C can now be put to high speed mode for
> better performance.

We have twl6040 on the same bus. have you tried this with audio enabled?
twl6040 is in standard mode (up to 100 kbps) after power up...

> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
>  arch/arm/mach-omap2/omap_twl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
> index 611cb63..7ff9667 100644
> --- a/arch/arm/mach-omap2/omap_twl.c
> +++ b/arch/arm/mach-omap2/omap_twl.c
> @@ -218,6 +218,7 @@ static struct omap_voltdm_pmic omap4_core_pmic = {
>  	.i2c_slave_addr		= OMAP4_SRI2C_SLAVE_ADDR,
>  	.volt_reg_addr		= OMAP4_VDD_CORE_SR_VOLT_REG,
>  	.cmd_reg_addr		= OMAP4_VDD_CORE_SR_CMD_REG,
> +	.i2c_high_speed		= true,
>  	.i2c_pad_load		= 3,
>  	.vsel_to_uv		= twl6030_vsel_to_uv,
>  	.uv_to_vsel		= twl6030_uv_to_vsel,
>
Tero Kristo Sept. 26, 2012, 12:06 p.m. UTC | #2
On Wed, 2012-09-26 at 14:39 +0300, Peter Ujfalusi wrote:
> Hi Tero,
> 
> On 09/25/2012 07:33 PM, Tero Kristo wrote:
> > With the new parameters, I2C can now be put to high speed mode for
> > better performance.
> 
> We have twl6040 on the same bus. have you tried this with audio enabled?
> twl6040 is in standard mode (up to 100 kbps) after power up...

No, I don't have capability to try out audio. Can you give it a shot and
see what happens? Otherwise we probably just have to drop this patch out
for now.

-Tero

> 
> > 
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > ---
> >  arch/arm/mach-omap2/omap_twl.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
> > index 611cb63..7ff9667 100644
> > --- a/arch/arm/mach-omap2/omap_twl.c
> > +++ b/arch/arm/mach-omap2/omap_twl.c
> > @@ -218,6 +218,7 @@ static struct omap_voltdm_pmic omap4_core_pmic = {
> >  	.i2c_slave_addr		= OMAP4_SRI2C_SLAVE_ADDR,
> >  	.volt_reg_addr		= OMAP4_VDD_CORE_SR_VOLT_REG,
> >  	.cmd_reg_addr		= OMAP4_VDD_CORE_SR_CMD_REG,
> > +	.i2c_high_speed		= true,
> >  	.i2c_pad_load		= 3,
> >  	.vsel_to_uv		= twl6030_vsel_to_uv,
> >  	.uv_to_vsel		= twl6030_uv_to_vsel,
> > 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peter Ujfalusi Sept. 26, 2012, 12:23 p.m. UTC | #3
On 09/26/2012 03:06 PM, Tero Kristo wrote:
> On Wed, 2012-09-26 at 14:39 +0300, Peter Ujfalusi wrote:
>> Hi Tero,
>>
>> On 09/25/2012 07:33 PM, Tero Kristo wrote:
>>> With the new parameters, I2C can now be put to high speed mode for
>>> better performance.
>>
>> We have twl6040 on the same bus. have you tried this with audio enabled?
>> twl6040 is in standard mode (up to 100 kbps) after power up...
> 
> No, I don't have capability to try out audio. Can you give it a shot and
> see what happens? Otherwise we probably just have to drop this patch out
> for now.

Just compiled your mainline-3.6-rc5-omap-auto-ret-v7 branch with audio.
Works fine on my Blaze.
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
index 611cb63..7ff9667 100644
--- a/arch/arm/mach-omap2/omap_twl.c
+++ b/arch/arm/mach-omap2/omap_twl.c
@@ -218,6 +218,7 @@  static struct omap_voltdm_pmic omap4_core_pmic = {
 	.i2c_slave_addr		= OMAP4_SRI2C_SLAVE_ADDR,
 	.volt_reg_addr		= OMAP4_VDD_CORE_SR_VOLT_REG,
 	.cmd_reg_addr		= OMAP4_VDD_CORE_SR_CMD_REG,
+	.i2c_high_speed		= true,
 	.i2c_pad_load		= 3,
 	.vsel_to_uv		= twl6030_vsel_to_uv,
 	.uv_to_vsel		= twl6030_uv_to_vsel,