| Message ID | 1351698968-3965-1-git-send-email-panto@antoniou-consulting.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: > This driver can be used for AM33xx devices, like the popular beaglebone. > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> > --- > drivers/video/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 9791d10..e7868d8 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -2202,7 +2202,7 @@ config FB_SH7760 > > config FB_DA8XX > tristate "DA8xx/OMAP-L1xx Framebuffer support" > - depends on FB && ARCH_DAVINCI_DA8XX > + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) Agreed this is present on da8xx and am33xx, but moving forward for supporting DT, we should be avoiding these dependencies. So instead change this to remove machine dependencies. Thanks, Prakash > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > -- > 1.7.12 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomi, On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: > Hi, > > On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: > > This driver can be used for AM33xx devices, like the popular beaglebone. > > > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> > > --- > > drivers/video/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > index 9791d10..e7868d8 100644 > > --- a/drivers/video/Kconfig > > +++ b/drivers/video/Kconfig > > @@ -2202,7 +2202,7 @@ config FB_SH7760 > > > > config FB_DA8XX > > tristate "DA8xx/OMAP-L1xx Framebuffer support" > > - depends on FB && ARCH_DAVINCI_DA8XX > > + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) > > Agreed this is present on da8xx and am33xx, but moving forward for > supporting DT, we should be avoiding these dependencies. So instead > change this to remove machine dependencies. > I could be wrong here, having dependency on platform seems to be right. Otherwise may lead to build errors for other platforms. Please ignore my comments and accept this patch. Thanks, Prakash -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > Hi Tomi, > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: >> Hi, >> >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: >>> This driver can be used for AM33xx devices, like the popular beaglebone. >>> >>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> >>> --- >>> drivers/video/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 9791d10..e7868d8 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -2202,7 +2202,7 @@ config FB_SH7760 >>> >>> config FB_DA8XX >>> tristate "DA8xx/OMAP-L1xx Framebuffer support" >>> - depends on FB && ARCH_DAVINCI_DA8XX >>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) >> >> Agreed this is present on da8xx and am33xx, but moving forward for >> supporting DT, we should be avoiding these dependencies. So instead >> change this to remove machine dependencies. >> > > I could be wrong here, having dependency on platform seems to be right. > Otherwise may lead to build errors for other platforms. No, it should not result in to build error unless driver uses some platform specific api's. Thanks, Vaibhav > Please ignore my > comments and accept this patch. > > Thanks, > Prakash > _______________________________________________ > Davinci-linux-open-source mailing list > Davinci-linux-open-source@linux.davincidsp.com > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Vaibhav, On Mon, Dec 10, 2012 at 14:32:06, Hiremath, Vaibhav wrote: > > > On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > > Hi Tomi, > > > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: > >> Hi, > >> > >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: > >>> This driver can be used for AM33xx devices, like the popular beaglebone. > >>> > >>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> > >>> --- > >>> drivers/video/Kconfig | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > >>> index 9791d10..e7868d8 100644 > >>> --- a/drivers/video/Kconfig > >>> +++ b/drivers/video/Kconfig > >>> @@ -2202,7 +2202,7 @@ config FB_SH7760 > >>> > >>> config FB_DA8XX > >>> tristate "DA8xx/OMAP-L1xx Framebuffer support" > >>> - depends on FB && ARCH_DAVINCI_DA8XX > >>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) > >> > >> Agreed this is present on da8xx and am33xx, but moving forward for > >> supporting DT, we should be avoiding these dependencies. So instead > >> change this to remove machine dependencies. > >> > > > > I could be wrong here, having dependency on platform seems to be right. > > Otherwise may lead to build errors for other platforms. > > No, it should not result in to build error unless driver uses some > platform specific api's. > Agreed, should not result in build error. But is it ok to show this option on the platforms which do not have this IP? Thanks, Prakash -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 12, 2012 at 12:50:28, Manjunathappa, Prakash wrote: > Hi Vaibhav, > > On Mon, Dec 10, 2012 at 14:32:06, Hiremath, Vaibhav wrote: > > > > > > On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > > > Hi Tomi, > > > > > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: > > >> Hi, > > >> > > >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: > > >>> This driver can be used for AM33xx devices, like the popular beaglebone. > > >>> > > >>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> > > >>> --- > > >>> drivers/video/Kconfig | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > > >>> index 9791d10..e7868d8 100644 > > >>> --- a/drivers/video/Kconfig > > >>> +++ b/drivers/video/Kconfig > > >>> @@ -2202,7 +2202,7 @@ config FB_SH7760 > > >>> > > >>> config FB_DA8XX > > >>> tristate "DA8xx/OMAP-L1xx Framebuffer support" > > >>> - depends on FB && ARCH_DAVINCI_DA8XX > > >>> + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) > > >> > > >> Agreed this is present on da8xx and am33xx, but moving forward for > > >> supporting DT, we should be avoiding these dependencies. So instead > > >> change this to remove machine dependencies. > > >> > > > > > > I could be wrong here, having dependency on platform seems to be right. > > > Otherwise may lead to build errors for other platforms. > > > > No, it should not result in to build error unless driver uses some > > platform specific api's. > > > > Agreed, should not result in build error. But is it ok to show this option > on the platforms which do not have this IP? > You can choose to put machine dependency here, as this patch is already doing it. The side-effect of this would be, list may grow and you may have to edit this file everytime. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Dec 12, 2012 at 13:30:56, Hiremath, Vaibhav wrote: > On Wed, Dec 12, 2012 at 12:50:28, Manjunathappa, Prakash wrote: > > Agreed, should not result in build error. But is it ok to show this option > > on the platforms which do not have this IP? > > > > You can choose to put machine dependency here, as this patch is already > doing it. The side-effect of this would be, list may grow and you may have > to edit this file everytime. It seems adding machine dependency is more in line with the approach adopted in similar cases. As this IP is used only in 2 arch's and would not in any immediate future go with other arch's, it would be better not to ask other arch's a question on whether this driver needs to be selected or not. Regards Afzal
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 9791d10..e7868d8 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -2202,7 +2202,7 @@ config FB_SH7760 config FB_DA8XX tristate "DA8xx/OMAP-L1xx Framebuffer support" - depends on FB && ARCH_DAVINCI_DA8XX + depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX) select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT
This driver can be used for AM33xx devices, like the popular beaglebone. Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> --- drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)