| Message ID | 1359993540-20780-5-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: > Enable this driver to probe in device tree boot. > > CC: Samuel Ortiz <sameo@linux.intel.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > .../devicetree/bindings/mfd/omap-usb-tll.txt | 17 +++++++++++++++++ > drivers/mfd/omap-usb-tll.c | 9 +++++++++ > 2 files changed, 26 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/omap-usb-tll.txt > > diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt b/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt > new file mode 100644 > index 0000000..835cf4f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt > @@ -0,0 +1,17 @@ > +OMAP HS USB Host TLL (Transceiver-Less Interface) > + > +Required properties: > + > +- compatible : should be "ti,usbhs-tll" > +- reg : should contain one register range i.e. start and length > +- interrupts : should contain the TLL module's interrupt > +- ti,hwmod : must contain "usb_tll_hs" > + > +Example: > + > + usbhstll: usbhstll@0x4a062000 { The node name shouldn't have 0x. This comment applies to all your patches adding device tree support. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/05/2013 08:04 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Enable this driver to probe in device tree boot. >> >> CC: Samuel Ortiz <sameo@linux.intel.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> .../devicetree/bindings/mfd/omap-usb-tll.txt | 17 +++++++++++++++++ >> drivers/mfd/omap-usb-tll.c | 9 +++++++++ >> 2 files changed, 26 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/mfd/omap-usb-tll.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt b/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt >> new file mode 100644 >> index 0000000..835cf4f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt >> @@ -0,0 +1,17 @@ >> +OMAP HS USB Host TLL (Transceiver-Less Interface) >> + >> +Required properties: >> + >> +- compatible : should be "ti,usbhs-tll" >> +- reg : should contain one register range i.e. start and length >> +- interrupts : should contain the TLL module's interrupt >> +- ti,hwmod : must contain "usb_tll_hs" >> + >> +Example: >> + >> + usbhstll: usbhstll@0x4a062000 { > The node name shouldn't have 0x. This comment applies to all your patches adding device tree support. OK, will fix. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt b/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt new file mode 100644 index 0000000..835cf4f --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/omap-usb-tll.txt @@ -0,0 +1,17 @@ +OMAP HS USB Host TLL (Transceiver-Less Interface) + +Required properties: + +- compatible : should be "ti,usbhs-tll" +- reg : should contain one register range i.e. start and length +- interrupts : should contain the TLL module's interrupt +- ti,hwmod : must contain "usb_tll_hs" + +Example: + + usbhstll: usbhstll@0x4a062000 { + compatible = "ti,usbhs-tll"; + reg = <0x4a062000 0x1000>; + interrupts = <78>; + ti,hwmods = "usb_tll_hs"; + }; diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index f7d2568..f7afb22 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -28,6 +28,7 @@ #include <linux/err.h> #include <linux/pm_runtime.h> #include <linux/platform_data/usb-omap.h> +#include <linux/of.h> #define USBTLL_DRIVER_NAME "usbhs_tll" @@ -311,10 +312,18 @@ static int usbtll_omap_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id usbtll_omap_dt_ids[] = { + { .compatible = "ti,usbhs-tll" }, + { } +}; + +MODULE_DEVICE_TABLE(of, usbtll_omap_dt_ids); + static struct platform_driver usbtll_omap_driver = { .driver = { .name = (char *)usbtll_driver_name, .owner = THIS_MODULE, + .of_match_table = of_match_ptr(usbtll_omap_dt_ids), }, .probe = usbtll_omap_probe, .remove = usbtll_omap_remove,
Enable this driver to probe in device tree boot. CC: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- .../devicetree/bindings/mfd/omap-usb-tll.txt | 17 +++++++++++++++++ drivers/mfd/omap-usb-tll.c | 9 +++++++++ 2 files changed, 26 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/omap-usb-tll.txt