From patchwork Tue Feb 12 19:22:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 2130661 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 8B115DFB7B for ; Tue, 12 Feb 2013 19:22:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933346Ab3BLTWj (ORCPT ); Tue, 12 Feb 2013 14:22:39 -0500 Received: from mail.free-electrons.com ([94.23.35.102]:47120 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932165Ab3BLTWj (ORCPT ); Tue, 12 Feb 2013 14:22:39 -0500 Received: by mail.free-electrons.com (Postfix, from userid 106) id D0DC681F; Tue, 12 Feb 2013 20:22:38 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.3.2 Received: from localhost.localdomain (20.222.3.200.ros.express.com.ar [200.3.222.20]) by mail.free-electrons.com (Postfix) with ESMTPA id 3C7C87B2; Tue, 12 Feb 2013 20:22:35 +0100 (CET) From: Ezequiel Garcia To: , Cc: Jon Hunter , Felipe Balbi , Tony Lindgren , Afzal Mohammed , Ezequiel Garcia Subject: [PATCH v3 4/8] ARM: omap2: gpmc-nand: Print something useful on CS request failure Date: Tue, 12 Feb 2013 16:22:20 -0300 Message-Id: <1360696944-3371-5-git-send-email-ezequiel.garcia@free-electrons.com> X-Mailer: git-send-email 1.7.8.6 In-Reply-To: <1360696944-3371-1-git-send-email-ezequiel.garcia@free-electrons.com> References: <1360696944-3371-1-git-send-email-ezequiel.garcia@free-electrons.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org If CS request fails the current error message is rather unhelpful. Fix it by printing the failing chip select and the error code. Signed-off-by: Ezequiel Garcia Reviewed-by: Jon Hunter --- arch/arm/mach-omap2/gpmc-nand.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c index afc1e8c..e50e438 100644 --- a/arch/arm/mach-omap2/gpmc-nand.c +++ b/arch/arm/mach-omap2/gpmc-nand.c @@ -122,7 +122,8 @@ int gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data, err = gpmc_cs_request(gpmc_nand_data->cs, NAND_IO_SIZE, (unsigned long *)&gpmc_nand_resource[0].start); if (err < 0) { - dev_err(dev, "Cannot request GPMC CS\n"); + dev_err(dev, "Cannot request GPMC CS %d, error %d\n", + gpmc_nand_data->cs, err); return err; }