| Message ID | 1362521809-22989-6-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 05 March 2013, Arnd Bergmann wrote: > The recent reorganization of OMAP header files caused a couple of > files that used to be implicitly included now missing from OMAP1. > This adds explicit inclusions of mach/irqs.h and mach/hardware.h > in all files that need them for an OMAP1 allyesconfig build. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Tony Lindgren <tony@atomide.com> > Cc: linux-omap@vger.kernel.org > --- > arch/arm/mach-omap1/board-fsample.c | 1 + > arch/arm/mach-omap1/board-h2.c | 1 + > arch/arm/mach-omap1/board-perseus2.c | 1 + > arch/arm/mach-omap1/board-sx1.c | 1 + > drivers/video/omap/lcd_ams_delta.c | 1 + > drivers/video/omap/lcd_osk.c | 1 + > 6 files changed, 6 insertions(+) I saw that Tony has already addressed the latter two changes, but did not see a fix for the four board files. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Arnd Bergmann <arnd@arndb.de> [130305 14:31]: > On Tuesday 05 March 2013, Arnd Bergmann wrote: > > The recent reorganization of OMAP header files caused a couple of > > files that used to be implicitly included now missing from OMAP1. > > This adds explicit inclusions of mach/irqs.h and mach/hardware.h > > in all files that need them for an OMAP1 allyesconfig build. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Tony Lindgren <tony@atomide.com> > > Cc: linux-omap@vger.kernel.org > > --- > > arch/arm/mach-omap1/board-fsample.c | 1 + > > arch/arm/mach-omap1/board-h2.c | 1 + > > arch/arm/mach-omap1/board-perseus2.c | 1 + > > arch/arm/mach-omap1/board-sx1.c | 1 + > > drivers/video/omap/lcd_ams_delta.c | 1 + > > drivers/video/omap/lcd_osk.c | 1 + > > 6 files changed, 6 insertions(+) > > I saw that Tony has already addressed the latter two changes, but > did not see a fix for the four board files. Hmm I wonder why I have not seen the board-*.c related ones? Anyways thanks for fixing those: Acked-by: Tony Lindgren <tony@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 06 March 2013, Tony Lindgren wrote: > * Arnd Bergmann <arnd@arndb.de> [130305 14:31]: > > On Tuesday 05 March 2013, Arnd Bergmann wrote: > > > The recent reorganization of OMAP header files caused a couple of > > > files that used to be implicitly included now missing from OMAP1. > > > This adds explicit inclusions of mach/irqs.h and mach/hardware.h > > > in all files that need them for an OMAP1 allyesconfig build. > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > Cc: Tony Lindgren <tony@atomide.com> > > > Cc: linux-omap@vger.kernel.org > > > --- > > > arch/arm/mach-omap1/board-fsample.c | 1 + > > > arch/arm/mach-omap1/board-h2.c | 1 + > > > arch/arm/mach-omap1/board-perseus2.c | 1 + > > > arch/arm/mach-omap1/board-sx1.c | 1 + > > > drivers/video/omap/lcd_ams_delta.c | 1 + > > > drivers/video/omap/lcd_osk.c | 1 + > > > 6 files changed, 6 insertions(+) > > > > I saw that Tony has already addressed the latter two changes, but > > did not see a fix for the four board files. > > Hmm I wonder why I have not seen the board-*.c related ones? > > Anyways thanks for fixing those: > > Acked-by: Tony Lindgren <tony@atomide.com> Actually I cannot reproduce them myself now, I think I'll just drop the patch for now, but will remember your Ack if the problem comes back. The patch would be needed if we decide to use SPARSE_IRQ on OMAP1. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Arnd Bergmann <arnd@arndb.de> [130306 03:27]: > On Wednesday 06 March 2013, Tony Lindgren wrote: > > * Arnd Bergmann <arnd@arndb.de> [130305 14:31]: > > > On Tuesday 05 March 2013, Arnd Bergmann wrote: > > > > The recent reorganization of OMAP header files caused a couple of > > > > files that used to be implicitly included now missing from OMAP1. > > > > This adds explicit inclusions of mach/irqs.h and mach/hardware.h > > > > in all files that need them for an OMAP1 allyesconfig build. > > > > > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > > > Cc: Tony Lindgren <tony@atomide.com> > > > > Cc: linux-omap@vger.kernel.org > > > > --- > > > > arch/arm/mach-omap1/board-fsample.c | 1 + > > > > arch/arm/mach-omap1/board-h2.c | 1 + > > > > arch/arm/mach-omap1/board-perseus2.c | 1 + > > > > arch/arm/mach-omap1/board-sx1.c | 1 + > > > > drivers/video/omap/lcd_ams_delta.c | 1 + > > > > drivers/video/omap/lcd_osk.c | 1 + > > > > 6 files changed, 6 insertions(+) > > > > > > I saw that Tony has already addressed the latter two changes, but > > > did not see a fix for the four board files. > > > > Hmm I wonder why I have not seen the board-*.c related ones? > > > > Anyways thanks for fixing those: > > > > Acked-by: Tony Lindgren <tony@atomide.com> > > Actually I cannot reproduce them myself now, I think I'll just drop > the patch for now, but will remember your Ack if the problem comes > back. The patch would be needed if we decide to use SPARSE_IRQ on > OMAP1. OK sounds good to me. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap1/board-fsample.c b/arch/arm/mach-omap1/board-fsample.c index 702d580..512b33a 100644 --- a/arch/arm/mach-omap1/board-fsample.c +++ b/arch/arm/mach-omap1/board-fsample.c @@ -33,6 +33,7 @@ #include <linux/platform_data/keypad-omap.h> #include <mach/hardware.h> +#include <mach/irqs.h> #include "iomap.h" #include "common.h" diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c index 0dac3d2..99ee4d7 100644 --- a/arch/arm/mach-omap1/board-h2.c +++ b/arch/arm/mach-omap1/board-h2.c @@ -47,6 +47,7 @@ #include <mach/hardware.h> #include <mach/usb.h> +#include <mach/irqs.h> #include "common.h" #include "board-h2.h" diff --git a/arch/arm/mach-omap1/board-perseus2.c b/arch/arm/mach-omap1/board-perseus2.c index 8b2f712..403efcc 100644 --- a/arch/arm/mach-omap1/board-perseus2.c +++ b/arch/arm/mach-omap1/board-perseus2.c @@ -31,6 +31,7 @@ #include <mach/tc.h> #include <mach/mux.h> #include <mach/flash.h> +#include <mach/irqs.h> #include <mach/hardware.h> diff --git a/arch/arm/mach-omap1/board-sx1.c b/arch/arm/mach-omap1/board-sx1.c index 9732a98..b31e77c 100644 --- a/arch/arm/mach-omap1/board-sx1.c +++ b/arch/arm/mach-omap1/board-sx1.c @@ -43,6 +43,7 @@ #include <mach/hardware.h> #include <mach/usb.h> +#include <mach/irqs.h> #include "common.h" #include "dma.h" diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c index ed4cad8..7539276 100644 --- a/drivers/video/omap/lcd_ams_delta.c +++ b/drivers/video/omap/lcd_ams_delta.c @@ -28,6 +28,7 @@ #include <linux/gpio.h> #include <mach/board-ams-delta.h> +#include <mach/hardware.h> #include "omapfb.h" diff --git a/drivers/video/omap/lcd_osk.c b/drivers/video/omap/lcd_osk.c index 3aa62da..cad2338 100644 --- a/drivers/video/omap/lcd_osk.c +++ b/drivers/video/omap/lcd_osk.c @@ -25,6 +25,7 @@ #include <asm/gpio.h> #include <mach/mux.h> +#include <mach/hardware.h> #include "omapfb.h" static int osk_panel_init(struct lcd_panel *panel, struct omapfb_device *fbdev)
The recent reorganization of OMAP header files caused a couple of files that used to be implicitly included now missing from OMAP1. This adds explicit inclusions of mach/irqs.h and mach/hardware.h in all files that need them for an OMAP1 allyesconfig build. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-omap@vger.kernel.org --- arch/arm/mach-omap1/board-fsample.c | 1 + arch/arm/mach-omap1/board-h2.c | 1 + arch/arm/mach-omap1/board-perseus2.c | 1 + arch/arm/mach-omap1/board-sx1.c | 1 + drivers/video/omap/lcd_ams_delta.c | 1 + drivers/video/omap/lcd_osk.c | 1 + 6 files changed, 6 insertions(+)