From patchwork Sun Mar 24 15:36:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grazvydas Ignotas X-Patchwork-Id: 2326831 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 3FE643FDDA for ; Sun, 24 Mar 2013 15:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940Ab3CXPhT (ORCPT ); Sun, 24 Mar 2013 11:37:19 -0400 Received: from mail-ee0-f50.google.com ([74.125.83.50]:63289 "EHLO mail-ee0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753932Ab3CXPhH (ORCPT ); Sun, 24 Mar 2013 11:37:07 -0400 Received: by mail-ee0-f50.google.com with SMTP id d4so514558eek.23 for ; Sun, 24 Mar 2013 08:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=jHyEXwlzyxFal7PPMQq2MJrZr1djsq862aF10AKanKw=; b=Om+YQoLP+fWNnUBtgUJ+XCtXGKS5b1SHyu3PCHZYpoZVhLfaUnSv3T7Yzjk4ubvQDL +lhIeK8argD9n1lBBWOlfw3SQVmRYpmBXwggZooi2wRbdQTikpMGp8pfRx1yTnUKgVIJ wmAFUbuJxxiJxI4rwz6Wb3F1IloupCdPJCxLUd0B2aCiZWG1QXd6BeqO40VpHAbKB7Ru Au2tGIFQ2QeqNgQh41iwFaf6BdD6Eqw2bBdv9caOFx3Q3ycyVYrmhJoAM61Bhtg1BTUz RxDct1IO8QCKyd30eJXGpcUBTtsqcL0n05FKjGBJD5aKlrQKaAu9SZDxLqTRGZHu2+1O bVtQ== X-Received: by 10.14.183.198 with SMTP id q46mr16357876eem.1.1364139425800; Sun, 24 Mar 2013 08:37:05 -0700 (PDT) Received: from localhost.localdomain (ip-88-119-226-136.static.b4net.lt. [88.119.226.136]) by mx.google.com with ESMTPS id bc1sm2560964eeb.11.2013.03.24.08.37.04 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Mar 2013 08:37:05 -0700 (PDT) From: Grazvydas Ignotas To: linux-usb@vger.kernel.org Cc: linux-omap@vger.kernel.org, Felipe Balbi , kishon , Grazvydas Ignotas Subject: [PATCHv3 2/3] usb: musb: omap2430: turn off vbus on cable disconnect Date: Sun, 24 Mar 2013 17:36:54 +0200 Message-Id: <1364139415-16695-3-git-send-email-notasas@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1364139415-16695-1-git-send-email-notasas@gmail.com> References: <1364139415-16695-1-git-send-email-notasas@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On USB_EVENT_ID event the musb glue enables VBUS by calling omap2430_musb_set_vbus(musb, 1) that sets the session bit, but on USB_EVENT_NONE reverse action is never made, and that breaks PM. Disable VBUS on USB_EVENT_NONE to be sure musb session is ended on cable unplug so that PM works. Signed-off-by: Grazvydas Ignotas --- drivers/usb/musb/omap2430.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 798e029..3551f1a 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -291,6 +291,7 @@ static void omap_musb_set_mailbox(struct omap2430_glue *glue) musb->xceiv->last_event = USB_EVENT_NONE; if (musb->gadget_driver) { + omap2430_musb_set_vbus(musb, 0); pm_runtime_mark_last_busy(dev); pm_runtime_put_autosuspend(dev); }