| Message ID | 1364395320-14973-2-git-send-email-mugunthanvnm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2013-03-27 at 20:11 +0530, Mugunthan V N wrote: > To restart tx queue use netif_wake_queue() intead of netif_start_queue() > so that net schedule will restart transmission immediately which will > increase network performance while doing huge data transfers. > > Reported-by: Dan Franke <dan.franke@schneider-electric.com> > Suggested-by: Sriramakrishnan A G <srk@ti.com> > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > --- > drivers/net/ethernet/ti/cpsw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index f4be85b..61ecebf 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -458,7 +458,7 @@ static void cpsw_tx_handler(void *token, int len, int status) > * queue is stopped then start the queue as we have free desc for tx > */ > if (unlikely(netif_queue_stopped(ndev))) > - netif_start_queue(ndev); > + netif_wake_queue(ndev); > cpts_tx_timestamp(priv->cpts, skb); > priv->stats.tx_packets++; > priv->stats.tx_bytes += len; Its a bug fix, suitable for net tree Acked-by: Eric Dumazet <edumazet@google.com> BTW, it seems cpsw_ndo_start_xmit() can race with cpsw_tx_handler(). -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index f4be85b..61ecebf 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -458,7 +458,7 @@ static void cpsw_tx_handler(void *token, int len, int status) * queue is stopped then start the queue as we have free desc for tx */ if (unlikely(netif_queue_stopped(ndev))) - netif_start_queue(ndev); + netif_wake_queue(ndev); cpts_tx_timestamp(priv->cpts, skb); priv->stats.tx_packets++; priv->stats.tx_bytes += len;
To restart tx queue use netif_wake_queue() intead of netif_start_queue() so that net schedule will restart transmission immediately which will increase network performance while doing huge data transfers. Reported-by: Dan Franke <dan.franke@schneider-electric.com> Suggested-by: Sriramakrishnan A G <srk@ti.com> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> --- drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)