diff mbox

mfd: twl6030: Fix endianness problem in IRQ handler

Message ID 1380712124-20666-1-git-send-email-taras.kondratiuk@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Taras Kondratiuk Oct. 2, 2013, 11:08 a.m. UTC 
From: Danke Xie <d.xie@sta.samsung.com>

The current TWL 6030 IRQ handler assumes little endianness.
This change makes it endian-neutral.

Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
---
 drivers/mfd/twl6030-irq.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Kim Phillips Oct. 2, 2013, 4:43 p.m. UTC | #1 
On Wed,  2 Oct 2013 14:08:44 +0300
Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:

> From: Danke Xie <d.xie@sta.samsung.com>
> 
> The current TWL 6030 IRQ handler assumes little endianness.
> This change makes it endian-neutral.
> 
> Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
> ---

this patch causes a new sparse warning:

make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
...
  CHECK   drivers/mfd/twl6030-irq.c
drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32

does int_sts in the sts union need to be defined as __le32?

Thanks,

Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Taras Kondratiuk Oct. 2, 2013, 9:08 p.m. UTC | #2 
On 2 October 2013 19:43, Kim Phillips <kim.phillips@linaro.org> wrote:
> On Wed,  2 Oct 2013 14:08:44 +0300
> Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:
>
>> From: Danke Xie <d.xie@sta.samsung.com>
>>
>> The current TWL 6030 IRQ handler assumes little endianness.
>> This change makes it endian-neutral.
>>
>> Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
>> ---
>
> this patch causes a new sparse warning:
>
> make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
> ...
>   CHECK   drivers/mfd/twl6030-irq.c
> drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32
>
> does int_sts in the sts union need to be defined as __le32?

You are right.
I will update the patch.
diff mbox

Patch

diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index 517eda8..1941dc6 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -178,6 +178,7 @@  static irqreturn_t twl6030_irq_thread(int irq, void *data)
 		u8 bytes[4];
 		u32 int_sts;
 	} sts;
+	u32 int_sts; /* sts.int_sts converted to CPU endianness */
 	struct twl6030_irq *pdata = data;
 
 	/* read INT_STS_A, B and C in one shot using a burst read */
@@ -196,8 +197,9 @@  static irqreturn_t twl6030_irq_thread(int irq, void *data)
 	if (sts.bytes[2] & 0x10)
 		sts.bytes[2] |= 0x08;
 
-	for (i = 0; sts.int_sts; sts.int_sts >>= 1, i++)
-		if (sts.int_sts & 0x1) {
+	int_sts = le32_to_cpu(sts.int_sts);
+	for (i = 0; int_sts; int_sts >>= 1, i++)
+		if (int_sts & 0x1) {
 			int module_irq =
 				irq_find_mapping(pdata->irq_domain,
 						 pdata->irq_mapping_tbl[i]);