| Message ID | 1387284818-28739-6-git-send-email-florian.vaussard@epfl.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: > Add missing information required to probe the iommu for the camera > subsystem. > > Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> > --- > arch/arm/boot/dts/omap3.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index daabf99..610d084 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -371,11 +371,13 @@ > dma-names = "tx", "rx"; > }; > > - mmu_isp: mmu@480bd400 { > + mmu_isp: mmu_isp@480bd400 { Any reason for switching the name to mmu_isp? > compatible = "ti,omap3-mmu-isp"; > ti,hwmods = "mmu_isp"; > reg = <0x480bd400 0x80>; > interrupts = <8>; As I was testing the series, I found that this interrupt number is wrong. The interrupt number should be 24, you can fix it in this patch. I will post couple of patches to correct the interrupt numbers for couple of other occurrences. regards Suman > + ti,#tlb-entries = <8>; > + dma-window = <0 0xfffff000>; /* IOVA start & length */ > }; > > wdt2: wdt@48314000 { > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Suman, On 12/23/2013 08:12 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> Add missing information required to probe the iommu for the camera >> subsystem. >> >> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> >> --- >> arch/arm/boot/dts/omap3.dtsi | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi >> index daabf99..610d084 100644 >> --- a/arch/arm/boot/dts/omap3.dtsi >> +++ b/arch/arm/boot/dts/omap3.dtsi >> @@ -371,11 +371,13 @@ >> dma-names = "tx", "rx"; >> }; >> >> - mmu_isp: mmu@480bd400 { >> + mmu_isp: mmu_isp@480bd400 { > > Any reason for switching the name to mmu_isp? > The name of the hwmod is "mmu_isp". This was not working otherwise, but I cannot tell you for sure why without getting back at my office. >> compatible = "ti,omap3-mmu-isp"; >> ti,hwmods = "mmu_isp"; >> reg = <0x480bd400 0x80>; >> interrupts = <8>; > > As I was testing the series, I found that this interrupt number is > wrong. The interrupt number should be 24, you can fix it in this patch. > I will post couple of patches to correct the interrupt numbers for > couple of other occurrences. > Really? Oh yes, this is CAM_IRQ0, thus M_IRQ_24. Nice catch. Regards, Florian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Florian, On 12/23/2013 03:34 PM, Florian Vaussard wrote: > Hi Suman, > > On 12/23/2013 08:12 PM, Anna, Suman wrote: >> Hi Florian, >> >> On 12/17/2013 06:53 AM, Florian Vaussard wrote: >>> Add missing information required to probe the iommu for the camera >>> subsystem. >>> >>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> >>> --- >>> arch/arm/boot/dts/omap3.dtsi | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi >>> index daabf99..610d084 100644 >>> --- a/arch/arm/boot/dts/omap3.dtsi >>> +++ b/arch/arm/boot/dts/omap3.dtsi >>> @@ -371,11 +371,13 @@ >>> dma-names = "tx", "rx"; >>> }; >>> >>> - mmu_isp: mmu@480bd400 { >>> + mmu_isp: mmu_isp@480bd400 { >> >> Any reason for switching the name to mmu_isp? >> > > The name of the hwmod is "mmu_isp". This was not working otherwise, > but I cannot tell you for sure why without getting back at my office. Ok, did a bit of digging, this is due to the name tie-in for iommu arch data (look at the omap3_camera_init in mach-omap2/devices.c), and the obj->name assignment of of->name. This is another thing that needs to be looked into since it would be preferable to move away from the name based lookup towards using a phandle approach by the iommu consumer drivers. regards Suman -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index daabf99..610d084 100644 --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -371,11 +371,13 @@ dma-names = "tx", "rx"; }; - mmu_isp: mmu@480bd400 { + mmu_isp: mmu_isp@480bd400 { compatible = "ti,omap3-mmu-isp"; ti,hwmods = "mmu_isp"; reg = <0x480bd400 0x80>; interrupts = <8>; + ti,#tlb-entries = <8>; + dma-window = <0 0xfffff000>; /* IOVA start & length */ }; wdt2: wdt@48314000 {
Add missing information required to probe the iommu for the camera subsystem. Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> --- arch/arm/boot/dts/omap3.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)