| Message ID | 1391607760-29826-1-git-send-email-stefan.sorensen@spectralink.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
-avinash On 02/05/2014 07:42 AM, Stefan Sørensen wrote: > The ELM driver incorrectly reagard any non-zero return value from > pm_runtime_get_sync as an error, but it may return 1 if the device > was already active. Fix to only error when return value is negative. > > Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> > --- > drivers/mtd/devices/elm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c > index d1dd6a3..e2c073c 100644 > --- a/drivers/mtd/devices/elm.c > +++ b/drivers/mtd/devices/elm.c > @@ -380,7 +380,7 @@ static int elm_probe(struct platform_device *pdev) > } > > pm_runtime_enable(&pdev->dev); > - if (pm_runtime_get_sync(&pdev->dev)) { > + if (pm_runtime_get_sync(&pdev->dev) < 0) { > ret = -EINVAL; > pm_runtime_disable(&pdev->dev); > dev_err(&pdev->dev, "can't enable clock\n"); > Though unrelated to specifically this, elm_resume has a get_sync without error check.. Further, you might want to cc the mailing lists generated by ./scripts/get_maintainer.pl
diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c index d1dd6a3..e2c073c 100644 --- a/drivers/mtd/devices/elm.c +++ b/drivers/mtd/devices/elm.c @@ -380,7 +380,7 @@ static int elm_probe(struct platform_device *pdev) } pm_runtime_enable(&pdev->dev); - if (pm_runtime_get_sync(&pdev->dev)) { + if (pm_runtime_get_sync(&pdev->dev) < 0) { ret = -EINVAL; pm_runtime_disable(&pdev->dev); dev_err(&pdev->dev, "can't enable clock\n");
The ELM driver incorrectly reagard any non-zero return value from pm_runtime_get_sync as an error, but it may return 1 if the device was already active. Fix to only error when return value is negative. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> --- drivers/mtd/devices/elm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)