From patchwork Wed Feb 5 13:42:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Stefan_S=C3=B8rensen?= X-Patchwork-Id: 3586441 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 53AC59F2E9 for ; Wed, 5 Feb 2014 14:01:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 954062012E for ; Wed, 5 Feb 2014 14:01:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79B312009C for ; Wed, 5 Feb 2014 14:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbaBEOBz (ORCPT ); Wed, 5 Feb 2014 09:01:55 -0500 Received: from 213083164162.static.sonofon.dk ([213.83.164.162]:29032 "EHLO HORWDSPRD01.spectralink.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750799AbaBEOBz (ORCPT ); Wed, 5 Feb 2014 09:01:55 -0500 X-Greylist: delayed 1150 seconds by postgrey-1.27 at vger.kernel.org; Wed, 05 Feb 2014 09:01:55 EST Received: from e37108.spectralink.com ([172.29.208.119]) by HORWDSPRD01.spectralink.com with Microsoft SMTPSVC(7.5.7600.16601); Wed, 5 Feb 2014 14:42:42 +0100 Received: by e37108.spectralink.com (sSMTP sendmail emulation); Wed, 05 Feb 2014 14:42:41 +0100 From: =?UTF-8?q?Stefan=20S=C3=B8rensen?= To: avinashphilip@ti.com, linux-omap@vger.kernel.org Cc: =?UTF-8?q?Stefan=20S=C3=B8rensen?= Subject: [PATCH] mtd:elm: Use correct check on return value of pm_runtime_get_sync Date: Wed, 5 Feb 2014 14:42:40 +0100 Message-Id: <1391607760-29826-1-git-send-email-stefan.sorensen@spectralink.com> X-Mailer: git-send-email 1.8.5.3 MIME-Version: 1.0 X-OriginalArrivalTime: 05 Feb 2014 13:42:42.0052 (UTC) FILETIME=[247B6440:01CF2278] Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The ELM driver incorrectly reagard any non-zero return value from pm_runtime_get_sync as an error, but it may return 1 if the device was already active. Fix to only error when return value is negative. Signed-off-by: Stefan Sørensen --- drivers/mtd/devices/elm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c index d1dd6a3..e2c073c 100644 --- a/drivers/mtd/devices/elm.c +++ b/drivers/mtd/devices/elm.c @@ -380,7 +380,7 @@ static int elm_probe(struct platform_device *pdev) } pm_runtime_enable(&pdev->dev); - if (pm_runtime_get_sync(&pdev->dev)) { + if (pm_runtime_get_sync(&pdev->dev) < 0) { ret = -EINVAL; pm_runtime_disable(&pdev->dev); dev_err(&pdev->dev, "can't enable clock\n");