From patchwork Fri Jun 27 20:17:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 4437651 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8163E9F319 for ; Fri, 27 Jun 2014 20:18:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82E86203A9 for ; Fri, 27 Jun 2014 20:18:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76696203A0 for ; Fri, 27 Jun 2014 20:18:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752581AbaF0USA (ORCPT ); Fri, 27 Jun 2014 16:18:00 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:44484 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbaF0UR7 (ORCPT ); Fri, 27 Jun 2014 16:17:59 -0400 Received: by mail-wi0-f178.google.com with SMTP id n15so3369077wiw.11 for ; Fri, 27 Jun 2014 13:17:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BO3tEnLbhucVOH6Csa9EJtd7Z4X8FeI+DJBapd8+M4I=; b=ex7pHkM8aJlAPM9hkO1xG06jOs1Vu7iwZLg9p3nKkZtIMtpFjExQksqi3Gvd746qZ2 hXHqj7pWJHRhzYz6x3AO2tAI+gI2IJTkt//LHbEzi9Z7TwkIYKVzdKTdGWSLyee5zrfY GoZzi9GcyAlofbC/UQAkhG1s2l23e2UbXVGTxjkjoSmOUMwlwxo9uEI3w+UeZ6dX0LcA LHTDUygFuHFY/EwE61iGTwDakRkU1GXMvbDLfXdVW0xNNXuJ9SqCN9UhzriQtndawgZ0 QZD4Q1Ds3nm4X2po92JDkWraD0SWHEThzAUzwjYzjknL9LWgxMTzSmSfZDrlyG00D3wl MTMg== X-Gm-Message-State: ALoCoQlKfTDqTxpBwBobAFbVle7AcODVTKeyqERDYpCgDLX8cXdfU2tm2qeQ3QHh5+JLMiuVQVEg X-Received: by 10.194.85.78 with SMTP id f14mr28455415wjz.36.1403900278452; Fri, 27 Jun 2014 13:17:58 -0700 (PDT) Received: from localhost.localdomain (197.59.23.95.dynamic.jazztel.es. [95.23.59.197]) by mx.google.com with ESMTPSA id gh16sm193762wic.3.2014.06.27.13.17.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 Jun 2014 13:17:57 -0700 (PDT) From: Javier Martinez Canillas X-Google-Original-From: Javier Martinez Canillas To: Linus Walleij Cc: Alexandre Courbot , Santosh Shilimkar , Kevin Hilman , Tony Lindgren , Aaro Koskinen , Nishanth Menon , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH 1/3] gpio: omap: Remove unnecessary lockdep class Date: Fri, 27 Jun 2014 22:17:35 +0200 Message-Id: <1403900258-20717-2-git-send-email-jmartinez@softcrates.net> X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: <1403900258-20717-1-git-send-email-jmartinez@softcrates.net> References: <1403900258-20717-1-git-send-email-jmartinez@softcrates.net> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP GPIO irqchips assign to the cascaded IRQs their own lock class in order to avoid warnings about lockdep recursions since that allow the lockdep core to keep track of things. Since commit e45d1c80 ("gpio: put GPIO IRQs into their own lock class") there is no need to do this in a driver if it's using the GPIO irqchip helpers since gpiolib already assigns a lockdep class. Signed-off-by: Javier Martinez Canillas --- drivers/gpio/gpio-omap.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 00f29aa..4b4e1b4 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1025,11 +1025,6 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank) called = true; } -/* This lock class tells lockdep that GPIO irqs are in a different - * category than their parents, so it won't report false recursion. - */ -static struct lock_class_key gpio_lock_class; - static void omap_gpio_mod_init(struct gpio_bank *bank) { void __iomem *base = bank->base; @@ -1152,7 +1147,6 @@ static int omap_gpio_chip_init(struct gpio_bank *bank) for (j = 0; j < bank->width; j++) { int irq = irq_find_mapping(bank->chip.irqdomain, j); - irq_set_lockdep_class(irq, &gpio_lock_class); if (bank->is_mpuio) { omap_mpuio_alloc_gc(bank, irq, bank->width); irq_set_chip_and_handler(irq, NULL, NULL);