| Message ID | 1413452387-25452-2-git-send-email-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 16, 2014 at 12:39:44PM +0300, Tomi Valkeinen wrote: > omapfb device can be unbound, so using __exit_p() for the driver's > remove callback is wrong. > > Remove __exit_p() and __exit from the driver's remove. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> and why was my version dropped ? http://marc.info/?l=linux-fbdev&m=141331137230988&w=2
On 16/10/14 16:19, Felipe Balbi wrote: > On Thu, Oct 16, 2014 at 12:39:44PM +0300, Tomi Valkeinen wrote: >> omapfb device can be unbound, so using __exit_p() for the driver's >> remove callback is wrong. >> >> Remove __exit_p() and __exit from the driver's remove. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > > and why was my version dropped ? > > http://marc.info/?l=linux-fbdev&m=141331137230988&w=2 Oh, sorry, for no reason. I started from scratch as there seemed to be enough issues there, and didn't remember you had the exact same patch. I'll use yours instead of my version. Tomi
diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c index ec2d132c782d..9cbf1ced51c2 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c @@ -2619,7 +2619,7 @@ err0: return r; } -static int __exit omapfb_remove(struct platform_device *pdev) +static int omapfb_remove(struct platform_device *pdev) { struct omapfb2_device *fbdev = platform_get_drvdata(pdev); @@ -2636,7 +2636,7 @@ static int __exit omapfb_remove(struct platform_device *pdev) static struct platform_driver omapfb_driver = { .probe = omapfb_probe, - .remove = __exit_p(omapfb_remove), + .remove = omapfb_remove, .driver = { .name = "omapfb", .owner = THIS_MODULE,
omapfb device can be unbound, so using __exit_p() for the driver's remove callback is wrong. Remove __exit_p() and __exit from the driver's remove. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)