| Message ID | 1421177368-19756-2-git-send-email-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 13, 2015 at 11:29:23AM -0800, Tony Lindgren wrote: > On davinci_emac, we have pulse interrupts. This means that we need to > clear the EOI bits when disabling interrupts as otherwise the interrupts > keep happening. And we also need to not clear the EOI bits again when > enabling the interrupts as otherwise we will get tons of: > > unexpected IRQ trap at vector 00 > > These errors almost certainly mean that the omap-intc.c is signaling > a spurious interrupt with the reserved irq 127 as we've seen earlier > on omap3. > > Let's fix the issue by clearing the EOI bits when disabling the > interrupts. Let's also keep the comment for "Rx Threshold and Misc > interrupts are not enabled" for both enable and disable so people > are aware of this when potentially adding more support. > > Note that eventually we should handle the RX and TX interrupts > separately like cpsw is now doing. However, so far I have not seen > any issues with this based on my testing, so it seems to behave a > little different compared to the cpsw that had a similar issue. > > Cc: Brian Hutchinson <b.hutchman@gmail.com> > Cc: Felipe Balbi <balbi@ti.com> pretty much the same thing that happens with CPSW, I think that a future patch might want to change things so that we only write EOI to the IRQ that actually fires, though. Reviewed-by: Felipe Balbi <balbi@ti.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > drivers/net/ethernet/ti/davinci_emac.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c > index ea71251..383ed52 100644 > --- a/drivers/net/ethernet/ti/davinci_emac.c > +++ b/drivers/net/ethernet/ti/davinci_emac.c > @@ -922,6 +922,16 @@ static void emac_int_disable(struct emac_priv *priv) > if (priv->int_disable) > priv->int_disable(); > > + /* NOTE: Rx Threshold and Misc interrupts are not enabled */ > + > + /* ack rxen only then a new pulse will be generated */ > + emac_write(EMAC_DM646X_MACEOIVECTOR, > + EMAC_DM646X_MAC_EOI_C0_RXEN); > + > + /* ack txen- only then a new pulse will be generated */ > + emac_write(EMAC_DM646X_MACEOIVECTOR, > + EMAC_DM646X_MAC_EOI_C0_TXEN); > + > local_irq_restore(flags); > > } else { > @@ -951,15 +961,6 @@ static void emac_int_enable(struct emac_priv *priv) > * register */ > > /* NOTE: Rx Threshold and Misc interrupts are not enabled */ > - > - /* ack rxen only then a new pulse will be generated */ > - emac_write(EMAC_DM646X_MACEOIVECTOR, > - EMAC_DM646X_MAC_EOI_C0_RXEN); > - > - /* ack txen- only then a new pulse will be generated */ > - emac_write(EMAC_DM646X_MACEOIVECTOR, > - EMAC_DM646X_MAC_EOI_C0_TXEN); > - > } else { > /* Set DM644x control registers for interrupt control */ > emac_ctrl_write(EMAC_CTRL_EWCTL, 0x1); > -- > 2.1.4 >
* Felipe Balbi <balbi@ti.com> [150113 11:40]: > On Tue, Jan 13, 2015 at 11:29:23AM -0800, Tony Lindgren wrote: > > > > Note that eventually we should handle the RX and TX interrupts > > separately like cpsw is now doing. However, so far I have not seen > > any issues with this based on my testing, so it seems to behave a > > little different compared to the cpsw that had a similar issue. > > pretty much the same thing that happens with CPSW, I think that a future > patch might want to change things so that we only write EOI to the IRQ > that actually fires, though. Yeah I agree that's totally the way to go for the future. I've tried to expose that issue here with nuttcp but so far no luck. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c index ea71251..383ed52 100644 --- a/drivers/net/ethernet/ti/davinci_emac.c +++ b/drivers/net/ethernet/ti/davinci_emac.c @@ -922,6 +922,16 @@ static void emac_int_disable(struct emac_priv *priv) if (priv->int_disable) priv->int_disable(); + /* NOTE: Rx Threshold and Misc interrupts are not enabled */ + + /* ack rxen only then a new pulse will be generated */ + emac_write(EMAC_DM646X_MACEOIVECTOR, + EMAC_DM646X_MAC_EOI_C0_RXEN); + + /* ack txen- only then a new pulse will be generated */ + emac_write(EMAC_DM646X_MACEOIVECTOR, + EMAC_DM646X_MAC_EOI_C0_TXEN); + local_irq_restore(flags); } else { @@ -951,15 +961,6 @@ static void emac_int_enable(struct emac_priv *priv) * register */ /* NOTE: Rx Threshold and Misc interrupts are not enabled */ - - /* ack rxen only then a new pulse will be generated */ - emac_write(EMAC_DM646X_MACEOIVECTOR, - EMAC_DM646X_MAC_EOI_C0_RXEN); - - /* ack txen- only then a new pulse will be generated */ - emac_write(EMAC_DM646X_MACEOIVECTOR, - EMAC_DM646X_MAC_EOI_C0_TXEN); - } else { /* Set DM644x control registers for interrupt control */ emac_ctrl_write(EMAC_CTRL_EWCTL, 0x1);
On davinci_emac, we have pulse interrupts. This means that we need to clear the EOI bits when disabling interrupts as otherwise the interrupts keep happening. And we also need to not clear the EOI bits again when enabling the interrupts as otherwise we will get tons of: unexpected IRQ trap at vector 00 These errors almost certainly mean that the omap-intc.c is signaling a spurious interrupt with the reserved irq 127 as we've seen earlier on omap3. Let's fix the issue by clearing the EOI bits when disabling the interrupts. Let's also keep the comment for "Rx Threshold and Misc interrupts are not enabled" for both enable and disable so people are aware of this when potentially adding more support. Note that eventually we should handle the RX and TX interrupts separately like cpsw is now doing. However, so far I have not seen any issues with this based on my testing, so it seems to behave a little different compared to the cpsw that had a similar issue. Cc: Brian Hutchinson <b.hutchman@gmail.com> Cc: Felipe Balbi <balbi@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/net/ethernet/ti/davinci_emac.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)