diff mbox

[2/3] ARM: OMAP2+: gpmc: make gpmc_cs_get_name() static

Message ID 1422131320-1018-2-git-send-email-semen.protsenko@globallogic.com (mailing list archive)
State New, archived
Headers show

Commit Message

Semen Protsenko Jan. 24, 2015, 8:28 p.m. UTC
Fix sparse warning:
  warning: symbol 'gpmc_cs_get_name' was not declared. Should it be static?

Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
---
 drivers/memory/omap-gpmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Roger Quadros Jan. 26, 2015, 9:20 a.m. UTC | #1
On 24/01/15 22:28, Semen Protsenko wrote:
> Fix sparse warning:
>   warning: symbol 'gpmc_cs_get_name' was not declared. Should it be static?
> 
> Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

> ---
>  drivers/memory/omap-gpmc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 10eb4ac..db77adb 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -668,7 +668,7 @@ static void gpmc_cs_set_name(int cs, const char *name)
>  	gpmc->name = name;
>  }
>  
> -const char *gpmc_cs_get_name(int cs)
> +static const char *gpmc_cs_get_name(int cs)
>  {
>  	struct gpmc_cs_data *gpmc = &gpmc_cs[cs];
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Feb. 2, 2015, 5:07 p.m. UTC | #2
* Roger Quadros <rogerq@ti.com> [150126 01:23]:
> On 24/01/15 22:28, Semen Protsenko wrote:
> > Fix sparse warning:
> >   warning: symbol 'gpmc_cs_get_name' was not declared. Should it be static?
> > 
> > Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
> 
> Acked-by: Roger Quadros <rogerq@ti.com>

Roger is going to queue this, so:

Acked-by: Tony Lindgren <tony@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
index 10eb4ac..db77adb 100644
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -668,7 +668,7 @@  static void gpmc_cs_set_name(int cs, const char *name)
 	gpmc->name = name;
 }
 
-const char *gpmc_cs_get_name(int cs)
+static const char *gpmc_cs_get_name(int cs)
 {
 	struct gpmc_cs_data *gpmc = &gpmc_cs[cs];